Databases
StackOverflow2013
Postsdbo
POBest way to handle multiple queries in a class?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POBest way to handle multiple queries in a class?
    primarykey
    data
    text
    <p>We have an in-house PHP web application that is a financial analysis tool for our users. We process customers' financial information to analyze their ability to pay back a loan.</p> <p>We have built a class that has functions to generate lots of numbers and ratios. We use these to display totals, ratios, etc. throughout the different pages in the application. We have lots of functions that generate totals and lots of functions that use the totals from functions to generate new totals and ratios. Here's an example:</p> <pre><code>//Coverage Ratio public function CoverageRatio($hma) { return div_check(($this-&gt;NetFarmIncome($hma) + $this-&gt;NetNonFarmIncome($hma) - $this-&gt;FamilyLivingExpenses() - $this-&gt;IncomeTaxes()), ($this-&gt;InterestPortionTermDebt($hma) + $this-&gt;PrincipalPortionTermDebt($hma))); } //Operating Expense Ratio public function OperatingExpenseRatio($hma) { return div_check($this-&gt;FarmOperatingExpenses($hma), $this-&gt;GrossFarmIncome($hma)); } //Net Nonfarm Income public function NetNonfarmIncome($hma = null) { $result = $this-&gt;db-&gt;query("SELECT ah.id, COALESCE(v1.h1, 0) - COALESCE(v2.h2, 0) AS h, COALESCE(v1.p1, 0) - COALESCE(v2.p2, 0) AS p, COALESCE(v1.a1, 0) - COALESCE(v2.a2, 0) AS a FROM analysis_history ah LEFT JOIN (SELECT analysis_id, ... GROUP BY analysis_id) AS v2 ON v2.analysis_id = ah.id WHERE ah.id = $this-&gt;analysisid"); $row = $result-&gt;fetch_assoc(); return $row['a']; } //Net Business Income public function NetBusinessIncome($hma = null) { $result = $this-&gt;db-&gt;query("SELECT ah.id, COALESCE(v1.h1, 0) - COALESCE(v2.h2, 0) AS h, COALESCE(v1.p1, 0) - COALESCE(v2.p2, 0) AS p, COALESCE(v1.a1, 0) - COALESCE(v2.a2, 0) AS a FROM analysis_history ah LEFT JOIN (SELECT analysis_id, ... GROUP BY analysis_id) AS v2 ON v2.analysis_id = ah.id WHERE ah.id = $this-&gt;analysisid"); $row = $result-&gt;fetch_assoc(); return $row['a']; } </code></pre> <p>Over the last year, lots of changes have been made and we've had to add lots of new totals and ratios. After modifying our application to generate the page load time and count the number of queries that are executed, we were shocked. Our largest page takes .8 seconds to generate and has 122 queries.</p> <p>We've made some adjustments to decrease the number of queries, but we were only able to shave off about 10 queries total. Our average page has about 35 queries which we feel is just too much.</p> <p>In our class which holds the analysis logic, should we change the functions that pull data from multiple functions (and make several calls to the database) and just have them perform the single query? In my CoverageRatio example about, every function in it actually queries the database--6 separate queries.</p> <p>Which is the best way to better optimize our code? Is it fine the way it is--we like it this way just in case we need to make a change--we only change the function that generates that particular total. It would become a nightmare to have to manage 14+ functions that all use a net income calculation--if we ever had to modify how net income is calculated, we would have to change every query in every function that relies on that value. Thanks for your help!</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USJeff
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COHave you looked at optimizing the database too? Making sure you have good caching and indexing (on top of good table structure) can make a whole world of difference.
      singulars
      1. POBest way to handle multiple queries in a class?
      1. USBenOfTheNorth
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload