Note that there are some explanatory texts on larger screens.

plurals
  1. POJava Socket BufferReader.readline get null
    primarykey
    data
    text
    <p>I'm new in java and i try to write a simple client server with TCP Socket but i got trouble after some days struggle with it, i haven't able to solve this issue.</p> <p>I got null with BufferReader.Readline();</p> <p>MY server code:</p> <p>Start Server Code</p> <pre><code>public class StartServer { ServerSocket server; public StartServer(){ try { server = new ServerSocket(4444); } catch (Exception e) { System.out.println("server can't listen to this port"); } System.out.println("Listening for clients on 4444..."); int id =0; while(true) { try { Socket client = server.accept(); ServerThread svThread = new ServerThread(client, id++); svThread.start(); } catch (Exception e) { System.out.println("Error......."); } } } public static void main(String[] args) { new StartServer(); } } </code></pre> <p>Server Thread:</p> <pre><code>public class ServerThread extends Thread{ Socket client; int clientID = 0; boolean threadRun = true; BufferedReader inputFromClient = null; PrintWriter outputFromServer = null; public ServerThread(Socket socket, int cID) { client = socket; clientID = cID; } public void run() { try { inputFromClient = new BufferedReader(new InputStreamReader(client.getInputStream())); outputFromServer = new PrintWriter(new OutputStreamWriter(client.getOutputStream())); System.out.println("ClientID: " + clientID); while(threadRun){ String textFromClient = inputFromClient.readLine(); System.out.println("Client ID: " + clientID + " Client says: " + textFromClient); if(textFromClient.equals("Quit")){ threadRun = false; System.out.println("Stop client Thread from: " + clientID); }else{ outputFromServer.print(textFromClient); outputFromServer.flush(); } } } catch (IOException ex) { Logger.getLogger(ServerThread.class.getName()).log(Level.SEVERE, null, ex); }finally{ try { inputFromClient.close(); outputFromServer.close(); client.close(); System.out.println("Server Stopped..."); } catch (Exception e) { } } } } </code></pre> <p>My client i use JFrame call a Panel and use text field and jbutton to send message to server </p> <p>But when i send one message, server can receive this message and print it out to command line but it continue try to get message from client (because it inside while loop) but it receive null, i have no idea in this situation</p> <p>my CLient code:</p> <p>JFrame Code:</p> <pre><code>public class NewJFrame extends javax.swing.JFrame { /** * Creates new form NewJFrame */ Panel1 p ; public NewJFrame() { initComponents(); } /** * This method is called from within the constructor to initialize the form. * WARNING: Do NOT modify this code. The content of this method is always * regenerated by the Form Editor. */ @SuppressWarnings("unchecked") // &lt;editor-fold defaultstate="collapsed" desc="Generated Code"&gt; private void initComponents() { jDesktopPane1 = new javax.swing.JDesktopPane(); jPanel1 = new javax.swing.JPanel(); jButton1 = new javax.swing.JButton(); setDefaultCloseOperation(javax.swing.WindowConstants.EXIT_ON_CLOSE); jButton1.setText("jButton1"); jButton1.addActionListener(new java.awt.event.ActionListener() { public void actionPerformed(java.awt.event.ActionEvent evt) { jButton1ActionPerformed(evt); } }); javax.swing.GroupLayout jPanel1Layout = new javax.swing.GroupLayout(jPanel1); jPanel1.setLayout(jPanel1Layout); jPanel1Layout.setHorizontalGroup( jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING) .addGroup(javax.swing.GroupLayout.Alignment.TRAILING, jPanel1Layout.createSequentialGroup() .addContainerGap(196, Short.MAX_VALUE) .addComponent(jButton1) .addGap(91, 91, 91)) ); jPanel1Layout.setVerticalGroup( jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING) .addGroup(jPanel1Layout.createSequentialGroup() .addGap(83, 83, 83) .addComponent(jButton1) .addContainerGap(134, Short.MAX_VALUE)) ); jPanel1.setBounds(0, 0, 360, 240); jDesktopPane1.add(jPanel1, javax.swing.JLayeredPane.DEFAULT_LAYER); javax.swing.GroupLayout layout = new javax.swing.GroupLayout(getContentPane()); getContentPane().setLayout(layout); layout.setHorizontalGroup( layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING) .addGroup(layout.createSequentialGroup() .addComponent(jDesktopPane1, javax.swing.GroupLayout.PREFERRED_SIZE, 365, javax.swing.GroupLayout.PREFERRED_SIZE) .addGap(0, 35, Short.MAX_VALUE)) ); layout.setVerticalGroup( layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING) .addGroup(layout.createSequentialGroup() .addComponent(jDesktopPane1, javax.swing.GroupLayout.PREFERRED_SIZE, 265, javax.swing.GroupLayout.PREFERRED_SIZE) .addGap(0, 35, Short.MAX_VALUE)) ); pack(); }// &lt;/editor-fold&gt; private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) { // TODO add your handling code here: p = new Panel1(); jDesktopPane1.removeAll(); jDesktopPane1.repaint(); jDesktopPane1.revalidate(); p.setBounds(0, 0, 840, 558); p.setSize(840,558); jDesktopPane1.add(p); p.show(); } /** * @param args the command line arguments */ public static void main(String args[]) { /* * Set the Nimbus look and feel */ //&lt;editor-fold defaultstate="collapsed" desc=" Look and feel setting code (optional) "&gt; /* * If Nimbus (introduced in Java SE 6) is not available, stay with the * default look and feel. For details see * http://download.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html */ try { for (javax.swing.UIManager.LookAndFeelInfo info : javax.swing.UIManager.getInstalledLookAndFeels()) { if ("Nimbus".equals(info.getName())) { javax.swing.UIManager.setLookAndFeel(info.getClassName()); break; } } } catch (ClassNotFoundException ex) { java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex); } catch (InstantiationException ex) { java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex); } catch (IllegalAccessException ex) { java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex); } catch (javax.swing.UnsupportedLookAndFeelException ex) { java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex); } //&lt;/editor-fold&gt; /* * Create and display the form */ java.awt.EventQueue.invokeLater(new Runnable() { public void run() { new NewJFrame().setVisible(true); } }); } // Variables declaration - do not modify private javax.swing.JButton jButton1; private javax.swing.JDesktopPane jDesktopPane1; private javax.swing.JPanel jPanel1; // End of variables declaration } </code></pre> <p>My Panel code:</p> <pre><code>public class Panel1 extends javax.swing.JPanel { Socket s; PrintWriter outPut = null; /** * Creates new form Panel1 */ public Panel1() { initComponents(); ConnectServer(); //sendToServer(); // receiveFromServer(); } /** * This method is called from within the constructor to initialize the form. * WARNING: Do NOT modify this code. The content of this method is always * regenerated by the Form Editor. */ public void ConnectServer(){ try { s = new Socket("localhost", 4444); System.out.println("Connect to server"); outPut = new PrintWriter(new OutputStreamWriter(s.getOutputStream())); // PrintWriter outPut = new PrintWriter(new OutputStreamWriter(s.getOutputStream())); //outPut.println("Test cai coi....."); //outPut.flush(); } catch (UnknownHostException ex) { Logger.getLogger(Panel1.class.getName()).log(Level.SEVERE, null, ex); } catch (IOException ex) { Logger.getLogger(Panel1.class.getName()).log(Level.SEVERE, null, ex); } } public void receiveFromServer(){ try { BufferedReader input = new BufferedReader(new InputStreamReader(s.getInputStream())); System.out.println(input.readLine()); } catch (IOException ex) { Logger.getLogger(Panel1.class.getName()).log(Level.SEVERE, null, ex); } } @SuppressWarnings("unchecked") // &lt;editor-fold defaultstate="collapsed" desc="Generated Code"&gt; private void initComponents() { jTextField1 = new javax.swing.JTextField(); jButton1 = new javax.swing.JButton(); jButton1.setText("jButton1"); jButton1.addActionListener(new java.awt.event.ActionListener() { public void actionPerformed(java.awt.event.ActionEvent evt) { jButton1ActionPerformed(evt); } }); javax.swing.GroupLayout layout = new javax.swing.GroupLayout(this); this.setLayout(layout); layout.setHorizontalGroup( layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING) .addGroup(layout.createSequentialGroup() .addGap(26, 26, 26) .addComponent(jTextField1, javax.swing.GroupLayout.PREFERRED_SIZE, 138, javax.swing.GroupLayout.PREFERRED_SIZE) .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED) .addComponent(jButton1) .addContainerGap(157, Short.MAX_VALUE)) ); layout.setVerticalGroup( layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING) .addGroup(layout.createSequentialGroup() .addGap(34, 34, 34) .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.BASELINE) .addComponent(jTextField1, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE) .addComponent(jButton1)) .addContainerGap(243, Short.MAX_VALUE)) ); }// &lt;/editor-fold&gt; private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) { //PrintWriter outPut = null; PrintWriter outToServer = null; BufferedReader input = null; try { // TODO add your handling code here: outToServer = new PrintWriter(new OutputStreamWriter(s.getOutputStream())); String txtFromClient = jTextField1.getText(); // String clientText = input.readLine(); System.out.println(txtFromClient); outToServer.println(txtFromClient); outToServer.flush(); // //outPut.flush(); //System.out.println(input.readLine()); } catch (Exception ex) { Logger.getLogger(Panel1.class.getName()).log(Level.SEVERE, null, ex); } finally { //outPut.close(); outToServer.close(); } } // Variables declaration - do not modify private javax.swing.JButton jButton1; private javax.swing.JTextField jTextField1; // End of variables declaration } </code></pre> <p>And my stacktrace from server:</p> <pre><code>Exception in thread "Thread-0" java.lang.NullPointerException at testserverclient.ServerThread.run(ServerThread.java:39) </code></pre> <p>Line 39 is:</p> <pre><code>if(textFromClient.equals("Quit")) </code></pre>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
 

Querying!

 
Guidance

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload