Databases
StackOverflow2013
Postsdbo
PONetty, problems with custom handler for HTTP PUT requests "cannot send more responses than requests"
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PONetty, problems with custom handler for HTTP PUT requests "cannot send more responses than requests"
    primarykey
    data
    text
    <p>I am working on a Netty server, I am having issues with a custom handler I created to receive file uploads via HTTP PUT requests. Everything seems to work fine when I just send a few files at a time, however after about 300 connections the server seems to "break". The server will then throw the follow exception on each received request. After this starts happening, the server no longer handles the requests and needs to be restarted:</p> <pre><code> java.lang.IllegalStateException: cannot send more responses than requests at org.jboss.netty.handler.codec.http.HttpContentEncoder.writeRequested(HttpContentEncoder.java:104) at org.jboss.netty.handler.execution.ExecutionHandler.handleDownstream(ExecutionHandler.java:165) at org.jboss.netty.channel.Channels.write(Channels.java:605) at org.jboss.netty.channel.Channels.write(Channels.java:572) .... </code></pre> <p>Here is my handler source channelRecieved, all the requests i'm handling are chunked, so I will include those methods below:</p> <pre><code>@Override public void messageReceived(ChannelHandlerContext context, MessageEvent event) throws Exception { try { log.trace("Message recieved"); if (newMessage) { log.trace("New message"); HttpRequest request = (HttpRequest) event.getMessage(); setDestinationFile(context, request); newMessage = false; if (request.isChunked()) { log.trace("Chunked request, set readingChunks true and create byte buffer"); requestContentStream = new ByteArrayOutputStream(); readingChunks = true; return; } else { log.trace("Request not chunked"); writeNonChunkedFile(request); requestComplete(event); return; } } else if (readingChunks){ log.trace("Reading chunks"); HttpChunk chunk = (HttpChunk) event.getMessage(); if (chunk.isLast()) { log.trace("Read last chunk"); readingChunks = false; writeChunkedFile(); requestComplete(event); return; } else { log.trace("Buffering chunk content to byte buffer"); requestContentStream.write(chunk.getContent().array()); return; } // should not happen } else { log.error("Error handling of MessageEvent, expecting a new message or a chunk from a previous message"); } } catch (Exception ex) { log.error("Exception: [" + ex + "]"); sendError(context, INTERNAL_SERVER_ERROR); } } </code></pre> <p>This is how I am writing the chunked requests:</p> <pre><code>private void writeChunkedFile() throws IOException { log.trace("Writing chunked file"); byte[] data = requestContentStream.toByteArray(); FileOutputStream fos = new FileOutputStream(destinationFile); fos.write(data); fos.close(); log.debug("File upload complete, [chunked], path: [" + destinationFile.getAbsolutePath() + "] size: [" + destinationFile.length() + "] bytes"); } </code></pre> <p>This is how I send the response and close the connection:</p> <pre><code>private void requestComplete(MessageEvent event) { log.trace("Request complete"); HttpResponse response = new DefaultHttpResponse(HTTP_1_1, OK); Channel channel = event.getChannel(); ChannelFuture cf = channel.write(response); cf.addListener(ChannelFutureListener.CLOSE); } </code></pre> <p>I have tried a few things in requestComplete, one being just channel.close() which didn't seem to help. Any other thoughts or ideas?</p> <p>Here is my pipeline:</p> <pre><code>@Override public ChannelPipeline getPipeline() throws Exception { final ChannelPipeline pipeline = pipeline(); pipeline.addLast("decoder", new HttpRequestDecoder()); pipeline.addLast("encoder", new HttpResponseEncoder()); pipeline.addLast("deflater", new HttpContentCompressor()); pipeline.addLast("ExecutionHandler", executionHandler); </code></pre> <p>pipeline.addLast("handler", new FileUploadHandler()); return pipeline; }</p> <p>Thanks for any thoughts or ideas</p> <p>Edit: sample log entry when logging between deflator and handler in pipeline:</p> <pre><code>2012-03-23T07:46:40.993 [New I/O server worker #1-6] WARN NbEvents [c.c.c.r.d.l.s.h.SbApiMessageLogger.writeRequested] [] - Sending [DefaultHttpResponse(chunked: false) HTTP/1.1 100 Continue] 2012-03-23T07:46:40.995 [New I/O server worker #1-6] WARN NbEvents [c.c.c.r.d.l.s.h.SbApiMessageLogger.writeRequested] [] - Sending [DefaultHttpResponse(chunked: false) HTTP/1.1 500 Internal Server Error Content-Type: text/plain; charset=UTF-8] 2012-03-23T07:46:41.000 [New I/O server worker #1-7] DEBUG NbEvents [c.c.c.r.d.l.s.h.SbApiMessageLogger.messageReceived] [] - Received [PUT /a/deeper/path/testFile.txt HTTP/1.1 User-Agent: curl/7.19.7 (x86_64-redhat-linux-gnu) libcurl/7.19.7 NSS/3.12.9.0 zlib/1.2.3 libidn/1.18 libssh2/1.2.2 Host: 192.168.0.1:8080 Accept: */* Content-Length: 256000 Expect: 100-continue </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USZugdud
    1. USZugdud
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COSomethin not related to the problem but adding the ExectionHandler at the end of the ChannelPipeline does not give you any advances. The ExecutionHandler will only work for the ChannelHandlers that are behind it in the ChannelPipeline
      singulars
      1. PONetty, problems with custom handler for HTTP PUT requests "cannot send more responses than requests"
      1. USNorman Maurer
    2. COHow do you add the HttpContentEncoder to the ChannelPipeline ? I don't see it in your code ? Do you share an instance by any chance ?
      singulars
      1. PONetty, problems with custom handler for HTTP PUT requests "cannot send more responses than requests"
      1. USNorman Maurer
    3. COThanks, I updated my pipline so that pipeline.addLast("handler", new FileUploadHandler()); comes after the executionHandler. As for the HttpContentEncoder I am not using that anywhere in my code, do I need to be? I thought response encoding was handled by HttpResponseEncoder().
      singulars
      1. PONetty, problems with custom handler for HTTP PUT requests "cannot send more responses than requests"
      1. USZugdud
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload