Databases
StackOverflow2013
Postsdbo
POChange DenyHosts report: Call external command from Python
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POChange DenyHosts report: Call external command from Python
    primarykey
    data
    text
    <p>To begin with, I don't know the first thing about Python ... so I can really use any pointers you have. I do know some Perl, Bash scripting and a bit C++.</p> <p>I'm running DenyHosts (http://denyhosts.sourceforge.net/) which every now and then sends me a message through email that an IP address was added to /etc/deny.hosts. Eg.:</p> <pre><code>Added the following hosts to /etc/hosts.deny: 87.215.133.109 (unknown) ---------------------------------------------------------------------- </code></pre> <p>So far so good, but I want to add the country of the IP address to this message. To do this I created a small Perl script that spits out the country:</p> <pre><code>/usr/local/bin/geo-ip.pl --short 87.215.133.109 Netherlands </code></pre> <p>So all I want to do is to call this Perl script from Python and then fill the result in the message string. I located the source code which I suspect I need to change, but as announced at the top of this message, I don't know the first thing about Python.</p> <p>This is a sniplet from the main program calling a subroutine in report.py</p> <p>deny_hosts.py:</p> <pre><code>#print deny_hosts new_denied_hosts, status = self.update_hosts_deny(deny_hosts) if new_denied_hosts: if not status: msg = "WARNING: Could not add the following hosts to %s" % self.__prefs.get('HOSTS_DENY') else: msg = "Added the following hosts to %s" % self.__prefs.get('HOSTS_DENY') self.__report.add_section(msg, new_denied_hosts) if self.__sync_server: self.sync_add_hosts(new_denied_hosts) plugin_deny = self.__prefs.get('PLUGIN_DENY') if plugin_deny: plugin.execute(plugin_deny, new_denied_hosts) </code></pre> <p>I think the change should go somewhere in here. report.py defines the add_section:</p> <pre><code>def add_section(self, message, iterable): self.report += "%s:\n\n" % message for i in iterable: if type(i) in (TupleType, ListType): extra = ": %d\n" % i[1] i = i[0] else: extra = "" if self.hostname_lookup: hostname = self.get_hostname(i) debug("get_host: %s", hostname) else: hostname = i self.report += "%s%s\n" % (hostname, extra) if self.use_syslog: syslog.syslog("%s - %s%s" %(message, hostname, extra)) self.report += "\n" + "-" * 70 + "\n" </code></pre> <p>Please help me change the code in such a way that it'll spit out a message like:</p> <pre><code>Added the following hosts to /etc/hosts.deny: 87.215.133.109 (Netherlands, unknown) ---------------------------------------------------------------------- </code></pre> <p><strong>EDIT3:</strong> This is how I solved it. The output is identical to the original message. After changing the sources, the daemon needs to be restarted (sudo /etc/init.d/denyhosts restart)</p> <pre><code> def add_section(self, message, iterable): # added geo-ip # moving this from statement to the top of the file makes pycheck generate # a lot of errors, so I left it here. from subprocess import Popen, PIPE # end geo-ip hack import self.report += "%s:\n\n" % message for i in iterable: if type(i) in (TupleType, ListType): extra = ": %d\n" % i[1] i = i[0] else: extra = "" if self.hostname_lookup: hostname = self.get_hostname(i) debug("get_host: %s", hostname) else: hostname = i # self.report += "%s%s\n" % (hostname, extra) # JPH: added geo-ip geocmd = "/usr/local/bin/geo-ip.pl --short %s" % i country = Popen( geocmd, shell=True, stdout=PIPE).communicate()[0] country = country.strip() self.report += "%s%s\n%s\n" % (hostname, extra, country) # end geo-ip hack if self.use_syslog: syslog.syslog("%s - %s%s" %(message, hostname, extra)) self.report += "\n" + "-" * 70 + "\n" </code></pre> <p>Also help me understand what I change, so I can learn a bit Python today too. </p> <p><strong>EDIT2</strong>: For the sake of sharing a link to the geo-ip.pl script <a href="http://wirespeed.xs4all.nl/mediawiki/index.php/Geo-ip.pl" rel="nofollow">http://wirespeed.xs4all.nl/mediawiki/index.php/Geo-ip.pl</a></p> <p><strong>EDIT1</strong>: Recompilation is done automatically when the source changes, so that answers the question below. The second problem I have with this is that I found two matching files on my system:</p> <ul> <li>/usr/share/denyhosts/DenyHosts/report.py</li> <li>/usr/share/denyhosts/DenyHosts/report.pyc</li> </ul> <p>where the .py is the source code and I suspect .pyc actually being executed. So when I change the source code, I wouldn't be surprised nothing changes if I don't somehow compile it afterwards.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USjippie
    1. USjippie
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POChange DenyHosts report: Call external command from Python
      1. This table or related slice is empty.
      1. VTUpMod
    1. COYou don't need to compile the source. The `.pyc` file is a cached byte-code representation that is automatically rebuild when you change and then rerun the script. You can run an external command with ``os.system``. Btw.
      singulars
      1. POChange DenyHosts report: Call external command from Python
      1. USAndreas Mueller
    2. CO@AndreasMueller: `os.system` wont let him get the return value.
      singulars
      1. POChange DenyHosts report: Call external command from Python
      1. USjdi
    3. COI'd love to help you out here, but your question is just all over the place - if all you *really* want to do is execute an external command and store the output in a variable, check out the excellent `subprocess` module. Create a simple script that does only that. Fix it. Then tackle the next problem.
      singulars
      1. POChange DenyHosts report: Call external command from Python
      1. USDaren Thomas
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload