Databases
StackOverflow2013
Postsdbo
POIssue with if (mb_strlen() != #)
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIssue with if (mb_strlen() != #)
    primarykey
    data
    text
    <p>This is probably really dirty and messy code, so any input on that would be helpful as well, but my main issue is that I can't get the "ISBN" input to process if the string is the correct number of characters (10 or 13). I'm not sure where it is going wrong. It's on line 64.</p> <p>Please help! Thank you.</p> <p> </p> <pre><code>&lt;head&gt; &lt;meta http-equiv="Content-Type" content="text/html; charset=utf-8" /&gt; &lt;title&gt;Link Generator&lt;/title&gt; &lt;/head&gt; &lt;body&gt; &lt;?php function showForm() { if (empty($_POST['title'])) { $title = "Book Title"; } else { $title = $_POST['title']; } ?&gt; &lt;form action="&lt;?php $_SERVER['PHP_SELF'] ?&gt;" method="post"&gt; Search by ISBN&lt;br /&gt; &lt;input type="text" maxlength="13" name="ISBN" size="30" value="ISBN" onblur="if(this.value == '') { this.value='ISBN'}" onfocus="if (this.value == 'ISBN') {this.value=''}" /&gt;&lt;br /&gt; &lt;br /&gt;OR&lt;br /&gt;&lt;br /&gt; Search by Title &lt;strong&gt;and&lt;/strong&gt; Author&lt;br /&gt; &lt;input type="text" maxlength="13" name="title" size="30" value="&lt;?php echo $title; ?&gt;" onblur="if(this.value == '') { this.value='Book Title'}" onfocus="if (this.value == 'Book Title') {this.value=''}" /&gt;&lt;br /&gt; &lt;input type="text" maxlength="13" name="aname" size="30" value="Author Name" onblur="if(this.value == '') { this.value='Author Name'}" onfocus="if (this.value == 'Author Name') {this.value=''}" /&gt;&lt;br /&gt; &lt;br /&gt;&lt;input type="submit" name="submit" value="Generate Link" /&gt; &lt;/form&gt; &lt;?php } function generateLink_ISBN() { echo "Your link has been generated:&lt;br /&gt;"; echo "http://xxx.com/uhtbin/cgisirsi.exe/x/0/0/5?search_type=search&amp;searchdata1=" . $_POST['ISBN'] . "&amp;library=ALL&amp;sort_by=PBYR"; } function generateLink_title() { echo "Your link has been generated:&lt;br /&gt;"; echo "http://xxx.com/uhtbin/cgisirsi.exe/x/0/0/5?search_type=search&amp;searchdata1=" . $_POST['title'] . "+" . $_POST['aname'] . "&amp;library=ALL&amp;sort_by=PBYR"; } if(isset($_POST['submit'])) { if (isset($_POST['ISBN']) &amp;&amp; isset($_POST['title']) &amp;&amp; isset($_POST['aname']) &amp;&amp; ($_POST['ISBN'] == 'ISBN') &amp;&amp; ($_POST['aname'] == 'Author Name') &amp;&amp; ($_POST['title'] == 'Book Title')) { echo "&lt;h1&gt;You did not input any information&lt;/h1&gt;"; showForm(); } elseif (isset($_POST['ISBN']) &amp;&amp; ($_POST['ISBN'] != 'ISBN')) { if (isset($_POST['ISBN']) &amp;&amp; ($_POST['ISBN'] != 'ISBN') &amp;&amp; (!is_numeric ($_POST['ISBN']))) { echo "&lt;h1&gt;The ISBN you entered did not contain all numerics&lt;/h1&gt;"; showForm(); } elseif (isset($_POST['ISBN']) &amp;&amp; ($_POST['ISBN'] != 'ISBN') &amp;&amp; ((mb_strlen($_POST['ISBN'], 'utf-8') != 13) | (mb_strlen($_POST['ISBN'], 'utf-8') != 10))) { echo "&lt;h1&gt;The ISBN you entered was too long or too short. ISBN's are 10 or 13 numbers in length.&lt;/h1&gt;"; showForm(); } else { generateLink_ISBN(); } } elseif (isset($_POST['title']) &amp;&amp; isset($_POST['aname']) &amp;&amp; ($_POST['aname'] != 'Author Name') | ($_POST['title'] != 'Book Title')) { if (isset($_POST['title']) &amp;&amp; isset($_POST['aname']) &amp;&amp; ($_POST['title'] == 'Book Title') &amp;&amp; ($_POST['aname'] != 'Author Name')) { echo "&lt;h1&gt;To search by author's name, you must also include the book title.&lt;/h1&gt;"; showForm(); } elseif (isset($_POST['title']) &amp;&amp; isset($_POST['aname']) &amp;&amp; ($_POST['aname'] == 'Author Name') &amp;&amp; ($_POST['title'] != 'Book Title')) { echo "&lt;h1&gt;To search by book title, you must also include the author's name.&lt;/h1&gt;"; showForm(); } else { generateLink_title(); } } else { showForm(); } } else { showForm(); } ?&gt; &lt;/body&gt; </code></pre> <p></p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USjmalais
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COSince you asked for input on your code: Do whatever you can to separate processing and the presentation. I like to use templating systems for this like Smarty. If that's too big of a production, consider preparing your form in one file and displaying it with another. It makes life a lot easier when you know you can change the logic without wading through/breaking the interface. Also, don't forget to validate the data from the POST. Assume users are evil. :)
      singulars
      1. POIssue with if (mb_strlen() != #)
      1. USSurreal Dreams
    2. COSorry I'm new at php, how would I validate it? And in this case, I don't think it will be necessary because its merely generating a link to a search query?
      singulars
      1. POIssue with if (mb_strlen() != #)
      1. USjmalais
    3. CO@jmalais Correct. The validation you perform above should be adequate for generating a link - the web service you call out to should be validating their inputs as well, so the worst that is likely to happen is you generate a bad link cause the user gave you bad data. In general though, it's a good idea to validate, if nothing else just to stop your script from bombing if it makes an assumption about inputs. Take a look at the PHP filter documentation: http://www.php.net/manual/en/book.filter.php
      singulars
      1. POIssue with if (mb_strlen() != #)
      1. USRyan P
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload