Databases
StackOverflow2013
Postsdbo
POHow can I break down some methods in the spring service layer
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POHow can I break down some methods in the spring service layer
    primarykey
    data
    text
    <p>I'm doing some maintenance/evolution on a multi-layered spring 3.0 project. The client is a heavy RCP application invoking some spring beans methods from the service layer (Managers) on a RMI based server. I have several huge method in the Managers, some of them are doing more than 250 lines.Here is an example : (I've omitted code for clarity)</p> <pre><code> @Transactional(readOnly = false, propagation = Propagation.REQUIRED) public Declaration saveOrUpdateOrDelete(Declaration decla, List&lt;Declaration&gt; toDeleteList ...){ if (decla.isNew()){ // create from scratch and apply business rules for a creation manager1.compute(decla); dao1.save(decla); ... }else if (decla.isCopy() { // Copy from an other Declaration and apply business rules for a copy ... }else { // update Declaration ... } if (toDeleteList!=null){ // Delete declarations and apply business rules for a mass delete ... } </code></pre> <p>The first 3 branches are mutually exclusive and represent a unit of work. The last branch (delete) can happen simultaneously with other branches.</p> <p>Isn't it better to divide this method in something more 'CRUDy' for the sake of clarity and maintainability ? I've been thinking of dividing this behemoth into other manager methods like :</p> <pre><code>public Declaration create(Declaration decla ...){... public Declaration update(Declaration decla ...){... public Declaration copyFrom(Declaration decla ...){... public void delete(List&lt;Declaration&gt; declaList ...){... </code></pre> <p>But my colleagues say it will transfer complexity and business rules to the client that I will loose the benefit of atomicity etc.. Who is right here ?</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USwebpat
    1. USwebpat
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POHow can I break down some methods in the spring service layer
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POHow can I break down some methods in the spring service layer
      1. This table or related slice is empty.
      1. VTUpMod
    1. This table or related slice is empty.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload