Databases
StackOverflow2013
Postsdbo
POWhy does Django make Python look ugly?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POWhy does Django make Python look ugly?
    primarykey
    data
    text
    <p>I took up the Python programming language because of its design philosophies, its great community and most importantly for me its beautiful syntax. However, recently I've been a left a little disheartend. In my attempts to customise Django I've come across code that I think syntactically could be cleaner. I'm by no means a seasoned Python programmer, in-fact I've only been using it properly for the past few months. I'd appreciate your insights and your views. </p> <p>Here are some examples of code I have come across:</p> <p>Why is there a need for the slash?</p> <pre><code>from django.contrib.admin.util import get_model_from_relation, \ reverse_field_path, get_limit_choices_to_from_path </code></pre> <p>Could this be written more elegantly?</p> <pre><code> rel_name = other_model._meta.pk.name self.lookup_kwarg = '%s__%s__exact' % (self.field_path, rel_name) self.lookup_kwarg_isnull = '%s__isnull' % (self.field_path) self.lookup_val = request.GET.get(self.lookup_kwarg, None) self.lookup_val_isnull = request.GET.get( self.lookup_kwarg_isnull, None) self.lookup_choices = f.get_choices(include_blank=False) </code></pre> <p>One thing I don't understand is why the code after the if statement for each and statement is on seperate lines?</p> <pre><code>def has_output(self): if isinstance(self.field, models.related.RelatedObject) \ and self.field.field.null or hasattr(self.field, 'rel') \ and self.field.null: extra = 1 else: extra = 0 return len(self.lookup_choices) + extra &gt; 1 </code></pre> <p>This just looks messy!</p> <pre><code>def choices(self, cl): from django.contrib.admin.views.main import EMPTY_CHANGELIST_VALUE yield {'selected': self.lookup_val is None and not self.lookup_val_isnull, 'query_string': cl.get_query_string( {}, [self.lookup_kwarg, self.lookup_kwarg_isnull]), 'display': _('All')} for pk_val, val in self.lookup_choices: yield {'selected': self.lookup_val == smart_unicode(pk_val), 'query_string': cl.get_query_string( {self.lookup_kwarg: pk_val}, [self.lookup_kwarg_isnull]), 'display': val} if isinstance(self.field, models.related.RelatedObject) \ and self.field.field.null or hasattr(self.field, 'rel') \ and self.field.null: yield {'selected': bool(self.lookup_val_isnull), 'query_string': cl.get_query_string( {self.lookup_kwarg_isnull: 'True'}, [self.lookup_kwarg]), 'display': EMPTY_CHANGELIST_VALUE} </code></pre> <p>Please don't get me wrong, I'm not doing a disservice to the many contributors of Django, on the contrary I really admire them and I'm grateful. I appreciate that maybe it's my lack of experience with Python itself or that bits of code that make the syntax look unclean are in-fact core features of the Python programming language.</p> <p><strong>Just to make it clear this question is genuine and sincere, I ask this question in the spirit of learning and discussion. If you don't have anything conducive to contribute please don't respond.</strong></p> <p>Thank You</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USImran Azad
    1. USImran Azad
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POWhy does Django make Python look ugly?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POWhy does Django make Python look ugly?
      1. This table or related slice is empty.
      1. VTDownMod
    3. VO
      singulars
      1. POWhy does Django make Python look ugly?
      1. This table or related slice is empty.
      1. VTUpMod
    1. COAll the "\" are there to be able to continue the code in the next line. It's a way to keep rows short (for example, less than 80 characters). Keeping it that way is common, because you can see all the code in the same area. Now, for the "if" conditions, I would have surrounded everything in parentheses, which removes the need for "\" at the end of the line...
      singulars
      1. POWhy does Django make Python look ugly?
      1. USRicardo Cárdenes
    2. CO@RicardoCárdenes: the backslashes are not required, and they actually are discouraged in the Python style guide.
      singulars
      1. POWhy does Django make Python look ugly?
      1. USBastien Léonard
    3. COI agree with Bastien, this code could have been written in many other languages very similarly. No use of elegant Python features there.
      singulars
      1. POWhy does Django make Python look ugly?
      1. USNiklas B.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload