Databases
StackOverflow2013
Postsdbo
POUndefined index on GET variables when trying to create reset password page in PHP
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POUndefined index on GET variables when trying to create reset password page in PHP
    primarykey
    data
    text
    <p>I'm working on a PHP page that allows the user to reset their password. I have got to the point where a username is entered and an email is sent with a link to change the password.</p> <p>However when I go to change the password I'm getting the following errors</p> <pre><code>Notice: Undefined index: email in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\reset-password.php on line 112 Notice: Undefined index: hash in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\reset-password.php on line 112 </code></pre> <p>This is my code for reset-password.php...</p> <pre><code>&lt;?php $msg = ""; // If user is visiting using the link provided in the email if(isset($_GET['email']) &amp;&amp; !empty($_GET['email']) AND isset($_GET['hash']) &amp;&amp; !empty($_GET['hash'])) { $email = checkInput($_GET['email']); // Set email variable $hash = checkInput($_GET['hash']); // Set hash variable $search = mysql_query("SELECT email, hash FROM users WHERE email='".$email."' AND hash='".$hash."'") or die(mysql_error()); $match = mysql_num_rows($search); if($match &gt; 0) { // There is a match -&gt; show change password form changePassForm(); } else { // No match -&gt; dont show password form (invalid url) $msg .= '&lt;div class="success" align="center"&gt;An email with a link to reset your password has been sent to your registered email account. Please click the link to reset your password.&lt;/div&gt;'; } } // Else user is not visting from a link provided in an email. else // First check if user has already submitted form to send change password link { if(isset($_POST['submit-request'])) { $username = checkInput($_POST['username']); $query = "SELECT username FROM users WHERE username = '$username'"; $result = mysql_query($query); $search = mysql_num_rows($result); // Checks if the username they entered exists - if so, call sendResetMail function. if($search &gt; 0) { $msg .= '&lt;div class="success" align="center"&gt;An email with a link to reset your password has been sent to your registered email account. Please click the link to reset your password.&lt;/div&gt;'; sendResetMail(); // Calls the sendMail function - sends the activation email to the user. } // Else username does not exist in database else { $msg .= '&lt;div class="error" align="center"&gt;That username does not exist. Please try again.&lt;/div&gt;'; requestForgotPassEmail(); } } // If user has not already submitted form, show them form. else { requestForgotPassEmail(); $msg .= "request email"; } } /* Initialize empty containers for the errors */ $rpnewpass_errors = ""; $rpnewpasschk_errors = ""; $msg = ""; // If changePassForm has been submitted if(isset($_POST['submit-change'])) { $newpass=isset($_POST['newpass']) ? checkInput($_POST['newpass']) : ''; $newpasschk=isset($_POST['newpasschk']) ? checkInput($_POST['newpasschk']) : ''; /* Checks all fields were entered */ if(!$_POST['newpass'] || !$_POST['newpasschk']) { $msg .= '&lt;div class="error" align="center"&gt;You didn\'t a required field - please complete all the fields&lt;/div&gt;'; } else { /* Once all fields are entered - perform form validation */ /* Checks the new password field is entered */ if(empty($newpass)) { $newpass=false; $rpnewpass_errors .= "You didn't enter a new password"; } /* Checks if the password contains at least 8 characters, lower/upper case letters and a number. */ if(preg_match("/^.*(?=.{8,})(?=.*[0-9])(?=.*[a-z])(?=.*[A-Z]).*$/", $newpass) === 0) { $msg .= '&lt;div class="error" align="center"&gt;Password must be at least 8 characters and contain at least one lower case letter, one upper case letter and a number&lt;/div&gt;'; } /* Checks the verify new password field is entered */ if(empty($newpasschk)) { $msg .= '&lt;div class="error" align="center"&gt;You didnt verify your new password.&lt;/div&gt;'; } /* Checks if the new password and verify new password match */ if($newpass != $newpasschk) { $msg .= '&lt;div class="error" align="center"&gt;Sorry, your passwords do not match.&lt;/div&gt;'; } /* Checks if all error containers are empty, then proceeds with password change */ if(empty($rpnewpass_errors) &amp;&amp; empty($rpnewpasschk_errors)) { $query="SELECT username FROM users WHERE email = '$email' AND hash = '$hash'"; echo $query; // for troubleshooting purposes, variables are echoing empty $result=mysql_query($query); $num=mysql_num_rows($result); if($num == 1) { $row=mysql_fetch_array($result); $md5newpass=md5($newpass); $query="UPDATE users SET password = '$md5newpass' WHERE username = '$row[0]'"; $result=mysql_query($query); if(mysql_affected_rows() == 1) { $msg .= '&lt;div class="error" align="center"&gt;Your password has been changed successfully&lt;/div&gt;'; } else { $msg .= '&lt;div class="error" align="center"&gt;Your password could not be changed. Please try again&lt;/div&gt;'; } } else { $msg .= '&lt;div class="error" align="center"&gt;Your username and password do not match our records&lt;/div&gt;'; } } } } ?&gt; </code></pre> <p>I guess I'm somewhere/somehow losing the GET variables from the link but not sure how I can get around this - its been a long day and I've been stuck on this for a while so apologies for any obvious mistake!</p> <p>Thanks.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USBernard
    1. USBernard
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COYou leak a lot of info. What's the line 32? What does checkInput() ?
      singulars
      1. POUndefined index on GET variables when trying to create reset password page in PHP
      1. USAurelio De Rosa
    2. COsorry that was wrong line, should be 142
      singulars
      1. POUndefined index on GET variables when trying to create reset password page in PHP
      1. USBernard
    3. COThere is no line 142
      singulars
      1. POUndefined index on GET variables when trying to create reset password page in PHP
      1. USDr.Molle
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload