Databases
StackOverflow2013
Postsdbo
POCan this code be improved with the use of multithreading?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POCan this code be improved with the use of multithreading?
    primarykey
    data
    text
    <p>I have a simple Windows service, which runs only once per day. It performs some queries in database, generates appropriate html content (tables, divs, ...) and sends it in body of an e-mail to multiple recipients.</p> <p>The body of the e-mail is created like this:</p> <pre><code>private static string GenerateBody() { using (var stringWriter = new StringWriter()) using (var htmlWriter = new HtmlTextWriter(stringWriter)) { htmlWriter.RenderBeginTag("html"); htmlWriter.RenderBeginTag(HtmlTextWriterTag.Head); htmlWriter.WriteLine("&lt;meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" /&gt;"); htmlWriter.RenderEndTag(); htmlWriter.RenderBeginTag("body"); htmlWriter.Write( new StringBuilder() .Append(OverviewParagraph.GenerateHTMLContent()) .Append(PackageWeightParagraph.GenerateHTMLContent()) .Append(BoxWeightParagraph.GenerateHTMLContent()) .Append(CodeQualityParagraph.GenerateHTMLContent()) .Append(ChecksParagraph.GenerateHTMLContent()) .ToString() ); htmlWriter.RenderEndTag(); htmlWriter.RenderEndTag(); return stringWriter.ToString(); } } </code></pre> <p>All the <code>GenerateHTMLContent</code> methods are pretty much the same - they execute a query in my database, build an HTML table with the help of a HTMLTextWriter and return the table as a string. </p> <p>Can this code be improved with the use of multithreading or maybe async-await pattern? The code in question is where I append lines to the StringBuilder object.</p> <p>EDIT: I asked the question because I never worked with multithreading before, just wanted to know if it is possible. Besides, the program runs fast enough now.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USsventevit
    1. USsventevit
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POCan this code be improved with the use of multithreading?
      1. This table or related slice is empty.
      1. VTUpMod
    1. COIs the code that calls this method in a loop? ie I'm guessing that you are looping round a list of recipients and calling the above code to generate emails, is this correct?
      singulars
      1. POCan this code be improved with the use of multithreading?
      1. USKevin Holditch
    2. COFirst step of refactoring could be to use one Using() than 2. The other question is, do you know or think that those methods GenerateHTMLContent are time consuming operations? First have you done some benchmarks to know if they are really the showstoppers?
      singulars
      1. POCan this code be improved with the use of multithreading?
      1. USZenwalker
    3. COVery unlikely. Threads help to avoid freezing a user interface (async/await) or buy you more CPU cycles on a multicore CPU. A once-a-day program is unlikely to have a user interface. And this code needs more dbase servers and network bandwidth, not cpu cycles.
      singulars
      1. POCan this code be improved with the use of multithreading?
      1. USHans Passant
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload