StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POuser defined string::reserve()
primarykey
Id
7857602
data
AcceptedAnswerId
0
AnswerCount
1
ClosedDate
CommentCount
3
CommunityOwnedDate
CreationDate
2011-10-22T05:23:32.297
FavoriteCount
0
LastActivityDate
2014-12-08T00:01:30.023
LastEditDate
2014-12-08T00:01:30.023
LastEditorUserId
3991344
OwnerUserId
1008185
ParentId
0
PostTypeId
1
Score
0
ViewCount
1547
LastEditorDisplayName
text
Body
So we are writing a bunch of user defined functions that mimic the string class member functions. I am stuck on reserve. It looks like it should work but I am missing something. I have tried a couple of diffrent variations such as putting <code>this-></code> in front of the member varibles or <code>my string::</code> in front of them... my out put does not change but throught cout statment placed within the function I know it access the function. here is the code <pre><code>#include <cstdlib> #include <iostream> #include <string> #include "mystring.h" #define string mystring using namespace std; void check (string s, string name){ cout << "checking " << name << endl; cout << name << " contains " << s << endl; cout << name << " capacity() is " << s.capacity() << endl; cout << name << " length() is " << s.length() << endl; cout << name << " size() is " << s.size() << endl; cout << name << " max_size() is " << s.max_size() << endl << endl; } int main(int argc, char** argv) { cout<<"This is Lab 5"<<endl; string s1("Hello, World!");//step 2 string s1name("s1");//step 3 check(s1,s1name);//step 4 check(s1,s1name);//step 5 cout << "---Testing assignment operator---\n\n"; { string s2; s2=s1; string s2name("s2"); check(s2,s2name); if(s1==s2) cout<<"comparison true\n"; else cout<<"comparison false\n"; } check(s1,s1name); string s3("check assignment"); s3=s3;//checking to see if operator= is used when they are the same object. check(s3,"s3"); cout<<"Lab 5 ends"<<endl;//step6 // //clear check // s3.clear(); // check(s3,"s3"); // if(s1==s3) // cout<<"comparison true\n"; // else // cout<<"comparison false\n"; // reserve check // mystring::size_type res; // res=40; s3.reserve(40);//still working on reserve check(s3,"s3"); cout<<"in main buf size"<<s3.capacity()<<endl; s3.reserve(5); check(s3,"s3"); // char* test=s3.begin(); // cout<<&test<<endl; // cout<<&s3<<endl; //empty check // string s4; // // if (s4.empty()) // cout<<"Empty is true\n"; // else // cout<<"Empty is false\n"; return 0; } #ifndef MYSTRING_H #define MYSTRING_H #include <iostream> #include <math.h> #include <cstring> using namespace std; class mystring { public: // types with scope in this class typedef unsigned int size_type; typedef char * iterator; typedef const char * const_iterator; static const long int npos = 1073741824; // default constructor mystring();//good // other constructors mystring(const char *);//good // copy constructor mystring(const mystring& orig);// // destructor ~mystring();//// // iterators iterator begin();//good iterator end();//good //=== memory related === // change buffer size to n void reserve(size_type n); size_type size() const;////good returns len size_type length() const;////good returns len size_type capacity() const;////good returns buf_size size_type max_size() const;////good bool empty() const;////good //=== overloading operators === // assignment operator mystring& operator=(const mystring&);//// // mystring& operator=(const char *); // array notation char operator[](size_type pos) const; char& operator[](size_type pos); // append mystring& operator+=(const mystring& str); mystring& operator+=(const char * str); //=== methods that modifiy the string void clear();////good void push_back(char c); mystring& append(const mystring& str); mystring& append(const char * str); mystring& insert(size_type pos, const mystring& str); mystring& insert(size_type pos, const char * str); mystring& replace(size_type start, size_type span, const mystring& str); mystring& replace(size_type start, size_type span, const char * str); //=== conversion to c string const char * c_str() const;// private: // pointer to the memory location where string is stored as a c-style // string char * ptr_buffer; // the size of the memory in terms of bytes or characters capable of going into it currently size_type buf_size; // number of characters currently in the memory not including the // terminating null character size_type len; }; #include "mystring.h" // default constructor provided for lab 5 mystring::mystring() { ptr_buffer = new char[1]; *ptr_buffer = '\0'; buf_size = 1; len = 0; } // constructor from c-style string or "abc" provided for lab 5 mystring::mystring(const char * s) { len = strlen(s); buf_size = len + 1; ptr_buffer = new char[buf_size]; strcpy(ptr_buffer, s); } // copy constructor to be implemented in lab 5 mystring::mystring(const mystring& orig) { len=orig.length(); ptr_buffer=new char[len+1]; buf_size=len+1; for(int n=0 ;n<buf_size; n++ ) { ptr_buffer[n]=orig.ptr_buffer[n]; } ptr_buffer[buf_size]='\0'; } void mystring::reserve(size_type n) { cout<<"cccccc:"<<capacity()<<endl; if( n > capacity() ) { const char* temp = ptr_buffer; ptr_buffer = new char[n]; memcpy(ptr_buffer, temp, len+1); delete [] temp; buf_size=n; cout<<"bbbbbuf size"<<buf_size<<endl; } // char *temp; // // temp=new char[n]; // // int i=0; // // for(;i<=len;i++) // { // temp[i]=ptr_buffer[i]; // // } // buf_size=n; // // delete [] ptr_buffer; // // ptr_buffer=temp; // } mystring::iterator mystring::begin()//think is working correctly { iterator it=ptr_buffer; return it; } mystring::iterator mystring::end()//think is working correctly { iterator it=ptr_buffer+len; return it; } // one of the over loaded assignment operator to be implemented // assignment 3 (or for lab 5 if you have more time) mystring& mystring::operator=(const mystring& orig){ if(this!=&orig) // { // cout<<"this==&mystring if statment activated\n";//comment out after testing // break; // } { delete this->ptr_buffer; this->len=orig.len;//length(); this->ptr_buffer=new char((this->len)+1); this->buf_size=(this->buf_size)+1; cout<<"Using assignment operator="<<endl; for(int n=0;n<this->buf_size;n++) { this->ptr_buffer[n]=orig.ptr_buffer[n]; } this->ptr_buffer[buf_size]='\0'; return *this; } } // some simple methods provided for lab 5 mystring::size_type mystring::size() const { return len; } mystring::size_type mystring::length() const{ return len; } mystring::size_type mystring::capacity() const{ return buf_size; } mystring::size_type mystring::max_size() const{ return (int)pow(2,30) -4 ; } bool mystring::empty() const { if(len==0) return true; else return false; } // destructor to free space implemented for lab 5 mystring::~mystring() { delete [] ptr_buffer; } // provided for lab 5 so we may cout mystring ostream& operator<<(ostream& out, const mystring& str) { out << str.c_str(); return out; } // provided for lab 5 to support the implementation of << const char * mystring::c_str() const { return ptr_buffer; } char mystring::operator[](size_type pos) const { return *(ptr_buffer+pos); } void mystring::clear() { char *temp; temp=new char[1]; temp[0]='\0'; ptr_buffer=temp; buf_size=0; len=0; } void mystring::push_back(char c) { } bool operator==(const mystring& lhs, const mystring& rhs) { if(lhs.length()==rhs.length()) { for(int i=0; i<lhs.length();i++) { if(lhs[i]!=rhs[i]) return false; } return true; } return false; } </code></pre> So I put some cout statements in the <code>reserve()</code> function and in main. The reserve functions is changing the buffer size and capacity call is returning correctly but when we use the check function it is not showing that any change has occurred. I have put in revised code. Ok, everyone. Turns out on the check function declared before main that it makes a copy of the <code>mystring</code> object. The copy constructor was defined to make <code>buf_size= len + 1</code>. So I turned it into <code>buf_size=orig.buf_size</code>. The reserve function probably worked as stated and yes it needed an if statment to make sure we were not shrinking it, but i was not worried about that yet. I used daves example with a little added code. thanks all for your help. 
Tags
<c++>
Title
user defined string::reserve()
singulars
PostAcceptedAnswerId
1. This table or related slice is empty.
PostParentId
1. This table or related slice is empty.
PostTypePostTypeId
1. PTQuestion
UserLastEditorUserId
1. This table or related slice is empty.
UserOwnerUserId
1. USaaron burns
plurals
PostLinksPostIdRelatedPostId
1. This table or related slice is empty.
PostLinksRelatedPostIdPostId
1. This table or related slice is empty.
PostsAcceptedAnswerId
1. This table or related slice is empty.
PostsParentIdCreationDate
1. PO
 singulars
 PostTypePostTypeId
 PTAnswer
VotesPostIdCreationDate
1. This table or related slice is empty.
CommentsPostId
1. COWhat exactly is the problem? The way `reserve` is written it should not change the contents of the string. Btw: your `reserve` will fail if `n` < `len`. Edit: oh and the terminating "\0" is missing. That might be the problem.
 singulars
 PostPostId
 POuser defined string::reserve()
 UserUserId
 USvstm
2. COthe '\0' gets copied because i<=len. The reserve is supposed to fail if it is trying to shrink the size. i should be comparing to buffer_size though and not link.
 singulars
 PostPostId
 POuser defined string::reserve()
 UserUserId
 USaaron burns

Querying!

Guidance

A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.