Databases
StackOverflow2013
Postsdbo
POCould this code be cleaner?? It looks a right state?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POCould this code be cleaner?? It looks a right state?
    primarykey
    data
    text
    <p>I have this code to pull data from the database and insert the data into one of 4 columns,</p> <p>I have spent a whole day searching and just cant seem to find out how to do it..</p> <p>Ideally, I want to select all from database and then where the fetch array has a column id of 1 - echo that then the sama for the next column etc.. </p> <pre><code>&lt;?php echo '&lt;div class="column grid_3 clearfix" id="column0" &gt;'; echo '&amp;nbsp;'; $user_sites_0=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='0' ORDER BY sort_no"); if(!$user_sites_0) { echo 'No sites added, please &lt;a class="addsite" href="#"&gt;add one now&lt;/a&gt;'; } else { while($user_site_0=mysqli_fetch_array($user_sites_0)) { $id = stripslashes($user_site_0['id']); $site_name = stripslashes($user_site_0['site_name']); $site_address = stripslashes($user_site_0['site_address']); $site_desc = stripslashes($user_site_0['site_desc']); $site_category = stripslashes($user_site_0['site_category']); $getImage = 'http://immediatenet.com/t/s?Size=1024x768&amp;URL='.$site_address; echo '&lt;div class="dragbox" id="item'.$id.'"&gt;'; echo '&lt;h2 class="h2handle"&gt;'.$site_name.' &lt;span class="close"&gt;&lt;a href="#" id="'.$id.'" class="delete_button"&gt;&lt;img src="assets/img/closepanel.png"&gt;&lt;/a&gt;&lt;/span&gt;&lt;/h2&gt;'; echo '&lt;div class="dragbox-content" '; if($user_site_0['collapsed']==1) echo 'style="display:none;" '; echo '&gt;'; echo '&lt;p&gt;&lt;a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"&gt;&lt;img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/&gt;&lt;/a&gt;'; echo '&lt;p&gt;' . $site_category . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_address . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_desc . '&lt;/p&gt;'; echo' &lt;/div&gt; &lt;/div&gt;'; } } echo '&lt;/div&gt;'; ?&gt; &lt;?php echo '&lt;div class="column grid_3 clearfix" id="column1" &gt;'; echo '&amp;nbsp;'; $user_sites_1=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='1' ORDER BY sort_no"); if(!$user_sites_1) { echo ''; } else { while($user_site_1=mysqli_fetch_array($user_sites_1)) { $id = stripslashes($user_site_1['id']); $site_name = stripslashes($user_site_1['site_name']); $site_address = stripslashes($user_site_1['site_address']); $site_desc = stripslashes($user_site_1['site_desc']); $site_category = stripslashes($user_site_1['site_category']); $getImage = 'http://immediatenet.com/t/s?Size=1024x768&amp;URL='.$site_address; echo '&lt;div class="dragbox" id="item'.$id.'"&gt;'; echo '&lt;h2 class="h2handle"&gt;'.$site_name.' &lt;span class="close"&gt;&lt;a href="#" id="'.$id.'" class="delete_button"&gt;&lt;img src="assets/img/closepanel.png"&gt;&lt;/a&gt;&lt;/span&gt;&lt;/h2&gt;'; echo '&lt;div class="dragbox-content" '; if($user_site_1['collapsed']==1) echo 'style="display:none;" '; echo '&gt;'; echo '&lt;p&gt;&lt;a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"&gt;&lt;img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/&gt;&lt;/a&gt;'; echo '&lt;p&gt;' . $site_category . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_address . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_desc . '&lt;/p&gt;'; echo' &lt;/div&gt; &lt;/div&gt;'; } } echo '&lt;/div&gt;'; ?&gt; &lt;?php echo '&lt;div class="column grid_3 clearfix" id="column2"&gt;'; echo '&amp;nbsp;'; $user_sites_2=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='2' ORDER BY sort_no"); if(!$user_sites_2) { echo ''; } else { while($user_site_2=mysqli_fetch_array($user_sites_2)) { $id = stripslashes($user_site_2['id']); $site_name = stripslashes($user_site_2['site_name']); $site_address = stripslashes($user_site_2['site_address']); $site_desc = stripslashes($user_site_2['site_desc']); $site_category = stripslashes($user_site_2['site_category']); $getImage = 'http://immediatenet.com/t/s?Size=1024x768&amp;URL='.$site_address; echo '&lt;div class="dragbox" id="item'.$id.'"&gt;'; echo '&lt;h2 class="h2handle"&gt;'.$site_name.' &lt;span class="close"&gt;&lt;a href="#" id="'.$id.'" class="delete_button"&gt;&lt;img src="assets/img/closepanel.png"&gt;&lt;/a&gt;&lt;/span&gt;&lt;/h2&gt;'; echo '&lt;div class="dragbox-content" '; if($user_site_2['collapsed']==1) echo 'style="display:none;" '; echo '&gt;'; echo '&lt;p&gt;&lt;a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"&gt;&lt;img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/&gt;&lt;/a&gt;'; echo '&lt;p&gt;' . $site_category . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_address . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_desc . '&lt;/p&gt;'; echo' &lt;/div&gt; &lt;/div&gt;'; } } echo '&lt;/div&gt;'; ?&gt; &lt;?php echo '&lt;div class="column grid_3 clearfix" id="column3"&gt;'; echo '&amp;nbsp;'; $user_sites_3=mysqli_query($connection, "SELECT * FROM user_sites WHERE column_id='3' ORDER BY sort_no"); while($user_site_3=mysqli_fetch_array($user_sites_3)) { $id = stripslashes($user_site_3['id']); $site_name = stripslashes($user_site_3['site_name']); $site_address = stripslashes($user_site_3['site_address']); $site_desc = stripslashes($user_site_3['site_desc']); $site_category = stripslashes($user_site_3['site_category']); $getImage = 'http://immediatenet.com/t/s?Size=1024x768&amp;URL='.$site_address; echo '&lt;div class="dragbox" id="item'.$id.'"&gt;'; echo '&lt;h2 class="h2handle"&gt;'.$site_name.' &lt;span class="close"&gt;&lt;a href="#" id="'.$id.'" class="delete_button"&gt;&lt;img src="assets/img/closepanel.png"&gt;&lt;/a&gt;&lt;/span&gt;&lt;/h2&gt;'; echo '&lt;div class="dragbox-content" '; if($user_site_3['collapsed']==1) echo 'style="display:none;" '; echo '&gt;'; echo '&lt;p&gt;&lt;a class="sitelink" href="' . $site_address . '" title="'.$site_name.'"&gt;&lt;img src="'.$getImage.'" alt="'.$site_name.'" title="'.$site_name.'"/&gt;&lt;/a&gt;'; echo '&lt;p&gt;' . $site_category . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_address . '&lt;/p&gt;'; echo '&lt;p&gt;' . $site_desc . '&lt;/p&gt;'; echo' &lt;/div&gt; &lt;/div&gt;'; } echo '&lt;/div&gt;'; ?&gt; </code></pre> <p>The code looks a right state.. Could I do it better?</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USLightness Races in Orbit
    1. USDaniel Cheeseman
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POCould this code be cleaner?? It looks a right state?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POCould this code be cleaner?? It looks a right state?
      1. This table or related slice is empty.
      1. VTDownMod
    1. COAre you asking for code improvements? Then you should use http://codereview.stackexchange.com/.
      singulars
      1. POCould this code be cleaner?? It looks a right state?
      1. USvstm
    2. COA templating engine never hurt anybody... the efficiency of a million echos is called into question, as well as the maintainability of the code.
      singulars
      1. POCould this code be cleaner?? It looks a right state?
      1. This table or related slice is empty.
    3. COI was thinking about that but wanted to code it from the ground up to learn.. I cannot afford uni so using the 2 next best things.. Google and Stack Overflow :)
      singulars
      1. POCould this code be cleaner?? It looks a right state?
      1. USDaniel Cheeseman
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload