Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>You do not need to do a select to check existence and then choose either Update or Insert.</p> <p>You can use MySQL's <a href="http://dev.mysql.com/doc/refman/5.5/en/insert-on-duplicate.html" rel="nofollow"><code>ON DUPLICATE KEY UPDATE</code></a> Feature like this.</p> <pre><code>$query = 'INSERT INTO i_visited (userid,tid,dateline) VALUES (' . $user['id'] . ',' . intval($_GET['id']) . ', unix_timestamp(now())) ON DUPLICATE KEY UPDATE dateline = unix_timestamp(now())'; mysql_query($query); </code></pre> <p>This query will insert a new row if there is now <code>KEY</code> conflict, and in case a duplicate key is being inserted, it will instead execute the update part.</p> <p>And as you have a <code>KEY userid (userid,tid)</code> in your CREATE Statement the above query is equivalent to your <code>if...else</code> block.</p> <p>Try this and see if there are any gains</p> <p>You can also use <code>REPLACE INTO</code>, as there are only the specified 3 columns, like this</p> <pre><code>$query = 'REPLACE INTO i_visited (userid,tid,dateline) VALUES (' . $user['id'] . ',' . intval($_GET['id']) . ', unix_timestamp(now()))'; mysql_query($query); </code></pre> <p>But I would suggest looking at <code>ON DUPLICATE KEY UPDATE</code> as it is more flexible, as it can be used on a table with any number of columns, whereas <code>REPLACE INTO</code> would only work in some limited cases as other column values would also need to be filled in the <code>REPLACE INTO</code> statement unnecessarily </p>
    singulars
    1. This table or related slice is empty.
    1. POquery takes 70 ms to execute
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USdanishgoel
    1. USdanishgoel
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. COSame stupid thing, ~100 ms to process that query. Even using on duplicate key and that new table definition.
      singulars
      1. PO
      1. USEduard
    2. CO@edduvs try simply executing `mysql_query('UPDATE i_visited SET dateline = unix_timestamp(now()) WHERE userid = '.$user['id'].' AND tid = '.intval($_GET['id']));` for a known pre existing `id` and `tid`, see how long it takes. Might help in narrowing the cause. Even if you do it via AJAX, a large number of simultaneous users would slow down the server if an SQL query takes so long to execute. Something is definately wrong here. I myself try to optimize any query over 20ms in my application.
      singulars
      1. PO
      1. USdanishgoel
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload