Databases
StackOverflow2013
Postsdbo
POUsers logged into other people's accounts
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POUsers logged into other people's accounts
    primarykey
    data
    text
    <p>I have a script that gets Facebook user information (see below).</p> <p>The issue I've encountered during tests is that a user can end up getting logged in on someone else's account. This is obviously undesirable.</p> <p>This happens in the bit that says <code>if( $testuser != null )</code> where some code hooks into the login system of a web site bypassing the username+password phase and logs in a person according to their email address.</p> <p>My guess is that something similar is happening to a payment system I fixed a few months ago. In short, if two people were visiting the same page they could both end up benefiting from a transaction. This was solved by adding an id to the callback from the payment service. In the present case I'm not sure how I could implement that but I'd say an extra condition needs to be added before a user is logged in.</p> <p>What do you think is happening and what would be an appropriate/secure fix? </p> <pre><code>$token_url = "https://graph.facebook.com/oauth/access_token?" . "client_id=" . $app_id . "&amp;redirect_uri=" . urlencode($my_url) . "&amp;client_secret=" . $app_secret . "&amp;code=" . $code; $response = file_get_contents($token_url); $params = null; parse_str($response, $params); $graph_url = "https://graph.facebook.com/me?access_token=" . $params['access_token']; $testuser = json_decode(file_get_contents($graph_url)); if( $testuser != null ){ // Login code goes here $id = get_userid_by_email( $testuser-&gt;email ); // Use email as key as unique $user = new User($db); $user-&gt;signin_by_id( (int) $id ); $user-&gt;connect(); } </code></pre>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USJames P.
    1. USJames P.
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POUsers logged into other people's accounts
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POUsers logged into other people's accounts
      1. This table or related slice is empty.
      1. VTUpMod
    1. COThe part that reads from FB looks okay to me - I'd look into `get_userid_by_email()` and `signin_by_id()`, I guess. Does your app request the "get email" permission? What happens if `$testuser->email == ''`? What exactly are you passing in to those funcs? Is it what you think you are passing?
      singulars
      1. POUsers logged into other people's accounts
      1. USPiskvor
    2. CO`get_userid_by_email` queries the database for an id. If `$email` is empty it will return a -1 which in turn will cause a check to interrupt the login procedure. `signin_by_id` is the method that's actually used for logging in. It sets sessions and cookies and initializes the connected and id variables of the `User` instance. The application does have the get email permission: `&scope=email`.
      singulars
      1. POUsers logged into other people's accounts
      1. USJames P.
    3. COWell, if it happens seemingly "randomly", I'd start logging the execution of `get_userid_by_email()` and `signin_by_id()`. Write a log file of what the parameters they received in input were and what the output was. Hopefully that will get you a reproducible problem. There's also the chance there's something wrong with your generation of `$code` and it's being polluted by other sessions. I trust ID and email are UNIQUE in database?
      singulars
      1. POUsers logged into other people's accounts
      1. USNaltharial
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload