Databases
StackOverflow2013
Postsdbo
POClarification - Using Update TSQL
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POClarification - Using Update TSQL
    primarykey
    data
    text
    <p>I have a stored procedure that looks like the following, below. What happens is that it fails on me when I run. I have narrowed it down where when I am attempting to update the the AGENT STATE syntax in e.g. <strong>WHEN PropertyDefinitionID = @passStatePropertyDefID THEN @passState -- Agent State</strong></p> <pre><code>ALTER procedure [dbo].[usp_UpdateProfile] @passCompanyName varchar(100), @passFName varchar(50), @passLName varchar(50), @passEmail varchar(50), @passStreet varchar(50), @passCity varchar(50), @passState int, @passZip varchar(10), @passPhone varchar(15), @passUserID int As Begin Declare @passCompanyNamePropertyDefID int Declare @passFNamePropertyDefID int Declare @passLNamePropertyDefID int Declare @passEmailPropertyDefID int Declare @passStreetPropertyDefID int Declare @passCityPropertyDefID int Declare @passStatePropertyDefID int Declare @passPostalPropertyDefID int Declare @passPhonePropertyDefID int Declare @passACURefID int Set @passCompanyNamePropertyDefID = 62 -- Local PropertyDefinitionID from server : Agent Company Name Set @passFNamePropertyDefID = 61 -- Local PropertyDefinitionID from server : Agent First Name Set @passLNamePropertyDefID = 63 -- Local PropertyDefinitionID from server : Agent Last Name Set @passEmailPropertyDefID = 64 -- Local PropertyDefinitionID from server : Agent Email Set @passStreetPropertyDefID = 65 -- Local PropertyDefinitionID from server : Agent Street Set @passCityPropertyDefID = 66 -- Local PropertyDefinitionID from server : Agent City Set @passStatePropertyDefID = 72 -- Local PropertyDefinitionID from server : Agent State Set @passPostalPropertyDefID = 67 -- Local PropertyDefinitionID from server : Agent State Set @passPhonePropertyDefID = 68 -- Local PropertyDefinitionID from server: Agent Telephone If(Exists(Select UserID From AgentCompanyUser Where UserID = @passUserID)) Begin -- Modify First Name and Last Name in AgentCompanyUser table -- Update AgentCompanyUser Set Agent_FirstName = @passFName, Agent_LastName = @passLName Where UserID = @passUserID End -- Modify Email Address in dnn_Users table -- Update dnn_Users Set Email = @passEmail Where UserID = @passUserID -- Retreive ACU_RefID from AgentCompanyUser table -- Set @passACURefID = (Select ACU_RefID from AgentCompanyUser Where UserID = @passUserID) -- UPDATE COMPANY WITH AGENT - AGENT PROFILE SECTION Update dnn_UserProfile Set PropertyValue = CASE WHEN PropertyDefinitionID = @passFNamePropertyDefID THEN @passFName -- Agent First Name WHEN PropertyDefinitionID = @passLNamePropertyDefID THEN @passLName -- Agent Last Name WHEN PropertyDefinitionID = @passEmailPropertyDefID THEN @passEmail -- Agent Email WHEN PropertyDefinitionID = @passStreetPropertyDefID THEN @passStreet -- Agent Street WHEN PropertyDefinitionID = @passCityPropertyDefID THEN @passCity -- Agent City WHEN PropertyDefinitionID = @passStatePropertyDefID THEN @passState -- Agent State WHEN PropertyDefinitionID = @passPostalPropertyDefID THEN @passZip -- Agent Postal WHEN PropertyDefinitionID = @passPhonePropertyDefID THEN @passPhone -- Agent Phone END WHERE PropertyDefinitionID IN (@passFNamePropertyDefID, @passLNamePropertyDefID, @passEmailPropertyDefID, @passStreetPropertyDefID, @passCityPropertyDefID, @passStatePropertyDefID, @passPostalPropertyDefID, @passPhonePropertyDefID) AND UserID IN ( SELECT B.UserID FROM CompanyAuthorizeAgent AS B INNER JOIN AgentCompanyUser AS A ON A.ACU_RefID = B.FK_acu_RefID WHERE A.ACU_RefID = @passACURefID ) End </code></pre> <p>But if modify the code to separate the code which is causing me problems. It works. The modify code below, you'll see I created another update:</p> <pre><code>ALTER procedure [dbo].[usp_UpdateProfile] @passCompanyName varchar(100), @passFName varchar(50), @passLName varchar(50), @passEmail varchar(50), @passStreet varchar(50), @passCity varchar(50), @passState int, @passZip varchar(10), @passPhone varchar(15), @passUserID int As Begin Declare @passCompanyNamePropertyDefID int Declare @passFNamePropertyDefID int Declare @passLNamePropertyDefID int Declare @passEmailPropertyDefID int Declare @passStreetPropertyDefID int Declare @passCityPropertyDefID int Declare @passStatePropertyDefID int Declare @passPostalPropertyDefID int Declare @passPhonePropertyDefID int Declare @passACURefID int Set @passCompanyNamePropertyDefID = 62 -- Local PropertyDefinitionID from server : Agent Company Name Set @passFNamePropertyDefID = 61 -- Local PropertyDefinitionID from server : Agent First Name Set @passLNamePropertyDefID = 63 -- Local PropertyDefinitionID from server : Agent Last Name Set @passEmailPropertyDefID = 64 -- Local PropertyDefinitionID from server : Agent Email Set @passStreetPropertyDefID = 65 -- Local PropertyDefinitionID from server : Agent Street Set @passCityPropertyDefID = 66 -- Local PropertyDefinitionID from server : Agent City Set @passStatePropertyDefID = 72 -- Local PropertyDefinitionID from server : Agent State Set @passPostalPropertyDefID = 67 -- Local PropertyDefinitionID from server : Agent State Set @passPhonePropertyDefID = 68 -- Local PropertyDefinitionID from server: Agent Telephone If(Exists(Select UserID From AgentCompanyUser Where UserID = @passUserID)) Begin -- Modify First Name and Last Name in AgentCompanyUser table -- Update AgentCompanyUser Set Agent_FirstName = @passFName, Agent_LastName = @passLName Where UserID = @passUserID End -- Modify Email Address in dnn_Users table -- Update dnn_Users Set Email = @passEmail Where UserID = @passUserID -- Retreive ACU_RefID from AgentCompanyUser table -- Set @passACURefID = (Select ACU_RefID from AgentCompanyUser Where UserID = @passUserID) -- UPDATE COMPANY WITH AGENT - AGENT PROFILE SECTION Update dnn_UserProfile Set PropertyValue = CASE WHEN PropertyDefinitionID = @passFNamePropertyDefID THEN @passFName -- Agent First Name WHEN PropertyDefinitionID = @passLNamePropertyDefID THEN @passLName -- Agent Last Name WHEN PropertyDefinitionID = @passEmailPropertyDefID THEN @passEmail -- Agent Email WHEN PropertyDefinitionID = @passStreetPropertyDefID THEN @passStreet -- Agent Street WHEN PropertyDefinitionID = @passCityPropertyDefID THEN @passCity -- Agent City WHEN PropertyDefinitionID = @passPostalPropertyDefID THEN @passZip -- Agent Postal WHEN PropertyDefinitionID = @passPhonePropertyDefID THEN @passPhone -- Agent Phone END WHERE PropertyDefinitionID IN (@passFNamePropertyDefID, @passLNamePropertyDefID, @passEmailPropertyDefID, @passStreetPropertyDefID, @passCityPropertyDefID, @passPostalPropertyDefID, @passPhonePropertyDefID) AND UserID IN ( SELECT B.UserID FROM CompanyAuthorizeAgent AS B INNER JOIN AgentCompanyUser AS A ON A.ACU_RefID = B.FK_acu_RefID WHERE A.ACU_RefID = @passACURefID ) -- UPDATE COMPANY WITH AGENT - AGENT PROFILE SECTION (Add 2nd Update) Update dnn_UserProfile Set PropertyValue = CASE WHEN PropertyDefinitionID = @passStatePropertyDefID THEN @passState-- Agent State END WHERE PropertyDefinitionID IN (@passStatePropertyDefID) AND UserID IN ( SELECT B.UserID FROM CompanyAuthorizeAgent AS B INNER JOIN AgentCompanyUser AS A ON A.ACU_RefID = B.FK_acu_RefID WHERE A.ACU_RefID = @passACURefID ) End </code></pre> <p>My question is why do I have to create another update instead of using my original code to make this work?</p> <p>Thanks in advance.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USCharles Bernardes
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POClarification - Using Update TSQL
      1. This table or related slice is empty.
      1. VTUpMod
    1. CO"it fails on me" - fails how?
      singulars
      1. POClarification - Using Update TSQL
      1. USMitch Wheat
    2. COIn the original UPDATE syntax, all of the parameters passed does not update respectively. But for some reason if I create two updates, all records get updated. The difference of parameters passed to update are VARCHAR but the one that seems to cause a conflict in the Update is an INT
      singulars
      1. POClarification - Using Update TSQL
      1. USCharles Bernardes
    3. CODid you make sure you don't have trailing spaces on your varchar passed in parameters? add ltrim(rtrim()) to all the parameter checks (and the table field, possibly) in your case statement and see if it works...
      singulars
      1. POClarification - Using Update TSQL
      1. USM.R.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload