Databases
StackOverflow2013
Postsdbo
POImprove this ugly piece of code
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POImprove this ugly piece of code
    primarykey
    data
    text
    <p>I'm writing a QR code generator in VB.net</p> <p>First I check what value (of the QR code version) was chosen by the user.</p> <p>Each version has fixed count of bits per mode (0001, 0010, 0100, 1000).</p> <p>Basically what I got now is the following:</p> <pre><code>Private Function get_number_of_bits() As Integer Dim bits As Integer If listVersion.Value &lt; 10 Then If get_binary_mode(listMode.SelectedItem) = "0001" Then bits = 10 End If If get_binary_mode(listMode.SelectedItem) = "0010" Then bits = 9 End If If get_binary_mode(listMode.SelectedItem) = "0100" Or _ get_binary_mode(listMode.SelectedItem) = "1000" Then bits = 8 End If ElseIf listVersion.Value &lt; 27 Then If get_binary_mode(listMode.SelectedItem) = "0001" Then bits = 12 End If If get_binary_mode(listMode.SelectedItem) = "0010" Then bits = 11 End If If get_binary_mode(listMode.SelectedItem) = "0100" Then bits = 16 End If If get_binary_mode(listMode.SelectedItem) = "1000" Then bits = 10 End If Else If get_binary_mode(listMode.SelectedItem) = "0001" Then bits = 14 End If If get_binary_mode(listMode.SelectedItem) = "0010" Then bits = 13 End If If get_binary_mode(listMode.SelectedItem) = "0100" Then bits = 16 End If If get_binary_mode(listMode.SelectedItem) = "1000" Then bits = 12 End If End If Return bits End Function </code></pre> <p>Which works but of course it is an ugly piece of ..... code :)</p> <p>What would be a better way to write this?</p> <p><strong>EDIT</strong></p> <p>As requested.</p> <p>listMode is a combobox which is filled with:</p> <pre><code>Private Function get_encoding_modes() As Dictionary(Of String, String) Dim modes As New Dictionary(Of String, String) modes.Add("0000", "&lt;Auto select&gt;") modes.Add("0001", "Numeric (max. 7089 chars)") modes.Add("0010", "Alphanumeric (max. 4296 chars)") modes.Add("0100", "Binary [8 bits] (max. 2953 chars)") modes.Add("1000", "Kanji/Kana (max. 1817 chars)") Return modes End Function </code></pre> <p>Code for get_binarymode</p> <pre><code>Private Function get_binary_mode(ByVal mode As String) As String Dim modes As New Dictionary(Of String, String) modes = get_encoding_modes() Dim result As String = "" Dim pair As KeyValuePair(Of String, String) For Each pair In modes If pair.Value = mode Then result = pair.Key End If Next Return result End Function </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USshelleybutterfly
    1. USPeeHaa
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POImprove this ugly piece of code
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POImprove this ugly piece of code
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POImprove this ugly piece of code
      1. USshelleybutterfly
      1. VTFavorite
    1. COSelect Case would be a start.
      singulars
      1. POImprove this ugly piece of code
      1. USDavid
    2. COWhat data structure is listMode? Can you show the code for get_binary_mode?
      singulars
      1. POImprove this ugly piece of code
      1. USbriddums
    3. COFirst, there is a logic error in the code. The selected item can not be "0100" and "1000" at the same time. You want to use the `Or` operator instead.
      singulars
      1. POImprove this ugly piece of code
      1. USGuffa
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload