Databases
StackOverflow2013
Postsdbo
POIs there any other method to handle many 'malloc' failures?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIs there any other method to handle many 'malloc' failures?
    primarykey
    data
    text
    <p>I'm trying to write a function in C to solve a math problem. In that function, there are several steps, and each step needs to allocate some memory with the size depending on the calculation results in previous steps (so I can't allocate them all at the beginning of the function). The pseudo code looks like:</p> <pre><code>int func(){ int *p1, *p2, *p3, *p4; ... p1 = malloc(...); if(!p1){ return -1; //fail in step 1 } ... p2 = malloc(...); if(!p2){ free(p1); return -2; //fail in step 2 } ... p3 = malloc(...); if(!p3){ free(p1); free(p2); return -3; //fail in step 3 } ... p4 = malloc(...); if(!p4){ free(p1); free(p2); free(p3); /* I have to write too many "free"s here! */ return -4; //fail in step 4 } ... free(p1); free(p2); free(p3); free(p4); return 0; //normal exit } </code></pre> <p>The above way to handle malloc failures is so ugly. Thus, I do it in the following way:</p> <pre><code>int func(){ int *p1=NULL, *p2=NULL, *p3=NULL, *p4=NULL; int retCode=0; ... /* other "malloc"s and "if" blocks here */ ... p3 = malloc(...); if(!p3){ retCode = -3; //fail in step 3 goto FREE_ALL_EXIT; } ... p4 = malloc(...); if(!p4){ retCode = -4; //fail in step 4 goto FREE_ALL_EXIT; } ... FREE_ALL_EXIT: free(p1); free(p2); free(p3); free(p4); return retCode; //normal exit } </code></pre> <p>Although I believe it's more brief, clear, and beautiful now, my team mate is still strongly against the use of 'goto'. And he suggested the following method:</p> <pre><code>int func(){ int *p1=NULL, *p2=NULL, *p3=NULL, *p4=NULL; int retCode=0; ... do{ /* other "malloc"s and "if" blocks here */ p4 = malloc(...); if(!p4){ retCode = -4; //fail in step 4 break; } ... }while(0); free(p1); free(p2); free(p3); free(p4); return retCode; //normal exit } </code></pre> <p>Hmmm, it seems a way to avoid the use of 'goto', but this way increases indents, which makes the code ugly.</p> <p><strong>So my question is,</strong> is there any other method to handle many 'malloc' failures in a good code style? Thank you all.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USStan
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POIs there any other method to handle many 'malloc' failures?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POIs there any other method to handle many 'malloc' failures?
      1. USJosejulio
      1. VTFavorite
    3. VO
      singulars
      1. POIs there any other method to handle many 'malloc' failures?
      1. USStan
      1. VTFavorite
    1. CO"but this way increases indents, which makes the code ugly." - 2 points: excessive indents are bad; you don't have excessive indents. (2) don't use goto when you can write the code perfectly clearly without them.
      singulars
      1. POIs there any other method to handle many 'malloc' failures?
      1. USMitch Wheat
    2. COYour team mate is wrong.
      singulars
      1. POIs there any other method to handle many 'malloc' failures?
      1. USHans Passant
    3. COwell, there are still some indents in the `do{}while(0)` block that I didn't show :)
      singulars
      1. POIs there any other method to handle many 'malloc' failures?
      1. USStan
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload