Databases
StackOverflow2013
Postsdbo
POUnitTesting a threaded class, avoiding Thread.Sleep() in test?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POUnitTesting a threaded class, avoiding Thread.Sleep() in test?
    primarykey
    data
    text
    <p>I'm trying to figure out the best way to unit test this class:</p> <pre><code>public class FileGroupGarbageCollector { private Task _task; private readonly AutoResetEvent _event = new AutoResetEvent(false); public void Start() { _task = Task.Factory.StartNew(StartCollecting); } public void Stop() { _event.Set(); } private void StartCollecting() { do { Process(); } while (!_event.WaitOne(60000, false)); } private void Process() { /* do some work to the database and file system */ } } </code></pre> <p>It's not supposed to be the most well formed class, just trying to figure out something!</p> <p>I then have a unit test where I want to start and then stop the service, asserting the the private 'Processs' method did something to the database or filesystem.</p> <p>My unit test is as follows (nunit):</p> <pre><code> [Test] public void TestStart() { var fg = new FileGroupGarbageCollector(30000); fg.Start(); Thread.Sleep(5000); // i hate this! fg.Stop(); // assert it did what i wanted it to do! } </code></pre> <p>Is there any way or any nice pattern that can be used here so I can avoid Thread.Sleep()? I hate the idea of sleeping in a unit test (let alone in production code), but I refuse to just test private functionality! I want to test the public interface of this class.</p> <p>Any answers are greatly appreciated :)</p> <p><strong>UPDATE AFTER ANSWER</strong></p> <p>I went with the IoC way of things and it works really nicely :)</p> <blockquote> <p>public interface IEventFactory { IEvent Create(); }</p> </blockquote> <pre><code>public interface IEvent { bool WaitOne(int timeout); void Set(); } </code></pre> <p>Then my mock objects (using Moq):</p> <pre><code> var mockEvent = new Mock&lt;IEvent&gt;(); var mockEventFactory = new Mock&lt;IEventFactory&gt;(); mockEvent.Setup(x =&gt; x.WaitOne(It.IsAny&lt;int&gt;())).Returns(true); mockEvent.Setup(x =&gt; x.Set()); mockEventFactory.Setup(x =&gt; x.Create()).Returns(mockEvent.Object); </code></pre> <p>So instantly a call to IEvent.WaitOne() returns true and exits, so no need for the Thread.Sleep()!</p> <p>:)</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USadamwtiko
    1. USadamwtiko
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POUnitTesting a threaded class, avoiding Thread.Sleep() in test?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POUnitTesting a threaded class, avoiding Thread.Sleep() in test?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POUnitTesting a threaded class, avoiding Thread.Sleep() in test?
      1. This table or related slice is empty.
      1. VTUpMod
    1. COWhy do you need the Thread.Sleep() in there? What is your test trying to accomplish?
      singulars
      1. POUnitTesting a threaded class, avoiding Thread.Sleep() in test?
      1. UScsano
    2. COyou did a great job, Adam! Bravo :) exactly what I've tried to explain!
      singulars
      1. POUnitTesting a threaded class, avoiding Thread.Sleep() in test?
      1. USAlexander Beletsky
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload