Databases
StackOverflow2013
Postsdbo
POParameters not getting saved in Rails 3 app
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POParameters not getting saved in Rails 3 app
    primarykey
    data
    text
    <p>I am a Rails 3 beginner working on an application that allows the user to enter monetary values. I am using a jQuery plugin (<a href="http://github.com/plentz/jquery-maskmoney" rel="nofollow noreferrer">http://github.com/plentz/jquery-maskmoney</a>) to display decimal values as monetary values on the edit page. All the decimal attributes are manipulated as currency when editing. When saving the, purchase_price and capital_reserves are saved correctly. The Property before_save function is called and the currency values ($123.45) get converted to decimal values (123.45).</p> <p>The problem is that the associated rent values are never saved if I just edit the rent prices. I can see the correct values being sent in the parameters but the before_save code in the Rent model is never triggered. If I edit the apartment number value and a rent price, then the rent price is saved correctly. Also, after that I can just edit the price for the apartment number I previously modified. However, any other rent price will not be updated.</p> <p>I am using MySQL and Rails 3.0.9</p> <p>Steps to reproduce: Non-Issue</p> <ol> <li>Edit a property</li> <li>Modify the property's purchase price and/or capital reserves value</li> <li>Click Update</li> <li>These values are converted from currency values ($1,234.56) to decimal (1234.56) by the before_save code in Property</li> </ol> <p>Issue</p> <ol> <li>Edit a property</li> <li>Modify the property's rent current price and/or market price values</li> <li>Click Update</li> <li>These values do not get saved. The before_save code is not called in the Rent model.</li> </ol> <p>Issue</p> <ol> <li>Edit a property</li> <li>Modify the property's purchase price and/or capital reserves value, but also edit the apartment number</li> <li>Click Update</li> <li>These values are saved correctly.</li> <li>Now you can edit the price values for the row previously saved and those prices are saved. Why?</li> </ol> <p>I made a small project to showcase this if anyone is interested (<a href="https://github.com/michaelklem/Money-Test" rel="nofollow noreferrer">https://github.com/michaelklem/Money-Test</a>).</p> <p>Here are my data models.</p> <p><strong>Property</strong> class</p> <pre><code>class Property &lt; ActiveRecord::Base before_save :handle_before_save has_many :rents, :dependent =&gt; :destroy accepts_nested_attributes_for :rents, :allow_destroy =&gt; true def handle_before_save if new_record? generate_default_rent_data end remove_currency_formatting end def generate_default_rent_data 10.times do |i| self.rents.build(:apartment_number =&gt; i+1) end end def remove_currency_formatting if self.capital_reserves.to_s != self.capital_reserves_before_type_cast.to_s self.capital_reserves = Property.remove_currency_format(self.capital_reserves_before_type_cast) end if self.purchase_price.to_s != self.purchase_price_before_type_cast.to_s self.purchase_price = Property.remove_currency_format(self.purchase_price_before_type_cast) end end # # handles removing all characters from currency objects # except for 0-9 and . # def self.remove_currency_format(currency_attribute) currency_attribute.gsub(/[^0-9.]/, "") end end </code></pre> <p><strong>Rent</strong> class:</p> <pre><code>class Rent &lt; ActiveRecord::Base belongs_to :property before_save :handle_before_save def handle_before_save remove_currency_formatting end def remove_currency_formatting if self.current_price.to_s != self.current_price_before_type_cast.to_s self.current_price = Property.remove_currency_format(self.current_price_before_type_cast) end if self.market_price.to_s != self.market_price_before_type_cast.to_s self.market_price = Property.remove_currency_format(self.market_price_before_type_cast) end end end </code></pre> <p>Not sure if I am seeing a bug or missing something obvious. Thanks for looking into this.</p> <p><strong>Update</strong></p> <p>After I posted this I found this SO question <a href="https://stackoverflow.com/questions/3596105/stripping-the-first-character-of-a-string">Stripping the first character of a string</a> that helped me figure this out. It still seems to me that my original issue is a bug.</p> <p>I was able to simplify my code to the following and everything works.</p> <pre><code>class Property &lt; ActiveRecord::Base before_save :handle_before_save has_many :rents, :dependent =&gt; :destroy accepts_nested_attributes_for :rents, :allow_destroy =&gt; true def handle_before_save if new_record? generate_default_rent_data end end def purchase_price=(data) if data.is_a?(String) data = Property.remove_currency_format(data) write_attribute(:purchase_price, data) end end def capital_reserves=(data) if data.is_a?(String) data = Property.remove_currency_format(data) write_attribute(:capital_reserves, data) end end # # generate some default data # def generate_default_rent_data 10.times do |i| self.rents.build(:apartment_number =&gt; i+1) # provide a default value for apartment numbers end end def self.remove_currency_formatting(data) if data.is_a?(String) data = Property.remove_currency_format(data) end return data end # # handles removing all characters from currency objects # except for 0-9 and . # def self.remove_currency_format(currency_attribute) currency_attribute.gsub(/[^0-9.]/, "") end def purchase_price=(data) _write_attribute(:purchase_price, data) end def capital_reserves=(data) _write_attribute(:capital_reserves, data) end private def _write_attribute(attribute, data) write_attribute(attribute, Property.remove_currency_formatting(data)) end end class Rent &lt; ActiveRecord::Base belongs_to :property def current_price=(data) _write_attribute(:current_price, data) end def market_price=(data) _write_attribute(:market_price, data) end private def _write_attribute(attribute, data) write_attribute(attribute, Property.remove_currency_formatting(data)) end end </code></pre>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USCommunity
    1. UStollbooth
    plurals
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POParameters not getting saved in Rails 3 app
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POParameters not getting saved in Rails 3 app
      1. USZabba
      1. VTFavorite
    3. VO
      singulars
      1. POParameters not getting saved in Rails 3 app
      1. This table or related slice is empty.
      1. VTUpMod
    1. COFirst off, thanks for the sample app. If you want to go a step further, have it use sqlite3 (instead of MySQL) and have some seed data already created. Your repro steps assume we know something about your app so if you could make those more specific, it would help. I say all that b/c I was able to repro using your app and I'm stumped as well, and I'm hoping your repro app will help someone figure it out.
      singulars
      1. POParameters not getting saved in Rails 3 app
      1. USpcg79
    2. COThanks for the tips. I updated my question with my solution as well.
      singulars
      1. POParameters not getting saved in Rails 3 app
      1. UStollbooth
    3. COLook at that. Glad you got it figured out!
      singulars
      1. POParameters not getting saved in Rails 3 app
      1. USpcg79
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload