Databases
StackOverflow2013
Postsdbo
POMake this code more Object-Oriented?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POMake this code more Object-Oriented?
    primarykey
    data
    text
    <p>I've been told by my friend that my code isn't very OO. How would I make this more OO and reusable? I tried making a class called level, that printed the images in level, but noting printed, so that didn't work.</p> <p>(code dump coming, I'm sorry)</p> <pre><code>public class Main extends Applet implements Runnable, KeyListener, java.awt.event.MouseListener { double x_pos = 300; double y_pos = 200; int radius = 20; int appletsize_x = 640; int appletsize_y = 440; double speed = 3; float speedModifier = 1f; Image grass; Image hero; Image hero45; Image hero90; Image hero135; Image hero180; Image hero225; Image hero270; Image hero315; Image sprite; Image tree; Image path; private boolean leftPressed; private boolean rightPressed; private boolean downPressed; private boolean upPressed; private Image dbImage; private Graphics dbg; public void init() { Dimension dim = getMaximumSize(); this.setSize(appletsize_x, appletsize_y); MediaTracker mt = new MediaTracker(this); tree = getImage(getCodeBase(), "tree_64.png"); grass = getImage(getCodeBase(), "grassTile.png"); path = getImage(getCodeBase(), "path.png"); hero = getImage(getCodeBase(), "hero.png"); hero45 = getImage(getCodeBase(), "hero45.png"); hero90 = getImage(getCodeBase(), "hero90.png"); hero135 = getImage(getCodeBase(), "hero135.png"); hero180 = getImage(getCodeBase(), "hero180.png"); hero225 = getImage(getCodeBase(), "hero225.png"); hero270 = getImage(getCodeBase(), "hero270.png"); hero315 = getImage(getCodeBase(), "hero315.png"); sprite = getImage(getCodeBase(), "hero.png"); mt.addImage(hero, 0); mt.addImage(path, 0); mt.addImage(tree, 0); mt.addImage(grass, 0); mt.addImage(hero45, 0); mt.addImage(hero90, 0); mt.addImage(hero135, 0); mt.addImage(hero180, 0); mt.addImage(hero225, 0); mt.addImage(hero270, 0); try { mt.waitForID(0); } catch (InterruptedException ie) { } } public void start() { this.addKeyListener(this); this.addMouseListener(this); Thread th = new Thread(this); th.start(); } public void stop() { } public void destroy() { } public void run() { // lower ThreadPriority this.requestFocusInWindow(); Thread.currentThread().setPriority(Thread.MIN_PRIORITY); while (true) { if (downPressed &amp;&amp; leftPressed) { double y_decr, x_incr; y_decr = Math.sqrt(Math.pow(speed, 2)) / 1.5; x_incr = Math.sqrt(Math.pow(speed, 2)) / 1.5; y_pos += y_decr; x_pos -= x_incr; } else if (downPressed &amp;&amp; rightPressed) { y_pos += Math.sqrt(Math.pow(speed, 2)) / 1.5; x_pos += Math.sqrt(Math.pow(speed, 2)) / 1.5; } else if (upPressed &amp;&amp; rightPressed) { y_pos -= Math.sqrt(Math.pow(speed, 2)) / 1.5; x_pos += Math.sqrt(Math.pow(speed, 2)) / 1.5; } else if (upPressed &amp;&amp; leftPressed) { y_pos -= Math.sqrt(Math.pow(speed, 2)) / 1.5; x_pos -= Math.sqrt(Math.pow(speed, 2)) / 1.5; } else { // Hitting (right) if (x_pos &gt; this.getSize().width - radius) { // x_speed = -x_speed; } if (leftPressed == true) { x_pos -= speed * speedModifier; } if (rightPressed == true) { x_pos += speed * speedModifier; } if (upPressed == true) { y_pos -= speed * speedModifier; } if (downPressed == true) { y_pos += speed * speedModifier; } } // Hitting right if (x_pos &gt; this.getSize().width - 32) { x_pos = this.getSize().width - 32; } // Hitting left if (x_pos &lt; 0) { x_pos = 0; } // } // Hitting top if (y_pos &lt; 0) { y_pos = 0; } // Hitting bottom if (y_pos &gt; this.getSize().height - 32) { y_pos = this.getSize().height - 32; } repaint(); try { // Stop thread for 1 milliseconds Thread.sleep(20); } catch (InterruptedException ex) { // do nothing } // set ThreadPriority to maximum value Thread.currentThread().setPriority(Thread.MIN_PRIORITY); } } public void paint(Graphics g) { int layout = 0; int coll = 0; while (coll &lt;= 440) { drawRows(layout, grass, g, coll); coll = coll + 32; } drawCollums(0, path, g, 180); g.drawImage(tree, 50, 40, this); g.drawImage(tree, 300, 20, this); g.drawImage(tree, 500, 300, this); int x_posI = (int) x_pos; int y_posI = (int) y_pos; if (downPressed &amp;&amp; leftPressed) { this.sprite = hero225; } else if (downPressed &amp;&amp; rightPressed) { this.sprite = hero135; } else if (upPressed &amp;&amp; rightPressed) { this.sprite = hero45; } else if (upPressed &amp;&amp; leftPressed) { this.sprite = hero315; } else if (leftPressed == true) { this.sprite = hero270; } else if (rightPressed == true) { this.sprite = hero90; } else if (upPressed == true) { this.sprite = hero; } else if (downPressed == true) { this.sprite = hero180; } // this.sprite will contain value set on last "movement" g.drawImage(this.sprite, x_posI, y_posI, this); } public void update(Graphics g) { if (dbImage == null) { dbImage = createImage(this.getSize().width, this.getSize().height); dbg = dbImage.getGraphics(); } dbg.setColor(getBackground()); dbg.fillRect(0, 0, this.getSize().width, this.getSize().height); dbg.setColor(getForeground()); paint(dbg); g.drawImage(dbImage, 0, 0, this); } @Override public void keyPressed(KeyEvent e) { if (e.getKeyCode() == KeyEvent.VK_LEFT) { leftPressed = true; } if (e.getKeyCode() == KeyEvent.VK_RIGHT) { rightPressed = true; } if (e.getKeyCode() == KeyEvent.VK_UP) { upPressed = true; } if (e.getKeyCode() == KeyEvent.VK_DOWN) { downPressed = true; } } @Override public void keyReleased(KeyEvent e) { if (e.getKeyCode() == KeyEvent.VK_LEFT) { leftPressed = false; } if (e.getKeyCode() == KeyEvent.VK_RIGHT) { rightPressed = false; } if (e.getKeyCode() == KeyEvent.VK_UP) { upPressed = false; } if (e.getKeyCode() == KeyEvent.VK_DOWN) { downPressed = false; } } @Override public void keyTyped(KeyEvent e) { } @Override public void mouseClicked(MouseEvent e) { System.out.println("HIT!"); // TODO Auto-generated method stub } @Override public void mouseEntered(MouseEvent e) { // TODO Auto-generated method stub } @Override public void mouseExited(MouseEvent e) { // TODO Auto-generated method stub } @Override public void mousePressed(MouseEvent e) { // TODO Auto-generated method stub } @Override public void mouseReleased(MouseEvent e) { // TODO Auto-generated method stub } public void drawRows(int x, Image image, Graphics g, int coll) { while (x &lt;= appletsize_x) { g.drawImage(image, x, coll, this); x += 32; } } public void drawCollums(int y, Image image, Graphics g, int coll) { while (y &lt;= appletsize_x) { g.drawImage(image, coll, y, this); y += 32; } } } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USmaerics
    1. USDerek
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POMake this code more Object-Oriented?
      1. This table or related slice is empty.
      1. VTDownMod
    2. VO
      singulars
      1. POMake this code more Object-Oriented?
      1. This table or related slice is empty.
      1. VTDownMod
    3. VO
      singulars
      1. POMake this code more Object-Oriented?
      1. This table or related slice is empty.
      1. VTDownMod
    1. COYou could start by reading about [God objects](http://en.wikipedia.org/wiki/God_object), and try avoid writing them in the first place. This is in reference to `(code dump coming, I'm sorry)`
      singulars
      1. POMake this code more Object-Oriented?
      1. USVineet Reynolds
    2. COI don't think that anyone will refactor your code, and you didn't even say what it does. Get a book about Object Oriented Programming, try to learn as more as you can, starting from simple examples. In this code there is actually no / very little OOP.
      singulars
      1. POMake this code more Object-Oriented?
      1. USDenis Biondic
    3. COTo expand further on my previous comment. If you had a separate class for every distinct set of responsibilities, then your code would have reflected that, and so would the question. I didn't read the entire class, but it was quite obvious that separation of concerns would have helped in reading it.
      singulars
      1. POMake this code more Object-Oriented?
      1. USVineet Reynolds
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload