Databases
StackOverflow2013
Postsdbo
POIs this wrapper for PDO 'good code' ? Are there any potential problems?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIs this wrapper for PDO 'good code' ? Are there any potential problems?
    primarykey
    data
    text
    <p>I built this class to work with PDO, to make SQL queries 'easier' and less to worry about. </p> <p>Here are my thoughts</p> <ul> <li>Should it be more like class DB extends PDO?</li> <li>Is the query method too big? Should it be split into private methods which are called.. is this what is known as <em>loose coupling</em>?</li> <li>Is my way for detecting a SELECT query too ugly for it's own good? </li> <li>What other problems are evident? As I am sort of learning-as-I-go, I'm sure I could have overlooked a lot of potential problems.</li> </ul> <p>Thank you</p> <p>` <pre><code> class Db { private static $_instance = NULL; private function __construct() { // can not call me } private function __clone() { // no! } public static function getInstance() { if (!self::$_instance) { try { self::$_instance = new PDO('mysql:host=' . CONFIG_MYSQL_SERVER . ';dbname=' . CONFIG_MYSQL_DATABASE, CONFIG_MYSQL_USERNAME, CONFIG_MYSQL_PASSWORD);; self::$_instance-&gt; setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); } catch(PDOException $e) { trigger_error($e-&gt;getMessage()); } } return self::$_instance; } public static function query($query /*string*/, $bindings = NULL) { $queryPortion = substr($query,0, 6); try { if ($bindings) { $prepared = self::getInstance()-&gt;prepare($query); foreach($bindings as $binding=&gt;$data) { // defaults to string if (!is_array($data)) { $prepared-&gt;bindParam($binding, $data); } else { switch(count($data)) { case 1: $prepared-&gt;bindParam($binding, $data['value']); break; case 2: $prepared-&gt;bindParam($binding, $data['value'], $data['dataType']); break; case 3: $prepared-&gt;bindParam($binding, $data['value'], $data['dataType'], (int)$data['length']); break; default: trigger_error('An error has occured with the prepared statement bindings.'); return false; break; } } } $prepared-&gt;execute(); return $prepared-&gt;fetchAll(PDO::FETCH_ASSOC); } else if (String::match($queryPortion, 'select')) { // if this is a select query $rows = self::getInstance()-&gt;query($query); return $rows-&gt;fetchAll(PDO::FETCH_ASSOC); } else { return self::getInstance()-&gt;exec($query); } } catch(PDOException $e) { trigger_error($e-&gt;getMessage()); } } public static function getLastInsertId() { try { self::getInstance()-&gt;lastInsertId(); } catch(PDOException $e) { trigger_error($e-&gt;getMessage()); } } public static function disconnect() { // kill PDO object self::$_instance = NULL; } } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USalex
    plurals
    1. This table or related slice is empty.
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POIs this wrapper for PDO 'good code' ? Are there any potential problems?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POIs this wrapper for PDO 'good code' ? Are there any potential problems?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POIs this wrapper for PDO 'good code' ? Are there any potential problems?
      1. USm42
      1. VTFavorite
    1. This table or related slice is empty.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload