Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>My attempt:</p> <pre><code>def punctuality_report @date = params[:date] ? Date.strptime(params[:date], "%m/%d/%Y") : Date.today @through = params[:through] ? Date.strptime(params[:through], "%m/%d/%Y") : @date + 1 time_range = @date.to_formatted_s(:db)..@through.to_formatted_s(:db) @orders = Order.daily.includes(:store).where('orders.created_at' =&gt; time_range).group_by{|o| o.store} @orders.each_key.each do |s| all_early = @orders[s].collect{|o| o if o.early?}.compact all_late = @orders[s].collect{|o| o if o.late?}.compact self.instance_variable_set("@s#{s.id}_early", all_early) self.instance_variable_set("@s#{s.id}_avg_early", all_early.count &gt; 0 ? all_early.collect{|o| o.earliness}.sum / all_early.count : 0) self.instance_variable_set("@s#{s.id}_late", all_late) self.instance_variable_set("@s#{s.id}_avg_late", all_late.count &gt; 0 ? all_late.collect{|o| o.lateness}.sum / all_late.count : 0) self.instance_variable_set("@s#{s.id}_on_time", @orders[s] - (all_early | all_late) ) end end </code></pre> <p>In short: in the <code>eval</code> section only instance variables were added, and we can use <code>instance_variable_get</code> and <code>instance_variable_set</code> instead. Almost all occurences of <code>eval</code> can be avoided, but I also believe that <code>eval</code> sometimes can be extremely useful and very powerful. </p> <p>The code more clearly expresses its intent: it will add a set of instance variables, which is immediately visible on sight.</p> <p>I definitely do not consider the use of <code>group_by</code> to be a code smell.</p>
    singulars
    1. This table or related slice is empty.
    1. PORails Group_By Antipattern
      singulars
      1. PTQuestion
    1. PTAnswer
    1. This table or related slice is empty.
    1. USnathanvda
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COThanks, Nathanvda. I don't have the reputation to vote 'up' this answer yet but it's very helpful. I think Jaredonline's example addresses my group_by concerns in a style I prefer, but this code has shown me a much nicer way around my use of eval with some methods I didn't know about--much appreciated!
      singulars
      1. PO
      1. USBlastula
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload