Databases
StackOverflow2013
Postsdbo
POC# Generics Efficiency, a better way to do this
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POC# Generics Efficiency, a better way to do this
    primarykey
    data
    text
    <p>Ok, lets say I have classes such as the following:</p> <pre><code>public class KPIObject&lt;T&gt; //&lt;--This class where T is the following classes { public List&lt;T&gt; Data { get; set; } public string Caption { get; set; } } public class KPICycleCountAccuracyData //&lt;--There are 20 of these with different names and values { public string Facility { get; set; } public string CCAdjustedCases { get; set; } public string TotalCases { get; set; } public string CCAdjustedPercent { get; set; } } </code></pre> <p>Then I have:</p> <pre><code>public List&lt;ReportData&gt;&gt; ProcessAccountReport(GetAccountReport request) { var data = new List&lt;ReportData&gt;(); ProcessKPI(data, request.KPICycleCountAccuracy, "KPICycleCountAccuracy"); //&lt;-- 20 of these return data; } </code></pre> <p>Here is the ProcessKPI method:</p> <pre><code>private static void ProcessKPI&lt;T&gt;(List&lt;ReportData&gt; data, ICollection&lt;KPIObject&lt;T&gt;&gt; items, string name) { if (items == null || items.Count &lt;= 0) return; foreach (var item in items) { if (item.Data == null || item.Data.Count &lt;= 0) continue; var temp = new List&lt;object&gt;(); temp.AddRange((IEnumerable&lt;object&gt;)item.Data); data.Add(new ReportData { Data = temp, Name = name, Title = item.Caption }); } } </code></pre> <p>All of this works and compiles correctly, I am just wondering if this is the most efficient way of doing this.</p> <p>Thanks.</p> <p><strong>EDIT</strong></p> <p>I changed process KPI to this:</p> <pre><code>private static void ProcessKPI&lt;T&gt;(ICollection&lt;ReportData&gt; data, ICollection&lt;KPIObject&lt;T&gt;&gt; items, string name) { if (items == null || items.Count &lt;= 0) return; foreach (var item in items.Where(item =&gt; item.Data != null &amp;&amp; item.Data.Count &gt; 0)) { data.Add(new ReportData { Data = (IEnumerable&lt;object&gt;)item.Data, Name = name, Title = item.Caption }); } } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USCyberdrew
    1. USCyberdrew
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POC# Generics Efficiency, a better way to do this
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POC# Generics Efficiency, a better way to do this
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POC# Generics Efficiency, a better way to do this
      1. This table or related slice is empty.
      1. VTUpMod
    1. COJust to be clear what type of efficiency gain you are looking for: are you saying that you are making 20 calls to `ProcessKPI()` (one call for each of the 20 types you indicated in the first code snippet), and that if you added one more type you would have to add one more call to `ProcessKPI()`, etc.? And you are looking for a more scalable way to write this code?
      singulars
      1. POC# Generics Efficiency, a better way to do this
      1. USKP Taylor
    2. COPerformance, less code, memory issues. Yes, if I add another class, I have to make another ProcessKPI call.
      singulars
      1. POC# Generics Efficiency, a better way to do this
      1. USCyberdrew
    3. CONot sure about the long of it, but I do know your data parameter doesn't need to be a ref since it's not a value type.
      singulars
      1. POC# Generics Efficiency, a better way to do this
      1. USCorey Coogan
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload