Databases
StackOverflow2013
Postsdbo
POIs it bad practice to unit test that a class uses a specific validation class for entity validation?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIs it bad practice to unit test that a class uses a specific validation class for entity validation?
    primarykey
    data
    text
    <p>I run all my actions through classes that I call "commands". To illustrate this, to create a new user I would call the following code</p> <pre><code>new CreateUserCommand(unitOfWork).SetName("Username").SetPassword("Blah").Execute(); </code></pre> <p>I am now currently looking at implementing validation into this system, to validate things such as the password is a certain length, the username is not a duplicate in the database, etc... </p> <p>To handle this, I am looking at using fluent validations and creating a validation class for each type of entity validation entity I want. For example, I would have a class such as </p> <pre><code>public class NewUserValidation : ValidationFor&lt;User&gt; { public NewUserValidation() { // Validation Rules here } } </code></pre> <p>One advantage of creating validation in it's own class is that I can use the same validation rules for multiple commands (for example, editing and creating companies may use the same validation rules).</p> <p>Now each of these validation classes would have unit tests associated with them. However, I am trying to figure out how to deal with the unit tests for the command classes that utilize these validation classes. </p> <p>For example, when creating a test for the command class, would I create individual tests for each validation rule for the class (thus essentially duplicating all the unit tests for the validation class itself for every command class I plan to use the same validation class for)? This makes a lot of overhead, especially when I already know that the validation class works because of separate unit tests for them.</p> <p>The only other option that I see is to expose a public property in the command that holds the validation class, and I would then unit test that the command's validation class is the expected validation class. The problem with this method though is I need to devise some way to verify that my <code>Execute()</code> method is actually running the validation class (otherwise there is no way to know if validation isn't being run).</p> <p>I am still leaning towards the latter testing method, just to help keep the overhead down, but I do need to find a solution for checking if the validation is actually run. Would this be a bad way to go about it, and would I be better going for the former style instead?</p> <p><hr> <em>Edit</em>: To reply to both answers below, the validation is going to be used inside of the <code>Execute()</code> method, by a <code>validator.Validate(entity)</code> call in the implementation of <code>Execute()</code>. </p> <p>While I don't want to violate DRY, I don't see an easy way to verify that <code>Execute()</code> 1) uses the correct validation class by default and 2) Actually calls the <code>.validate(entity)</code> method of the validation class. </p> <p>I can solve #1 by instantiating the validation class in the constructor, and expose it through a public property of the command class, but I am unsure of how to correctly unit test for the 2nd issue without repeating the individual validation unit tests.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USKallDrexx
    1. USKallDrexx
    plurals
    1. PL
      singulars
      1. LTLinked
    2. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POIs it bad practice to unit test that a class uses a specific validation class for entity validation?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POIs it bad practice to unit test that a class uses a specific validation class for entity validation?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POIs it bad practice to unit test that a class uses a specific validation class for entity validation?
      1. This table or related slice is empty.
      1. VTUpMod
    1. This table or related slice is empty.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload