Databases
StackOverflow2013
Postsdbo
PORoman to decimal conversion
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PORoman to decimal conversion
    primarykey
    data
    text
    <p>What do you think about this code? Is it the best way? Any improvement?</p> <p>Roman.h</p> <pre><code>#ifndef ROMAN_H #define ROMAN_H #include &lt;string&gt; #include &lt;map&gt; typedef unsigned long int UL_I; typedef std::map&lt; std::string, UL_I, std::less&lt; std::string &gt; &gt; Map; class Roman_Number { public: //Constructor Roman_Number( std::string ); void Convert_to_decimal(); UL_I get_Decimal() const; std::string get_Roman() const; private: std::string s_roman_number; UL_I d_number; Map pairs; Map pairs_substracting; //Utilitaries functions void _validate_(); void _initilize_pairs_() { pairs.insert( Map::value_type( "I", 1 ) ); pairs_substracting.insert( Map::value_type ( "IV", 4 ) ); pairs.insert( Map::value_type( "V", 5 ) ); pairs_substracting.insert( Map::value_type( "IX", 9 ) ); pairs.insert( Map::value_type( "X", 10 ) ); pairs_substracting.insert( Map::value_type( "XL", 40 ) ); pairs.insert( Map::value_type( "L", 50 ) ); pairs_substracting.insert( Map::value_type( "XC", 90 ) ); pairs.insert( Map::value_type( "C", 100 ) ); pairs_substracting.insert( Map::value_type( "CD", 400 ) ); pairs.insert( Map::value_type( "D", 500 ) ); pairs_substracting.insert( Map::value_type( "CM", 900 ) ); } UL_I _recursive_convert( std::string ); }; #endif </code></pre> <p>Roman.cpp</p> <pre><code>#include &lt;iostream&gt; #include "Roman.h" void Roman_Number::_validate_() { std::cout &lt;&lt; "Validating" &lt;&lt; std::endl; } Roman_Number::Roman_Number(std::string r_number ) { _initilize_pairs_(); s_roman_number = r_number; d_number = 0; } void Roman_Number::Convert_to_decimal() { std::string s_aux = s_roman_number; d_number = _recursive_convert( s_aux ); } UL_I Roman_Number::_recursive_convert( std::string new_roman ) { if( new_roman == "" ) return 0; if( pairs_substracting.find( new_roman.substr( 0 , 2 ) ) != pairs_substracting.end() ) return pairs_substracting[new_roman.substr( 0, 2 )] + _recursive_convert( new_roman.erase( 0, 2) ); else return pairs[new_roman.substr( 0, 1 )] + _recursive_convert( new_roman.erase( 0, 1 ) ); } UL_I Roman_Number::get_Decimal() const { return d_number; } std::string Roman_Number::get_Roman() const { return s_roman_number; } </code></pre> <p>main.cpp</p> <pre><code>#include &lt;iostream&gt; #include "Roman.h" int main() { Roman_Number R_N( "XIL" ); R_N.Convert_to_decimal(); std::cout &lt;&lt; R_N.get_Decimal(); return 0; } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USBart
    1. USfpointbin
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. PORoman to decimal conversion
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PORoman to decimal conversion
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PORoman to decimal conversion
      1. This table or related slice is empty.
      1. VTUpMod
    1. CO[Programmers](http://Programmers.stackexchange.com) is a better site for review requests. Also there was a similar question on [codegolf.stackexchange.com](http://codegolf.stackexchange.com/questions/797/roman-numeral-converter-function)
      singulars
      1. PORoman to decimal conversion
      1. USMartin York
    2. COI give it VIII out of X stars.
      singulars
      1. PORoman to decimal conversion
      1. USSteve Wellens
    3. COI'd recommend using http://codereview.stackexchange.com/ if you want generic comments on code you've written.
      singulars
      1. PORoman to decimal conversion
      1. USMadcapLaugher
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload