Databases
StackOverflow2013
Postsdbo
POBest practice for parsing and validating mobile number
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POBest practice for parsing and validating mobile number
    primarykey
    data
    text
    <p>I wonder what the best practice for parsing and validating a mobile number before sending a text is. I've got code that works, but I'd like to find out better ways of doing it (as my last question, this is part of my early new years resolution to write better quality code!).</p> <p>At the moment we are very forgiving when the user enters the number on the form, they can enter things like "+44 123 4567890", "00441234567890", "0123456789", "+44(0)123456789", "012-345-6789" or even "haven't got a phone".</p> <p>However, to send the text the format must be 44xxxxxxxxxx (this is for UK mobiles only), so we need to parse it and validate it before we can send. Below is the code that I have for now (C#, asp.net), it would be great if anyone had any ideas on how to improve it.</p> <p>Thanks,</p> <p>Annelie</p> <pre><code>private bool IsMobileNumberValid(string mobileNumber) { // parse the number _mobileNumber = ParsedMobileNumber(mobileNumber); // check if it's the right length if (_mobileNumber.Length != 12) { return false; } // check if it contains non-numeric characters if(!Regex.IsMatch(_mobileNumber, @"^[-+]?[0-9]*\.?[0-9]+$")) { return false; } return true; } private string ParsedMobileNumber(string number) { number = number.Replace("+", ""); number = number.Replace(".", ""); number = number.Replace(" ", ""); number = number.Replace("-", ""); number = number.Replace("/", ""); number = number.Replace("(", ""); number = number.Replace(")", ""); number = number.Trim(new char[] { '0' }); if (!number.StartsWith("44")) { number = "44" + number; } return number; } </code></pre> <p><strong>EDIT</strong></p> <p>Here's what I ended up with:</p> <pre><code>private bool IsMobileNumberValid(string mobileNumber) { // remove all non-numeric characters _mobileNumber = CleanNumber(mobileNumber); // trim any leading zeros _mobileNumber = _mobileNumber.TrimStart(new char[] { '0' }); // check for this in case they've entered 44 (0)xxxxxxxxx or similar if (_mobileNumber.StartsWith("440")) { _mobileNumber = _mobileNumber.Remove(2, 1); } // add country code if they haven't entered it if (!_mobileNumber.StartsWith("44")) { _mobileNumber = "44" + _mobileNumber; } // check if it's the right length if (_mobileNumber.Length != 12) { return false; } return true; } private string CleanNumber(string phone) { Regex digitsOnly = new Regex(@"[^\d]"); return digitsOnly.Replace(phone, ""); } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USannelie
    1. USannelie
    plurals
    1. This table or related slice is empty.
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POBest practice for parsing and validating mobile number
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POBest practice for parsing and validating mobile number
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POBest practice for parsing and validating mobile number
      1. USuser279521
      1. VTFavorite
    1. COTrim leading zero's instead of replacing "0044".
      singulars
      1. POBest practice for parsing and validating mobile number
      1. USP.Brian.Mackey
    2. COGreat point, I've edited it now, thanks!
      singulars
      1. POBest practice for parsing and validating mobile number
      1. USannelie
    3. COYou can't just trim leading zeros because "0712345678" will become "712345678". Also number.Trim will trim trailing and leading zeros, which is bad idea too.
      singulars
      1. POBest practice for parsing and validating mobile number
      1. USPolyfun
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload