Databases
StackOverflow2013
Postsdbo
POconverting markdown lists to html lists in PHP
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POconverting markdown lists to html lists in PHP
    primarykey
    data
    text
    <p>I have been working on a markdown converter today for a project of mine. I got lost in it and just ran through the code and noticed I had a huge amount for converting lists. My code is below , I have just supplied the code that deals with lists, I could really do with some suggestions on shortening the code, I just cant see past what I have written and need a fresh pair of eyes.</p> <pre><code>&lt;?php class Markdown { private static $html = ''; private static $list_types = array( array( '&gt;&gt;', '&lt;ul&gt;', '&lt;/ul&gt;' ), array( '&gt;&gt;&gt;', '&lt;ol&gt;', '&lt;/ol&gt;' ) ); private static $list_patterns = array( '/-[ ]+(.+)/' =&gt; ' &gt;&gt;\1', '/[0-9]{1}\. (.+)/' =&gt; ' &gt;&gt;&gt;\1' ); public static function convertText($markdown = array()) { $markdown = explode("\n", strip_tags($markdown)); foreach ($markdown as &amp;$line) { $line = htmlentities($line, ENT_QUOTES, 'UTF-8'); foreach (self::$list_patterns as $pattern =&gt; $replace) { if (!is_array($line) &amp;&amp; preg_match($pattern, $line)) { $para = false; $line = preg_replace($pattern, $replace, $line); $type = 0; foreach (self::$list_types as $key =&gt; $val) { if (preg_match('/ ' . $val[0] . ' /', $line)) $type = $key; } $line = preg_split('/' . self::$list_types[$type][0] . '/', $line); $line = array('depth' =&gt; strlen($line[0]), 'string' =&gt; $line[1], 'type' =&gt; $type); } } } while (!empty($markdown)) { $snippet = array_shift($markdown); if (is_array($snippet)) self::makeList($snippet, $markdown); else self::$html .= $snippet; } return self::$html; } private static function makeList($snippet, &amp;$markdown, $last_depth = 0, $close_tag = '') { if ($last_depth == $snippet['depth']) self::$html .= sprintf('&lt;/li&gt;&lt;li&gt;%s', $snippet['string']); elseif ($last_depth &lt; $snippet['depth']) self::$html .= sprintf('%s&lt;li&gt;%s', self::$list_types[$snippet['type']][1], $snippet['string']); elseif ($last_depth &gt; $snippet['depth']) self::$html .= sprintf('&lt;/li&gt;%s&lt;li&gt;%s', $close_tag, $snippet['string']); $next_snippet = array_shift($markdown); if (is_array($next_snippet)) self::makeList($next_snippet, $markdown, $snippet['depth'], self::$list_types[$snippet['type']][2]); else array_unshift($markdown, $next_snippet); self::$html .= sprintf('&lt;/li&gt;%s', $close_tag); } } ?&gt; </code></pre> <p>Basically the code does lots of pattern matching and for any patterns except list it will leave as a string in the array "$markdown", for lists it creates an array with the list type, depth and string. There fore at the end of the text conversion I can loop through the "$markdown" array and build the nested loop structure by checking if the next item is an array or not.</p> <p>Sorry if the question seems vague, its not ment to be, I just want some hint on how to shorten my code as it seems like I have written loads.</p> <p>Thanks in advance</p> <p>Luke</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USNicole
    1. USLuke
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POconverting markdown lists to html lists in PHP
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POconverting markdown lists to html lists in PHP
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POconverting markdown lists to html lists in PHP
      1. This table or related slice is empty.
      1. VTUpMod
    1. COYou realize there's already a complete PHP markdown implementation in the wild? It's licensed BSD/GPL (what you prefer) so embedding it on your software shouldn't be a problem. http://michelf.com/projects/php-markdown/
      singulars
      1. POconverting markdown lists to html lists in PHP
      1. USThiefMaster
    2. COWhat @thief said. Unless you're really interested in wheels, don't reinvent them.
      singulars
      1. POconverting markdown lists to html lists in PHP
      1. USdeceze
    3. COI have looked at this class and after removing all of the unnecessary stuff for me (I dont need the wordpress stuff etc) its still 1500 lines of code. I know that there is a great deal of commenting in those 1500 lines but I was just hoping that it was achievable in a smaller package. And this kind of wheel does hold some interest for me. Thanks for the comments though.
      singulars
      1. POconverting markdown lists to html lists in PHP
      1. USLuke
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload