Databases
StackOverflow2013
Postsdbo
POIs passing a service reference to another service layer bad practice?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIs passing a service reference to another service layer bad practice?
    primarykey
    data
    text
    <p>I've got a C# MVC application that I break up in the following way: View -> Controller -> Service -> Repository</p> <p>I use the thin controller practice with each view having a unique view model that's returned from the relevant service.</p> <p>Quick Example: View: /NewAppointment/Step1</p> <p>Its controler would look like this:</p> <pre><code>public ActionResult Step1() { return View(_appointmentService.Step1GetModel() ); } </code></pre> <p>And the appointment service layer would look like this:</p> <pre><code>public Step1Model Step1GetModel() { return new Step1Model(); } </code></pre> <p>Thus I have several different service layers in use through out my application, each implementing a distinct interface. </p> <p>My question comes in when I need to have one service layer interact with another service layer. In this case, is it better practice to pass an interface reference to the service call, or should I let the controller handle collecting all the data and then pass the relevant results back to the service?</p> <p>Example:</p> <p>Say I want to populate my view model with the customer's information by default. The two ways I see of doing this are:</p> <p>Pass an customer interface reference to the appointment service, and then let the appointment service call the appropriate GetCustomer method in the customer service...</p> <p>In Code:</p> <pre><code> private ICustomerService _customerService; private IAppointmentService _appointmentService; public ActionResult Step1() { var viewModel = _appointmentService.Step1GetModel( _customerService ); return View(viewModel); } </code></pre> <p>OR</p> <p>Let the controller handle the logic of getting the customer, then pass that result to the appointment service.</p> <p>In Code:</p> <pre><code>private ICustomerService _customerService; private IAppointmentService _appointmentService; public ActionResult Step1() { var customer = _customerService.GetCustomer(); var viewModel = _appointmentService.Step1GetModel( customer ); return View(viewModel); } </code></pre> <p>I'm torn as to which would be better practice. The first keeps the controller nice and thin, but creates an inter-service dependency between the appointment service and the customer service. The second puts more logic into the controller, but keeps the services totally independent.</p> <p>Anyone have thoughts as to which would be better practice?</p> <p>Thanks~</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USPleaseStand
    1. USTheRightChoyce
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POIs passing a service reference to another service layer bad practice?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POIs passing a service reference to another service layer bad practice?
      1. USmathieu
      1. VTFavorite
    3. VO
      singulars
      1. POIs passing a service reference to another service layer bad practice?
      1. This table or related slice is empty.
      1. VTUpMod
    1. This table or related slice is empty.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload