Databases
StackOverflow2013
Postsdbo
POWorkflow for GitHub-based code review
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POWorkflow for GitHub-based code review
    primarykey
    data
    text
    <p>I'm considering using <a href="http://github.com" rel="noreferrer">GitHub</a> as our primary tool for doing code review. With features like in-line commenting and compare view, it seems to have a lot of features that tools like Gerrit have on offer.</p> <p>Has anyone else used GitHub for this? If so, what is your workflow? And what have your experiences been doing so, both positive and negative?</p> <p>As I get some thoughts on this and sort out what will work best for us, I'll edit my question to share my own proposed workflow. </p> <p><strong>EDITED with proposed workflow</strong></p> <p>Step 0. <a href="http://help.github.com/post-receive-hooks/" rel="noreferrer">Set up a post-receive hook</a> using the awesome <a href="https://github.com/supermatter/reviewth.is" rel="noreferrer">reviewth.is</a>.</p> <p>Then:</p> <ol> <li><p>Commit as usual with <code>commit -a -s</code>, but in the commit message append <code>#reviewthis @username</code>.</p></li> <li><p>If the build fails, the review is skipped until the build is restored.</p></li> <li><p>Reviewer comments on commit line-by-line or at the file level.</p></li> <li><p>GitHub automagically notifies reviewee of comments.</p></li> <li><p>Reviewer notifies reviewee by email when comments are completed with a review summary.</p></li> <li><p>Reviewee replies to reviewer comments within GitHub, allowing the project access to history of code reviews.</p></li> </ol> <p><strong>My biggest problems are with Step 2 and Steps 4/5.</strong> Gerrit works nicely for not asking for reviews unless the build succeeds; I'd like a way to do this within GitHub. Steps 4/5 also have the potential to get annoying (multiple emails) and reduce the automatic nature of the review process (requiring an emailed summary).</p> <p>We use Hudson as our build server, if that helps.</p> <p><strong>Any thoughts on these problems would also be helpful.</strong></p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USTrojan
    1. USJosh Smith
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POWorkflow for GitHub-based code review
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POWorkflow for GitHub-based code review
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POWorkflow for GitHub-based code review
      1. This table or related slice is empty.
      1. VTUpMod
    1. This table or related slice is empty.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload