Databases
StackOverflow2013
Postsdbo
PONSString memory leak
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PONSString memory leak
    primarykey
    data
    text
    <p>I am getting a memory leak in a method that builds a email message string from a NSManagedObject. The string is created with NSString convenience methods, and so should be autoreleased. What am I missing? Code below... Instruments is flagging the final occurance of buildString near the bottom of the method (see comment in code):</p> <pre> <code> -(void)buildEmailMessage { //check for presence of lat and lon data BOOL hasStartLatLon = NO; BOOL hasEndLanLon = NO; NSString *startLat; NSString *startLong; NSString *endLat; NSString *endLong; NSString *mapURL; NSString *finalMapURL; if( [managedObject valueForKey:@"startLat"] > 0 ){ hasStartLatLon = YES; startLat = [self formatLatLon:[managedObject valueForKey:@"startLat"]]; startLong= [self formatLatLon:[managedObject valueForKey:@"startLong"]]; } if( [managedObject valueForKey:@"endLat"] > 0 ) { hasEndLanLon = YES; endLat = [self formatLatLon:[managedObject valueForKey:@"endLat"]]; endLong= [self formatLatLon:[managedObject valueForKey:@"endLong"]]; } // Build strings from managedObject // Start with the trip info already validated NSString *tripName = [managedObject valueForKey:@"tripName"]; NSString *intro = [NSString stringWithString:@"<p>Please contact the approriate authorities and provide them with the enclosed information if our party does not return withing 12 hours of the return date shown below. Thanks.<p>"]; id vStartDate = [managedObject valueForKey:@"startDate"]; NSString *startDate = [NSString stringWithFormat:@"<p><b>Start Date: </b>%@", [vStartDate managedObjectValueDisplay]]; id vEndDate = [managedObject valueForKey:@"endDate"]; NSString *endDate = [NSString stringWithFormat:@"<br /><b>End Date: </b>%@</p>", [vEndDate managedObjectValueDisplay]]; NSString *startFrom = [NSString stringWithFormat:@"<p><b>Departing from:</b><br />%@", [managedObject valueForKey:@"startFrom"]]; if( hasStartLatLon ){ startFrom = [startFrom stringByAppendingString:@"<br />"]; startFrom = [startFrom stringByAppendingString:[self getLatLon:@"start"]]; } startFrom = [startFrom stringByAppendingString:@"</p>"]; NSString *endAt = [NSString stringWithFormat:@"<p><b>Returning to:</b><br />%@", [managedObject valueForKey:@"endAt"]]; if( hasStartLatLon ){ endAt = [endAt stringByAppendingString:@"<br />"]; endAt = [endAt stringByAppendingString:[self getLatLon:@"end"]]; } endAt = [startFrom stringByAppendingString:@"</p>"]; // Add a link to Google Maps if there is geodata if (hasStartLatLon || hasEndLanLon) { if (hasStartLatLon) { mapURL = [NSString stringWithFormat:@"http://maps.google.com/?q=%@,%@+(%@)&ll=%@,%@&z=14&t=p", startLat, startLong, [managedObject valueForKey:@"startFrom"], startLat, startLong]; } else { mapURL = [NSString stringWithFormat:@"http://maps.google.com/?q=%@,%@+(%@)&ll=%@,%@&z=14&t=p", endLat, endLong, [managedObject valueForKey:@"endAt"], endLat, endLong]; } NSString* escapedUrlString =[mapURL stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]; NSLog(@"escaped map url = %@", escapedUrlString); finalMapURL = [NSString stringWithFormat:@"<b>Link to Google Map:</b><br />%@", escapedUrlString]; } NSString *routeInfo = [NSString stringWithFormat:@"<p><b>Route Information:</b><br />%@ </p>", [managedObject valueForKey:@"routeInfo"]]; // Check for vehicle info BOOL hasVehicleMakeAndModel = NO; BOOL hasVehicleLicenseNumber = NO; BOOL hasVehicleState = NO; NSString *vehicleMakeAndModel = [managedObject valueForKey:@"vehicleMakeAndModel"]; NSString *vehicleLicenseNumber = [managedObject valueForKey:@"vehicleLicenseNumber"]; NSString *vehicleState = [managedObject valueForKey:@"vehicleState"]; if ( vehicleMakeAndModel.length > 0 ) { hasVehicleMakeAndModel = YES; } if ( vehicleLicenseNumber.length > 0 ) { hasVehicleLicenseNumber = YES; } if ( vehicleState.length > 0 ) { hasVehicleState = YES; } //Build the vehicle string NSString *vehicleString; if (hasVehicleMakeAndModel || hasVehicleLicenseNumber || hasVehicleState) { vehicleString = [NSString stringWithString:@"<p><b>Vehicle Information:</b><br />"]; } if (hasVehicleMakeAndModel) { vehicleString = [vehicleString stringByAppendingString:@"Make/Model: "]; vehicleString = [vehicleString stringByAppendingString:vehicleMakeAndModel]; vehicleString = [vehicleString stringByAppendingString:@"<br />"]; } if (hasVehicleLicenseNumber) { vehicleString = [vehicleString stringByAppendingString:@"License #: "]; vehicleString = [vehicleString stringByAppendingString:vehicleLicenseNumber]; vehicleString = [vehicleString stringByAppendingString:@"<br/>"]; } if (hasVehicleState) { vehicleString = [vehicleString stringByAppendingString:@"State: "]; vehicleString = [vehicleString stringByAppendingString:vehicleState]; } // Get the NSSet of party members from the managedObject // and build the party members/emergency contact info NSSet *membersSet = [managedObject valueForKey:@"members"]; NSString *membersString; if ( [membersSet count] > 0) { membersString = @"<p><b>Party Members:</b></p>"; NSArray *membersArray = [NSArray arrayByOrderingSet:membersSet byKey:@"lastName" ascending:YES]; for (NSManagedObject *oneObject in membersArray) { BOOL hasFirstName = NO; BOOL hasLastName = NO; BOOL hasAge = NO; BOOL hasContactName = NO; BOOL hasContactNumber = NO; NSString *memberFirstName = [oneObject valueForKey:@"firstName"]; NSString *memberLastName = [oneObject valueForKey:@"lastName"]; NSNumber *memberAgeNum = [oneObject valueForKey:@"age"]; NSString *memberAgeString; if (memberAgeNum > 0) { memberAgeString = [NSString stringWithFormat:@"%d", [memberAgeNum intValue]]; } else { memberAgeString = [NSString stringWithString:@""]; } NSString *contactName = [oneObject valueForKey:@"contactName"]; NSString *contactNumber = [oneObject valueForKey:@"contactNumber"]; if ( [memberFirstName length] > 0) { hasFirstName = YES; } if ( [memberLastName length] > 0) { hasLastName = YES; } if ( [memberAgeString length] > 0) { hasAge = YES; } if ( [contactName length] > 0) { hasContactName = YES; } if ( [contactNumber length] > 0) { hasContactNumber = YES; } NSString *oneMemberString = [NSString stringWithString:@"<li>"]; if (hasFirstName) { oneMemberString = [oneMemberString stringByAppendingFormat:@"%@ ", memberFirstName]; } if (hasLastName) { oneMemberString = [oneMemberString stringByAppendingString:memberLastName]; } if (hasAge) { oneMemberString = [oneMemberString stringByAppendingFormat:@", %@", memberAgeString]; } if (hasContactName) { oneMemberString = [oneMemberString stringByAppendingFormat:@"<br />Emergency Contact:<br />%@", contactName]; } if (hasContactNumber) { oneMemberString = [oneMemberString stringByAppendingFormat:@"<br />Phone: %@<br /><br /></li>", contactNumber]; } membersString = [membersString stringByAppendingString:oneMemberString]; } } NSString *buildString = [NSString stringWithFormat:@"<b><p>Trip Plan for:</b><br />%@</p>", tripName]; buildString = [buildString stringByAppendingString: intro]; buildString = [buildString stringByAppendingString: startDate]; buildString = [buildString stringByAppendingString: endDate]; buildString = [buildString stringByAppendingString: startFrom]; buildString = [buildString stringByAppendingString: endAt]; if (hasStartLatLon || hasEndLanLon) buildString = [buildString stringByAppendingString: finalMapURL]; buildString = [buildString stringByAppendingString: routeInfo]; // Append the vehicle string if any vehicle data is present if (hasVehicleMakeAndModel || hasVehicleLicenseNumber || hasVehicleState) { buildString = [buildString stringByAppendingString: vehicleString]; } // Append the members string if any members data is present // **MEMORY LEAK** flagged on the line enclosed by the if statement below if ( [membersSet count] > 0) { buildString = [buildString stringByAppendingString: membersString]; } self.myEmailString = [NSString stringWithString:buildString]; } </code> </pre> <pre> <code> -(NSString *)formatLatLon:(NSNumber *)value { NSNumberFormatter *formatter = [[NSNumberFormatter alloc] init]; [formatter setNumberStyle:NSNumberFormatterDecimalStyle]; [formatter setPositiveFormat:@"##0.00000"]; NSString *returnString = [formatter stringFromNumber:value]; [formatter release]; return returnString; } </code> </pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USAlpinista
    1. USAlpinista
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COCan you post the code for `formatLanLon`? Also, you can consider using an `NSMutableString` and append there, instead of using `stringByAppendingString` which will create several `NSString` instances that will be autoreleased.
      singulars
      1. PONSString memory leak
      1. USpgb
    2. COConsider refactoring this function into several, smaller functions. The longer a single function is, the harder it is to read and understand.
      singulars
      1. PONSString memory leak
      1. USShaggy Frog
    3. COPGB - Here's the code for formatting lat and lon: added at the bottom of the listing above. I'll try your suggestion of NSMutableString
      singulars
      1. PONSString memory leak
      1. USAlpinista
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload