Databases
StackOverflow2013
Postsdbo
POSQL Stored Procedure Issue - Decimal Value Conversion Issue
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POSQL Stored Procedure Issue - Decimal Value Conversion Issue
    primarykey
    data
    text
    <p>I am running into a very strange problem in a SQL Server stored procedure. </p> <p>I have two databases. One contains the database for my billing system. The other is a reporting system with summarized data. Within this database there is a table with summarized job information. When this data is created, one of the fields, BilledToDate, is null. I wrote a stored procedure that creates a cursor that goes through this table and gets all of the job numbers. I then go through each job number and run a query against the billing database to get the total amount of billing that has been charged against job. Once I have this total, I update the BilledToDate column with this value.</p> <p>The problem is that after running the stored procedure, some of the results are correct and some aren't. There doesn't appear to be any logical explanation as to why one is right and the next one is isn't. I put some print statements in the stored procedure and all of the values were correct. As an example, for one record the correct sum was 99,218.25 but the update put a value of 14,700.70 into the BilledToDate field. I added a varchar column to the table and populated that field. They are all correct. This leads me to believe that it is a casting problem but I checked and double checked my datatypes and they all look correct. I am pulling my hair out on this one (what little that is left).</p> <p>My stored procedure is below. The InvoiceAmt field is a decimal(16,2) in the invchead table and I have kept it consistent throughout the process so I don't undertand why this is happening.</p> <pre><code>ALTER PROCEDURE [dbo].[sp_CalculateBilledToDate] AS BEGIN -- SET NOCOUNT ON added to prevent extra result sets from -- interfering with SELECT statements. SET NOCOUNT ON; DECLARE @JobID varchar(10) DECLARE @RecordID int DECLARE @BilledToDate decimal(16,2) DECLARE c1 CURSOR FOR SELECT JobID, RecordID FROM StructuralOpenBilling OPEN c1 FETCH NEXT FROM c1 INTO @JobID, @RecordID WHILE @@FETCH_STATUS = 0 BEGIN SELECT @BilledToDate = CONVERT(money, CASE WHEN SUM(invoiceamt) &gt; 0 THEN SUM(InvoiceAmt) ELSE 0 END) FROM mfgsys803.dbo.invchead WHERE shortchar01 = RTRIM(@JobID) PRINT 'Record ID: ' + CONVERT(varchar(10), @RecordID) + ' JobID: ' + RTRIM(CONVERT(varchar(10), @JobID)) + ' Billed: ' + CONVERT(varchar(10), @BilledToDate) UPDATE StructuralOpenBilling SET BilledToDate = @BilledToDate, BilledCheck = CONVERT(varchar(50), @BilledToDate) WHERE RecordID = @RecordID PRINT 'Record ID: ' + CONVERT(varchar(10), @RecordID) + ' JobID: ' + RTRIM(CONVERT(varchar(10), @JobID)) + ' Billed: ' + CONVERT(varchar(10), @BilledToDate) FETCH NEXT FROM c1 INTO @JobID, @RecordID END CLOSE c1 DEALLOCATE c1 END </code></pre> <p>Any ideas would be appreciated.</p> <p>Thanks.</p> <p>John</p>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USbobs
    1. USuser412421
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POSQL Stored Procedure Issue - Decimal Value Conversion Issue
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POSQL Stored Procedure Issue - Decimal Value Conversion Issue
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POSQL Stored Procedure Issue - Decimal Value Conversion Issue
      1. This table or related slice is empty.
      1. VTUpMod
    1. COWould you be able to provide the table structures that the SP works with? Also, have you tried a smaller data set that exposes the problem? Can you provide some sample data?
      singulars
      1. POSQL Stored Procedure Issue - Decimal Value Conversion Issue
      1. USbobs
    2. COWhy is BilledToDate using a money datatype: SELECT @BilledToDate = CONVERT(money, CASE WHEN SUM(invoiceamt) > 0 THEN SUM(InvoiceAmt) ELSE 0 END) when it's initally defined as a decimal(16,2)? And why is a billedtoDATE being assigned a decimal value?
      singulars
      1. POSQL Stored Procedure Issue - Decimal Value Conversion Issue
      1. USPatrick Marchand
    3. COI think he means BilledToDate to be "How much money have you been billed to date (i.e., "so far")".
      singulars
      1. POSQL Stored Procedure Issue - Decimal Value Conversion Issue
      1. USdave
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload