Databases
StackOverflow2013
Postsdbo
POPros and Cons of using SqlCommand Prepare in C#?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POPros and Cons of using SqlCommand Prepare in C#?
    primarykey
    data
    text
    <p>When i was reading books to learn C# (might be some old <code>Visual Studio 2005</code> books) I've encountered advice to always use <code>SqlCommand.Prepare</code> everytime I execute SQL call (whether its' a <code>SELECT</code>/<code>UPDATE</code> or <code>INSERT</code> on SQL SERVER 2005/2008) and I pass parameters to it. <strong>But is it really so</strong>? </p> <ol> <li><p>Should it be done every time? Or just sometimes? </p></li> <li><p>Does it matter whether it's one parameter being passed or five or twenty? </p></li> <li><p>What boost should it give if any? Would it be noticeable at all (I've been using <code>SqlCommand.Prepare</code> here and skipped it there and never had any problems or noticeable differences). </p></li> </ol> <p>For the sake of the question this is my usual code that I use, but this is more of a general question. </p> <pre><code>public static decimal pobierzBenchmarkKolejny(string varPortfelID, DateTime data, decimal varBenchmarkPoprzedni, decimal varStopaOdniesienia) { const string preparedCommand = @"SELECT [dbo].[ufn_BenchmarkKolejny](@varPortfelID, @data, @varBenchmarkPoprzedni, @varStopaOdniesienia) AS 'Benchmark'"; using (var varConnection = Locale.sqlConnectOneTime(Locale.sqlDataConnectionDetailsDZP)) //if (varConnection != null) { using (var sqlQuery = new SqlCommand(preparedCommand, varConnection)) { sqlQuery.Prepare(); sqlQuery.Parameters.AddWithValue("@varPortfelID", varPortfelID); sqlQuery.Parameters.AddWithValue("@varStopaOdniesienia", varStopaOdniesienia); sqlQuery.Parameters.AddWithValue("@data", data); sqlQuery.Parameters.AddWithValue("@varBenchmarkPoprzedni", varBenchmarkPoprzedni); using (var sqlQueryResult = sqlQuery.ExecuteReader()) if (sqlQueryResult != null) { while (sqlQueryResult.Read()) { } } } } </code></pre> <p>Additional clarification: </p> <p>If i move <code>sqlQuery.Prepare()</code> like in code below exception is thrown that the size has to be explicitly declared, which basically leads me to thinking that having <code>sqlQuery.Prepare()</code> as first makes it useless? Can someone show the proper usage using my example?</p> <pre><code>public static decimal pobierzBenchmarkKolejny(string varPortfelID, DateTime data, decimal varBenchmarkPoprzedni, decimal varStopaOdniesienia) { const string preparedCommand = @"SELECT [dbo].[ufn_BenchmarkKolejny](@varPortfelID, @data, @varBenchmarkPoprzedni, @varStopaOdniesienia) AS 'Benchmark'"; using (var varConnection = Locale.sqlConnectOneTime(Locale.sqlDataConnectionDetailsDZP)) //if (varConnection != null) { using (var sqlQuery = new SqlCommand(preparedCommand, varConnection)) { sqlQuery.Parameters.AddWithValue("@varPortfelID", varPortfelID); sqlQuery.Parameters.AddWithValue("@varStopaOdniesienia", varStopaOdniesienia); sqlQuery.Parameters.AddWithValue("@data", data); sqlQuery.Parameters.AddWithValue("@varBenchmarkPoprzedni", varBenchmarkPoprzedni); sqlQuery.Prepare(); using (var sqlQueryResult = sqlQuery.ExecuteReader()) if (sqlQueryResult != null) { while (sqlQueryResult.Read()) { } } } } </code></pre> <p>How would I do that? By adding .size next to parameters and doing varPortfel.Lenght if it's a string etc? </p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USMadBoy
    1. USMadBoy
    plurals
    1. This table or related slice is empty.
    1. PL
      singulars
      1. LTLinked
    2. PL
      singulars
      1. LTDuplicate
    3. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POPros and Cons of using SqlCommand Prepare in C#?
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. POPros and Cons of using SqlCommand Prepare in C#?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POPros and Cons of using SqlCommand Prepare in C#?
      1. This table or related slice is empty.
      1. VTUpMod
    1. This table or related slice is empty.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload