Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>My knee-jerk reaction to this is <a href="http://chargen.matasano.com/chargen/2009/7/22/if-youre-typing-the-letters-a-e-s-into-your-code-youre-doing.html" rel="nofollow noreferrer">If You're Typing The Letters A-E-S Into Your Code, You're Doing It Wrong</a>. Or, as redditor <a href="http://www.reddit.com/r/netsec/comments/attt2/dont_hash_secrets/c0jdilj" rel="nofollow noreferrer">khafra recently reminded us of the Sicilian's version</a>:</p> <blockquote> <p>Haha.. you fool! You fell victim to one of the classic blunders. The most famous is: Never get involved in a land war in Asia. But only slightly less famous is this: Never attempt to roll your own crypto when there's a well-tested library that'll do it better!</p> </blockquote> <p>I mean, I get it. The first time I looked at it, <a href="http://oauth.googlecode.com/svn/code/python/oauth/oauth.py" rel="nofollow noreferrer">oauth.py</a> didn't impress me either. There's been a lot of work on it since and it's looking better, but there still appear to be no tests, so I don't know. Anyway, tests or no tests, it's been reviewed and used by more people than your code has.</p> <p>But that's just me being uptight on the subject of crypto code reuse and doesn't really help you in figuring out the protocol machinery. It looks okay to me, but I haven't had my head in the OAuth spec too much lately.</p> <p>Just use some more lines for that <code>pu.port</code> business; having a conditional <code>if</code> expression, an <code>or</code> expression, and the <code>{}[]</code> construct all in one line is <em>really</em> hard to read.</p> <p>If you really want code review by people who are familiar with the protocol, you're probably better off asking <a href="http://groups.google.com/group/oauth/" rel="nofollow noreferrer">the mailing list</a>. And if you can offer them an alternate API that will make the code in their repository more appealing to new users, that'll be good for everyone.</p>
    singulars
    1. This table or related slice is empty.
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. VO
      singulars
      1. This table or related slice is empty.
    2. VO
      singulars
      1. This table or related slice is empty.
    3. VO
      singulars
      1. This table or related slice is empty.
 

Querying!

 
Guidance

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload