Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>It looks like you get the main idea, but there's a couple things worth mentioning.</p> <p>1) As @chris mentioned, you're forgetting your copy constructor, copy assignment operator, move constructor, and move assignment operator. Copy should be either manually written or disabled, move can be defaulted. (aka You've not followed the rule of 5)</p> <p>2) Prefer to use <code>std::unique_ptr</code> to represent ownership. It's already done all of the hard work for you. By keeping your wrapped string in a <code>std::unique_ptr</code> the default versions of the copy/move special functions will preserve correctness (though you'll still want to implement the copy operations if you want them to be enabled).</p> <p>Here's what this might look like:</p> <pre><code>class StringGetter { public: explicit StringGetter(char* name) { strSize = strlen(name); str = std::unique_ptr&lt;char[]&gt;(new char(strSize+1)); std::copy_n(name, strSize + 1, str.get()); } StringGetter(const StringGetter&amp; other) { strSize = other.strSize; str = std::unique_ptr&lt;char[]&gt;(new char(strSize+1)); std::copy_n(other.str.get(), strSize + 1, str.get()); } StringGetter(StringGetter&amp;&amp; other) = default; StringGetter&amp; operator=(const StringGetter&amp; rhs) { auto temp = rhs; swap(temp); return *this; } StringGetter&amp; operator=(StringGetter&amp;&amp; rhs) = default; const char* getString() const noexcept { return str.get(); } void swap(StringGetter&amp; other) { std::swap(str, other.str); std::swap(strSize, other.strSize); } private: std::unique_ptr&lt;char[]&gt; str; int strSize; }; </code></pre> <p>Miscellaneous items:</p> <p>1) Note that <code>std::unique_ptr</code> handles the RAII. When I replace 'str' in the copy constructor, it deletes the old string automatically.</p> <p>2) I size the dynamically allocated memory to match the input string. This prevents overflows/wasted memory.</p> <p>3) The constructor is <code>explicit</code>. This prevents undesirable conversions. Rule of thumb is to use the <code>explicit</code> keyword on all single argument constructors.</p> <p>4) I made <code>getString</code> constant so that you can still call it on <code>const</code> instances of the class.</p> <p>5) I replaced the str-family copy function with <code>std::copy_n</code>. It's more general and can avoid certain pitfalls in obscure cases.</p> <p>6) I used the copy-swap idiom in the copy assignment operator. This promotes code reuse/avoids duplication.</p> <p>7) When C++14 comes out, replace the <code>std::unique_ptr</code> constructor call with <code>std::make_unique</code> for added exception-safety and to remove redundancy.</p>
    singulars
    1. This table or related slice is empty.
    1. POC++ RAII - Do I have this right?
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USMark
    1. USMark
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POC++ RAII - Do I have this right?
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COIs the copy assignment operator safe when applied to self assignment?
      singulars
      1. PO
      1. USIInspectable
    2. CO@IInspectable - Should be, yes. You first make a copy with the copy constructor, so you never even have the same instance on both sides of an equals sign. Look up the copy-swap idiom. If you expected to be doing self assignment frequently, I'd advise adding an if statement to check for that so that you can return early and avoid the O(n) work.
      singulars
      1. PO
      1. USMark
    3. CO@IInspectable - you may find [this](http://www.umich.edu/~eecs381/lecture/Objectdynmemory.pdf) to be a helpful resource (page 10). The idiom actually buys us exception safety as well.
      singulars
      1. PO
      1. USMark
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload