Databases
StackOverflow2013
Postsdbo
POjQuery click binding function in Javascript loop using last parameter
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POjQuery click binding function in Javascript loop using last parameter
    primarykey
    data
    text
    <p>This is probably me being silly as per usual... but this is frustrating me.</p> <p>I have a foreach loop going through a multidimentional array, and for each item I'm adding a marker to a custom leafletjs map. Everything's working fine, except I have a custom click event on the marker (the fact that it's leafletjs should be irrelevant), and it's only ever using the last passed parameter. </p> <p>Here's the code:</p> <pre><code>var markerArray = [ ["aspiration", -55.63342652633955, -54.1953125, "aspiration-high-school", [19, 29], [38, 57], [75, 113], [150, 226], [299, 451], [597, 901]], ["bird", 12.89745, 69.99818, "bird", [22, 20], [44, 40], [87, 79], [173, 158], [345, 315], [689, 629]], ["camera", -22.908054128088575, -29.15421875, "camera", [15, 22], [29, 44], [57, 88], [113, 176], [225, 351], [450, 702]], ["chef", -46.6909603909255, 106.193125, "chef", [12, 54], [23, 108], [45, 215], [90, 430], [179, 859], [358, 1718]], ["computer", -57.37383096593114, 92.71484375, "computer", [14, 18], [28, 36], [56, 72], [112, 144], [223, 288], [445, 576]], ["film", -25.91792293614603, -43.69140625, "film", [13, 19], [25, 38], [49, 75], [98, 149], [196, 298], [392, 595]], ["gotthejob", -0.490228926463384, -61.02343749999999, "got-the-job", [40, 10], [80, 19], [160, 38], [320, 75], [639, 150], [1278, 300]], ["headmaster", -8.5, -60.57812500000001, "headmaster", [40, 44], [80, 87], [160, 173], [320, 346], [639, 692], [1278, 1383]], ["letter", -78.77138592818217, -57.15, "letter", [13, 11], [26, 21], [51, 42], [101, 83], [202, 166], [404, 331]], ["newspaper", -67.64766505841037, 92.6578125, "news-paper", [21, 15], [41, 30], [82, 59], [163, 117], [325, 234], [649, 467]], ["openday", -69.69785394109224, 24.3578125, "open-day", [15, 17], [29, 34], [57, 67], [113, 133], [226, 266], [452, 531]], ["prospectus", -11.885147283424319, -136.39453125, "prospectus", [37, 57], [74, 113], [148, 226], [295, 452], [590, 904], [1180, 1808]], ["ruler", -73.92669969306126, 4.94609375, "ruler", [12, 11], [24, 22], [48, 43], [96, 85], [192, 169], [384, 337]], ["schoollogo", 9.64906182688142, -108.50859375, "school-logo", [21, 27], [41, 53], [81, 106], [161, 211], [321, 421], [641, 841]], ["schoolplay", -3.013667927566642, -159.54921875, "school-play", [18, 43], [36, 86], [71, 172], [142, 344], [283, 687], [566, 1373]], ["sun", 14.98818922264095, 20.26953125, "sun", [40, 18], [79, 36], [158, 72], [316, 143], [631, 285], [1262, 570]], ["train", -81.93133285369295, -141.99609375, "train", [42, 30], [83, 60], [165, 119], [330, 237], [659, 473], [1317, 946]] ]; var zoom0MarkersArr = new Array(); var zoom1MarkersArr = new Array(); var zoom2MarkersArr = new Array(); var zoom3MarkersArr = new Array(); var zoom4MarkersArr = new Array(); var zoom5MarkersArr = new Array(); for (var arrayIndex = 0; arrayIndex &lt; markerArray.length; arrayIndex++) { var i = 0; while (i &lt;= 5) { var thisMarkerTypeStr = markerArray[arrayIndex][0]; var thisMarkerLat = markerArray[arrayIndex][1]; var thisMarkerLng = markerArray[arrayIndex][2]; var thisMarkerImage = markerArray[arrayIndex][3]; var thisMarkerImageSizeArr = markerArray[arrayIndex][i + 4]; var thisIcon = L.icon({ iconUrl: '../images/map/elements/' + i + '/' + thisMarkerImage + '.png', iconSize: thisMarkerImageSizeArr, className: thisMarkerImage + ' leaflet-zoom-hide' }); var thisMarker = L.marker([thisMarkerLat, thisMarkerLng], { icon: thisIcon }).on("click", function () { ShowDetails(thisMarkerTypeStr); }); window['zoom' + i + 'MarkersArr'].push(thisMarker); i++; } } var zoom0Markers = L.layerGroup(zoom0MarkersArr); var zoom1Markers = L.layerGroup(zoom1MarkersArr); var zoom2Markers = L.layerGroup(zoom2MarkersArr); var zoom3Markers = L.layerGroup(zoom3MarkersArr); var zoom4Markers = L.layerGroup(zoom4MarkersArr); var zoom5Markers = L.layerGroup(zoom5MarkersArr); </code></pre> <p>The function <code>ShowDetails</code> is currently just logging the name of the element clicked, which is always train.</p> <p>The variable being passed to the <code>ShowDetails</code> function, is a locally scoped one, so not sure why it's not working for me.</p> <p>Any help/obvious suggestions would be appreciated.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USZentaurus
    1. USMark Johnson
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POjQuery click binding function in Javascript loop using last parameter
      1. This table or related slice is empty.
      1. VTApproveEditSuggestion
    1. COhandler is executed once event is fired so `thisMarkerTypeStr` is the last value. BTW, looks like `thisMarkerTypeStr` is global
      singulars
      1. POjQuery click binding function in Javascript loop using last parameter
      1. USA. Wolff
    2. COHmm.. So actually, without doing this outside of a loop, I'm not going to be able to do this? I do have it working out of a loop, but there's an awful lot more code :-(. I guess if that's the way it has to be then that's that, was just hoping I could make it a little more elegant. Thanks for the pointer, I feared that may be the reason.
      singulars
      1. POjQuery click binding function in Javascript loop using last parameter
      1. USMark Johnson
    3. COyou can use a closure in a loop
      singulars
      1. POjQuery click binding function in Javascript loop using last parameter
      1. USA. Wolff
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload