Databases
StackOverflow2013
Postsdbo
POInsecure how to refactor repeated code
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POInsecure how to refactor repeated code
    primarykey
    data
    text
    <p>I'm trying to refactor an old legacy java app, and I have detected code that is repeated a lot of times in the project. I'm trying to place this code in only one place, but I don't know the best solution.</p> <p>The pseudocode for my problem is more or less the following:</p> <pre><code>public class MYDialog extends JDialog{ private VerySpecialHardwareDevice my_device; private int variable1; private int variable3; private int variableXX; private PropertyChangeListener my_listener=new PropertyChangeListener( { //The code of the listener interacts with the swing elements of the dialog //depending on the behaviour of the hardware device, and its //different most of the Jdialogs/Jpanels, and its the same in a few of them. }; public MyDialog(){ my_device=new VerySpecialHardwareDevice(); my_device.addPropertyChangeListener(my_listener); } /*Begin of the repeated method related with the special device*/ private void methodRelatedWithSpecialHardwareDevice1(){ //These methods and functions use some variables like variable 1, 2, etc }; private void methodRelatedWithSpecialHardwareDevice2(){...}; private void methodRelatedWithSpecialHardwareDevice3(){...}; (...) private void methodRelatedWithSpecialHardwareDevice15(){...}; /*************************************************************/ } public class MYPanel extends JPanel{ private VerySpecialHardwareDevice my_device; private int variable1; private int variable3; private int variableXX; private PropertyChangeListener my_listener=new PropertyChangeListener( { //.... }; public MyPanel(){ my_device=new VerySpecialHardwareDevice(); my_device.addPropertyChangeListener(my_listener); } /*Begin of the repeated method related with the special device*/ private void methodRelatedWithSpecialHardwareDevice1(){ //These methods and functions use some variables like variable 1, 2, etc }; private void methodRelatedWithSpecialHardwareDevice2(){...}; private void methodRelatedWithSpecialHardwareDevice3(){...}; (...) private void methodRelatedWithSpecialHardwareDevice15(){...}; /*************************************************************/ } </code></pre> <p>As you can see, the methods are related to a hardware device. The method from 1 to 15 are always the same, and this device is used in a lot of different Jdialogs and Jpanels accross the aplication (more than twenty forms). Each Jdialog has a property change listener which interacts with the gui depending on what the hardware device does. Most of the times these change listener are equal, but there are a few exceptions.</p> <p>My first intention was to move all this code (except the listener) to a superclass, but I'm insecure because I don't know wich superclass is the best for a Jdialog and a Jpanel at once...</p> <p>Maybe the is a better aproach to avoid this code repetition.</p> <p>Please excuse my bad ENglish and excuse me if this question has an obvious answer.</p> <p>Best regards</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USR. Campos
    1. USR. Campos
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COprobably, this should go to code-review
      singulars
      1. POInsecure how to refactor repeated code
      1. USsecario
    2. COAre methodRelatedWithSpecialHardwareDevice* functions refer any instance variables?
      singulars
      1. POInsecure how to refactor repeated code
      1. USuser987339
    3. COYes, the functions refer variables related with the hardware device, but the variables are always the same (they are repeated too), and not related with the Dialog or the Panel. I think that the variables can be moved to another place with the code. I will reflect that in my sample.
      singulars
      1. POInsecure how to refactor repeated code
      1. USR. Campos
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload