Databases
StackOverflow2013
Postsdbo
POSql Queries in a foreach slows down the page
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POSql Queries in a foreach slows down the page
    primarykey
    data
    text
    <p>I have a problem where I get an array of words and I have to insert every one of them in DB via a foreach, but the whole thing is running too slow.</p> <pre><code>foreach($words as $word) { // even more checks if(strlen($word) &lt; 3) continue; $word = $this-&gt;db-&gt;escapeString(strtolower($word)); // word not found? $result = $this-&gt;db-&gt;querySingle("SELECT id FROM words WHERE word = '{$word}'"); if(!$result) { $this-&gt;db-&gt;exec("INSERT INTO words (word) VALUES ('{$word}')"); $this-&gt;db-&gt;exec("INSERT INTO search (reply, word) VALUES ('{$id}', '{$this-&gt;db-&gt;lastInsertRowID()}')"); // word found } else $this-&gt;db-&gt;exec("INSERT INTO search (reply, word) VALUES ('{$id}', '{$result}')"); } </code></pre> <p>Basically lets say $words = array('hello', 'kitten'); Within that foreach, it will take my first word (hello) and check if it exists in the words table. If it cannot find the word, it will then insert it there and also insert it into another table with a variable $id that will not change within the foreach. If however it found the word it will insert it directly in the 2nd table. After that it will take the 2nd word (kitten) and do the same thing.</p> <p>Using php5 with sqlite3</p> <pre><code>$this-&gt;db = new \SQLite3(ROOT . DS . 'db' . DS . 'app.db'); </code></pre> <p>The tables in question are very light</p> <pre><code>CREATE TABLE words (id INTEGER PRIMARY KEY AUTOINCREMENT, word TEXT); CREATE TABLE search (reply INTEGER, word INTEGER); CREATE INDEX search_reply_idx ON search (reply); CREATE INDEX search_word_idx ON search (word); </code></pre> <p>This works fine most of the time for 10-15 words, but if i have over 150 words it will be as slow as 8 seconds. Can i combine the queries into just one? Am i missing something?</p> <p>Thanks.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USHighstrike
    plurals
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POSql Queries in a foreach slows down the page
      1. USHighstrike
      1. VTFavorite
    1. COTry taking out the `INSERT` statements and test the speed. You could do the `SELECT` statement first and remove any unfound words words from the original array, then use a single `INSERT` statement with all values left in the array.
      singulars
      1. POSql Queries in a foreach slows down the page
      1. USmulquin
    2. COIf i take out all of the insert queries its blazing fast, 150 words in 100 ms (ajax load time, this function runs as a ajax request). All words are used. If a word is not found it will use 2 inserts, if it is found it will use 1 insert. Even if there are no unfound words i still need to insert them, I don't understand your suggestion.
      singulars
      1. POSql Queries in a foreach slows down the page
      1. USHighstrike
    3. COCheck my answer for a more detailed response :)
      singulars
      1. POSql Queries in a foreach slows down the page
      1. USmulquin
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload