Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>Value readability above all else (well, as long as it is in the same ballpark efficiency).</p> <p>About the only changes I would make is to eliminate the unneeded variable, and use the function call in the conditional, and replace the ! operator with == false. This is easier to see for aging programmers like myself with bad eyesight :)</p> <p>As implied by the comment of another poster, it is better to make the function read InvalidXX instead, to avoid using negation or == false and for better readability.</p> <p>Also, as far as combining all the conditionals into a single "AND" statement, I would do that in lisp, but not in c#, because it will making debugging and tracing harder. </p> <p>In particular, you probably don't want to put the same error message for each case - you should have a different one for each case so you know exactly what happened. Combining all cases into a single expression won't allow you to do this.</p> <hr> <p>public bool Validate() { </p> <pre><code> if (ValidRecordIdentifiers() == false) { LogLogic.AddEntry(LogLogic.GetEnumDescription(LogMessages.StatusMessages.JobValidationFailed)); return false; } if (ValidTotals() == false) { LogLogic.AddEntry(LogLogic.GetEnumDescription(LogMessages.StatusMessages.JobValidationFailed)); return false; } if (ValidateRecordCount() == false) { LogLogic.AddEntry(LogLogic.GetEnumDescription(LogMessages.StatusMessages.JobValidationFailed)); return false; } LogLogic.AddEntry(LogLogic.GetEnumDescription(LogMessages.StatusMessages.JobValidationPassed)); return true; } </code></pre>
    singulars
    1. This table or related slice is empty.
    1. POC# Refactoring of If Statement
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USLarry Watanabe
    1. USLarry Watanabe
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTDownMod
    1. CO+1 for emphasising readability over other factors. However, boolean comparisons to `false` can be avoided, don't you think?
      singulars
      1. PO
      1. USCesarGon
    2. COAgree - better to make the functions read InvalidXX.
      singulars
      1. PO
      1. USLarry Watanabe
    3. COLarry, I do not think your (or the original) code ís better readable (for one who is used to the short-circuit idiom). And it is definitely not better maintainable, since it misses the DRY principle. Duplicate code means code that is harder to refactor. I would favor Kevins approach.
      singulars
      1. PO
      1. USDoc Brown
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload