Databases
StackOverflow2013
Postsdbo
PODatatable not saving any edits
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PODatatable not saving any edits
    primarykey
    data
    text
    <p>Hi guys i have a datatable from the primefaces library, which i am trying to include the feature of editing each cell and when the user presses a "save" button at the row it will update the edited values to a database, however currently when a user edits a cell what ever they change the cell to the second they click off the cell the value goes the same as what it was before, it does not save the new values, and also another issues is when the user presses save at the end of the row the values passwed to the database is always Null, how can i solve these two issues ?</p> <p>here is the xhtml</p> <pre><code>&lt;p:dataTable id="dataTable" var="u" value="#{userBean.getUserList()}" paginator="true" rows="10" paginatorTemplate="{CurrentPageReport} {FirstPageLink} {PreviousPageLink} {PageLinks} {NextPageLink} {LastPageLink} {RowsPerPageDropdown}" rowsPerPageTemplate="5,10,15,25" editable="true" editMode="cell" &gt; &lt;p:column&gt; &lt;!-- &lt;p:ajax event="rowEdit" listener="{u.onEdit}" update=":form:messages" /&gt; &lt;p:ajax event="rowEditCancel" listener="{u.onCancel}" update=":form:messages" /&gt; --&gt; &lt;f:facet name="header"&gt; User ID &lt;/f:facet&gt; #{u.userID} &lt;/p:column&gt; &lt;p:column headerText="Name" &gt; &lt;p:cellEditor&gt; &lt;f:facet name="output"&gt; &lt;h:outputText value="#{u.name}" /&gt; &lt;/f:facet&gt; &lt;f:facet name="input"&gt; &lt;p:inputText id="NameInput" value="#{u.name}" style="width:96%" /&gt; &lt;/f:facet&gt; &lt;/p:cellEditor&gt; &lt;/p:column&gt; &lt;p:column headerText="Email"&gt; &lt;p:cellEditor&gt; &lt;f:facet name="output"&gt; &lt;h:outputText value="#{u.email}" /&gt; &lt;/f:facet&gt; &lt;f:facet name="input"&gt; &lt;p:inputText id="EmailInput" value="#{u.email}" /&gt; &lt;/f:facet&gt; &lt;/p:cellEditor&gt; &lt;/p:column&gt; &lt;p:column headerText="Address"&gt; &lt;p:cellEditor&gt; &lt;f:facet name="output"&gt; &lt;h:outputText value="#{u.address}" /&gt; &lt;/f:facet&gt; &lt;f:facet name="input"&gt; &lt;p:inputText id="AddressInput" value="#{u.address}" /&gt; &lt;/f:facet&gt; &lt;/p:cellEditor&gt; &lt;/p:column&gt; &lt;p:column&gt; &lt;f:facet name="header"&gt; Created Date &lt;/f:facet&gt; #{u.created_date} &lt;/p:column&gt; &lt;p:column&gt; &lt;f:facet name="header"&gt; Delete &lt;/f:facet&gt; &lt;h:commandButton value="Delete" action="#{user.delete(u.userID)}" /&gt; &lt;/p:column&gt; &lt;p:column&gt; &lt;f:facet name="header"&gt; Save Edit &lt;/f:facet&gt; &lt;h:commandButton value="Save" action="#{user.editData(u.userID)}" /&gt; &lt;/p:column&gt; &lt;/p:dataTable&gt; </code></pre> <p>and here is the backing bean although currently this is only updating the database with the values from the databale</p> <pre><code>public void editData(long userID) { System.out.println(name); PreparedStatement ps = null; Connection con = null; if (userID != 0) { try { Class.forName("com.mysql.jdbc.Driver"); con = DriverManager.getConnection("jdbc:mysql://localhost:3306/test", "root", "root"); System.out.println(name); String sql = "UPDATE user1 set name = '" + name + "', email = '" + email + "', address = '" + address + "' WHERE userId=" + userID; ps = con.prepareStatement(sql); int i = ps.executeUpdate(); if (i &gt; 0) { System.out.println("Row updated successfully"); } } catch (Exception e) { e.printStackTrace(); } finally { try { con.close(); ps.close(); } catch (Exception e) { e.printStackTrace(); } } } } </code></pre> <p>the datable originally gets its values from the database </p> <p>Thanks</p> <p>Here is how i populate the datatable with values from the database,/*</p> <pre><code> * To change this template, choose Tools | Templates * and open the template in the editor. */ package richard.test; import java.sql.Connection; import java.sql.DriverManager; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; import javax.faces.bean.ManagedBean; import javax.faces.bean.SessionScoped; import richard.test.User; @ManagedBean(name = "userBean") @SessionScoped public class UserBean { List&lt;User&gt; list; PreparedStatement ps = null; Connection con = null; ResultSet rs = null; public List&lt;User&gt; getList() { return list; } public List&lt;User&gt; getUserList() { list = new ArrayList&lt;User&gt;(); try { Class.forName("com.mysql.jdbc.Driver"); con = DriverManager.getConnection("jdbc:mysql://localhost:3306/test", "root", "root"); String sql = "select * from user1"; ps = con.prepareStatement(sql); rs = ps.executeQuery(); while (rs.next()) { User usr = new User(); usr.setUserID(rs.getLong("userId")); usr.setName(rs.getString("name")); usr.setEmail(rs.getString("email")); usr.setAddress(rs.getString("address")); usr.setCreated_date(rs.getDate("created_date")); list.add(usr); Map&lt;Long, Boolean&gt; checked = new HashMap&lt;Long, Boolean&gt;(); List&lt;User&gt; checkedItems = new ArrayList&lt;User&gt;(); for (User item : list) { if (checked.get(item.getUserID()) != null) { checkedItems.add(item); usr.delete(usr.getUserID()); } } } } catch (Exception e) { e.printStackTrace(); } finally { try { con.close(); ps.close(); } catch (Exception e) { e.printStackTrace(); } } return list; } } </code></pre> <p>HERE is the full user bean code</p> <pre><code>/* * To change this template, choose Tools | Templates * and open the template in the editor. */ package richard.test; import javax.faces.application.FacesMessage; import javax.faces.bean.ManagedBean; import javax.faces.bean.RequestScoped; import javax.faces.context.FacesContext; import java.sql.Connection; import java.sql.DriverManager; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.text.SimpleDateFormat; import java.util.ArrayList; import java.util.Date; import java.util.HashMap; import java.util.List; import java.util.Map; import javax.faces.component.UIColumn; import javax.faces.event.ActionEvent; import org.primefaces.component.datatable.DataTable; import org.primefaces.event.CellEditEvent; import org.primefaces.event.RowEditEvent; @ManagedBean @RequestScoped public class User { List&lt;User&gt; list; PreparedStatement ps = null; Connection con = null; ResultSet rs = null; private long userID = 1; private String name; private String address; private Date created_date; private String email; boolean editable; public boolean isEditable() { return editable; } public void setEditable(boolean editable) { this.editable = editable; } public String editAction(User order) { order.setEditable(true); return null; } public long getUserID() { return userID; } public void setUserID(long userID) { this.userID = userID; } public String getName() { return name; } public void setName(String name) { this.name = name; } public String getEmail() { return email; } public void setEmail(String email) { this.email = email; } public String getAddress() { return address; } public void setAddress(String address) { this.address = address; } public Date getCreated_date() { return created_date; } public void setCreated_date(Date created_date) { this.created_date = created_date; } public String add() { System.out.println("In add"); SimpleDateFormat fmt = new SimpleDateFormat("yyyy-MM-dd"); int i = 0; if (userID != 0) { PreparedStatement ps = null; Connection con = null; try { System.out.println("about to add to db"); Class.forName("com.mysql.jdbc.Driver"); con = DriverManager.getConnection("jdbc:mysql://localhost:3306/test", "root", "root"); String sql = "INSERT INTO user1( name, email, address, created_date) VALUES(?,?,?,?)"; ps = con.prepareStatement(sql); ps.setString(1, name); ps.setString(2, email); ps.setString(3, address); if (created_date != null) { String date = fmt.format(created_date); Object obj = date; if (obj == null) { ps.setDate(4, null); } else { java.sql.Date dt = java.sql.Date.valueOf(new String(date)); ps.setDate(4, dt); } } i = ps.executeUpdate(); System.out.println("Data Added Successfully"); } catch (Exception e) { System.out.println(e); } finally { try { con.close(); ps.close(); } catch (Exception e) { e.printStackTrace(); } } if (i &gt; 0) { return "output"; } else { return "invalid"; } } else { return "invalid"; } } public void delete(long userID) { PreparedStatement ps = null; Connection con = null; if (userID != 0) { try { Class.forName("com.mysql.jdbc.Driver"); con = DriverManager.getConnection("jdbc:mysql://localhost:3306/test", "root", "root"); String sql = "DELETE FROM user1 WHERE userId=" + userID; ps = con.prepareStatement(sql); int i = ps.executeUpdate(); if (i &gt; 0) { System.out.println("Row deleted successfully"); } } catch (Exception e) { e.printStackTrace(); } finally { try { con.close(); ps.close(); } catch (Exception e) { e.printStackTrace(); } } } } public void editData(long userID) { PreparedStatement ps = null; Connection con = null; if (userID != 0) { try { Class.forName("com.mysql.jdbc.Driver"); con = DriverManager.getConnection("jdbc:mysql://localhost:3306/test", "root", "root"); System.out.println(name); String sql = "UPDATE user1 set name = '" + name + "', email = '" + email + "', address = '" + address + "' WHERE userId=" + userID; ps = con.prepareStatement(sql); int i = ps.executeUpdate(); if (i &gt; 0) { System.out.println("Row updated successfully"); } } catch (Exception e) { e.printStackTrace(); } finally { try { con.close(); ps.close(); } catch (Exception e) { e.printStackTrace(); } } } } } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USuser1924104
    1. USuser1924104
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COHave you used two different managedBeans(first named `userBean` from where dataTable's list is being generated. second named `user` where your action methods are placed)? Which scope are you used ? Please sufficient information to find the cause of problem.
      singulars
      1. PODatatable not saving any edits
      1. USDiganta
    2. COWe need more details concerning the "name"/"email"/etc. variables, used in your editData method. How do you make sure they hold the values entered by the user?
      singulars
      1. PODatatable not saving any edits
      1. USAneta Stępień
    3. COHi there, yes to retrive the details first of all i am using another bean called userBean, i have posted the code to this above, and @The Apprentice that is the issue i am currently having it does not hold the values when edited the second a user it reverts the value back to the original value in the field but one submitted to the database it passes Null
      singulars
      1. PODatatable not saving any edits
      1. USuser1924104
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload