Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>Your approach is good, however I would adjust few things. I have made few changes to your test and mocking components which you can see below.</p> <p><strong>Unit Test</strong></p> <p>You method under test within your Unit Test (see below), does not really match with the method which you have defined in your question.</p> <p>Unit test method call:</p> <pre><code>SubmissionVersion.DeleteNote(repo.Object, subVersion.Object, note.Id.Value); </code></pre> <p>Method under test:</p> <pre><code>public static SubmissionVersion DeleteNote (IRepository repository, SubmissionVersion version, Guid noteId) </code></pre> <p>I assume the above method is part of another class, I called it as <strong>NotesHelper</strong> - Not the ideal name for repository calls, but it is just to get the compilation working.</p> <p>I would personally separate out your Unit test into 2 separate Unit tests. One to verify whether the required methods being called, and the other is to verify whether the notes have been removed from the collection.</p> <p>Also instead of creating a mocked SubmissionVersion, I created a fakeSubmissionVersion. This is because the routines within SubmissionVersion may not be mockable. You can also do a state based testing (preferred) to ensure the version.Notes.Remove(note); has been called.</p> <pre><code>[Fact] public void DeleteNote_Deletion_VerifyExpectedMethodsInvokecOnlyOnce() { // Arrange var note = new Note { Id = Guid.NewGuid() }; var fakeSubmissionVersion = new SubmissionVersion() { Notes = new List&lt;Note&gt;() }; var repo = new Mock&lt;IRepository&gt;(); repo.Setup(x =&gt; x.GetById&lt;Note&gt;(It.IsAny&lt;Guid&gt;())).Returns(note); // Act NotesHelper.DeleteNote(repo.Object, fakeSubmissionVersion, note.Id.Value); // Assert repo.Verify(x =&gt; x.GetById&lt;Note&gt;(note.Id), Times.Once()); repo.Verify(x =&gt; x.Save(fakeSubmissionVersion), Times.Once()); repo.Verify(x =&gt; x.Delete(note), Times.Once()); } </code></pre> <p>The above test can be further improved by defining each Verification in its own test. </p> <pre><code>[Fact] public void DeleteNote_Deletion_VerifyDeleteMethodCalledOnlyOnce() </code></pre> <p>This way if one the test fails we would know exactly which method has not been called with the expectation. Sometimes, having multiple verifications as above can be problematic. For example, if the Save method has not been called, you would never know the Delete method has been called or not. This is because the exception has been thrown when the Save method has not been called and the test execution has been terminated.</p> <p>This would result in multiple tests but they are more readable and maintainable. Of course you can refactor the common code into a factory or helper method.</p> <pre><code>[Fact] public void DeleteNote_RemoveNotes_ReturnsExpectedNotes() { // Arrange var note = new Note { Id = Guid.NewGuid() }; var fakeSubmissionVersion = new SubmissionVersion() { Notes = new List&lt;Note&gt;() { note } }; var repo = new Mock&lt;IRepository&gt;(); repo.Setup(x =&gt; x.GetById&lt;Note&gt;(It.IsAny&lt;Guid&gt;())).Returns(note); // Act NotesHelper.DeleteNote(repo.Object, fakeSubmissionVersion, note.Id.Value); // Assert Assert.AreEqual(0, fakeSubmissionVersion.Notes.Count); } </code></pre> <p>Additional Note: Also providing a descriptive Unit test method names improves the readability of the Unit Tests.</p>
    singulars
    1. This table or related slice is empty.
    1. POUsing MOQ to test a repository
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USataravati
    1. USSpock
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. POUsing MOQ to test a repository
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTAcceptedByOriginator
    1. COVery good answer! Thanks for the insight!
      singulars
      1. PO
      1. USSam
    2. COCould you explain this a little more for me: `You method under test within your Unit Test (see below), does not really match with the method which you have defined in your question.`
      singulars
      1. PO
      1. USSam
    3. CO@Sam, no prob. That was about your question has "Given the following method" : public static SubmissionVersion DeleteNote(IRepository repository, SubmissionVersion version, Guid noteId) - I believe this is the method you testing (Method Under Test). But was not clear what class (System Under Test(SUT)) your test targeting. You also have ... new Mock<SubmissionVersion>() So I could not deduce what's your SUT, even your test intention is clear. So I introduced NotesHelper (not ideal) as your SUT.
      singulars
      1. PO
      1. USSpock
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload