Databases
StackOverflow2013
Postsdbo
POJava: Sorting Method Critique
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POJava: Sorting Method Critique
    primarykey
    data
    text
    <p>Could I please get your feedback on this sorting method I wrote? I'm specifically looking for ideas on anything that may be redundant/unnecessary or rewritten in a more efficient and/or readable manner, or just any feedback really.</p> <p>Essentially the method receives an ArrayList of Objects and sorts them in descending order based on an instance variable of type int that each Object contains. Specifically in my program it sorts by "int logicFace". </p> <p>I tried to create it by just swapping cards in the same passed-in ArrayList, but the shifting of indices caused by removing a card made the code more complicated, and I felt like removing from one array list and inserting into another separate ArrayList was more clean for a human to read. </p> <p>Here is the relevant Card instance variables, with standard getters:</p> <pre><code>public class Card { private String suit; private String face; private int logicSuit; private int logicFace; </code></pre> <p>And here is the method I would like your thoughts on:</p> <pre><code>public ArrayList&lt;Card&gt; sortByFace(ArrayList&lt;Card&gt; pile){ ArrayList &lt;Card&gt; sortedPile = new ArrayList &lt;Card&gt;(); int originalPileSize = pile.size(); int cardsRemoved = 0; while(cardsRemoved &lt; originalPileSize){ int highCardIndex = 0; while(true){ boolean swapPerformed = false; for(int i = 0; i &lt; pile.size(); i++){ if(pile.get(i).getLogicFace() &gt; pile.get(highCardIndex).getLogicFace()){ highCardIndex = i; if(!swapPerformed){ swapPerformed = true; } } } if(!swapPerformed){ sortedPile.add(pile.remove(highCardIndex)); cardsRemoved++; break; } } } pile = sortedPile; return pile; } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USJustin
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COImplement `compaerTo` (`Comparable` interface) and use `Arrays.sort()` or `Collections.sort()`
      singulars
      1. POJava: Sorting Method Critique
      1. USalfasin
    2. COThis question appears to be off-topic because it is about code review... it belongs on [codereview.se]
      singulars
      1. POJava: Sorting Method Critique
      1. USJim Garrison
    3. COTake a look at [sorting algorithms](http://en.wikipedia.org/wiki/Sorting_algorithm). That looks like an O(n^2) algorithm, there are plenty of O(n log n) algorithms available.
      singulars
      1. POJava: Sorting Method Critique
      1. USDukeling
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload