Databases
StackOverflow2013
Postsdbo
POIDisposable implementation in C# - is optional disposal of an injected IDisposable OK?
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIDisposable implementation in C# - is optional disposal of an injected IDisposable OK?
    primarykey
    data
    text
    <p>if I have fairly a standard abstract class which allows injection of an IDisposable instance. However, some classes inheriting from this class should NOT dispose the injected repository, where as others should. The obvious solution is to have a constructor:</p> <pre><code>public abstract class WorkspaceViewModel : IDisposable { readonly bool _cascadeDisposeRepository; protected WorkspaceViewModel(IRepository repository, bool cascadeDisposeRepository=true) { _repository = repository; _cascadeDisposeRepository = cascadeDisposeRepository; } </code></pre> <p><strong>Edit:</strong></p> <p>I also had a constructor with</p> <pre><code> protected WorkspaceViewModel() :this(new RepositoryA(), true){} </code></pre> <p><strong>End Edit</strong></p> <p>and then implement the Dispose method in the <a href="http://msdn.microsoft.com/en-us/library/vstudio/b1yfkh5e%28v=vs.100%29.aspx" rel="nofollow">recomended microsoft manner</a></p> <pre><code>protected virtual void Dispose(bool disposing) { if (!_disposed) { if (disposing) { if (_cascadeDisposeRepository) { _repository.Dispose(); } ..... </code></pre> <p>However, I have never seen IDisposable implemented in this way, and was wondering if it is bad practice (and if so, why, and what other solutions are preferable).</p> <p>Thank you for your thoughts.</p> <p><strong>edit:</strong> Mark's comment made me realise the preferable implementation may be without the parameter-less constructor, forcing any classes inheriting from WorkspaceViewModel to create and dispose their own instances (and choose to implement IDisposable), while removing IDisposable from the implemented interfaces for WorkspaceViewModel.</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USBrent
    1. USBrent
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. VO
      singulars
      1. POIDisposable implementation in C# - is optional disposal of an injected IDisposable OK?
      1. USAndrew Shepherd
      1. VTFavorite
    2. VO
      singulars
      1. POIDisposable implementation in C# - is optional disposal of an injected IDisposable OK?
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. POIDisposable implementation in C# - is optional disposal of an injected IDisposable OK?
      1. This table or related slice is empty.
      1. VTUpMod
    1. CODo you have handles unmanaged resources? Otherwise you shouldn't be using IDisposable at all (though you would not be the first).
      singulars
      1. POIDisposable implementation in C# - is optional disposal of an injected IDisposable OK?
      1. USmarkmnl
    2. COno, there are no unmanaged resources other than the IRepository in this abstract class - I will edit the post to show a bit more code, and why I had done things this way
      singulars
      1. POIDisposable implementation in C# - is optional disposal of an injected IDisposable OK?
      1. USBrent
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload