Databases
StackOverflow2013
Postsdbo
POClean-up of exceptions declared in interface but not thrown by implementation
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POClean-up of exceptions declared in interface but not thrown by implementation
    primarykey
    data
    text
    <p>I have a lot of Java interfaces with only one main implementation (not counting mocks and stubs).</p> <p>Over time, the interface and its implementation evolve, including the exceptions that are thrown by some methods.</p> <p>The problem is that when we add an exception in the implementation, the compiler reminds us to add the exception on the interface. But when an exception is not thrown anymore by the implementation, there is a warning reminding us to remove the exception declaration on the implementation, but we often forget to remove it from the interface.</p> <p>And so we end up, in the client code of the interface, dealing with exceptions that are never actually thrown.</p> <p>Step 1, we have an exception in the implementation, it is propagated up the chain:</p> <pre><code>interface Service { void doSomething() throws MyException; } class ServiceImpl implements Service { void doSomething() throws MyException { if (dummyCondition) { throw new MyException("oops"); } System.out.println("hello world"); } } class Client { @Inject Service service; void clientCode() { try { service.doSomething(); } catch(MyException e) { logger.error("oops", e); } } } </code></pre> <p>Step 2, the exception is not thrown anymore by the implementation, but we forgot to clean the interface, and so don't realize the catch is not useful anymore:</p> <pre><code>interface Service { void doSomething() throws MyException; } class ServiceImpl implements Service { void doSomething() { if (dummyCondition) { logger.warning("actually, don't throw, just log 'oops'"); } System.out.println("hello world"); } } class Client { @Inject Service service; void clientCode() { try { service.doSomething(); } catch(MyException e) { logger.error("oops", e); // we'll never get there. } } } </code></pre> <p>Ideally, I would like a warning on the interface saying something like "Exception declared but not thrown by any known implementation".</p> <p>Is there a way to detect those declared-but-never-thrown exceptions, in Eclipse or with a source code analysis tool, to be able to do some clean-up ?</p>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USXavier
    1. USXavier
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COWhen you do an API that will be used by external clients it is a good practice to declare all the Exceptions as RuntimeException.
      singulars
      1. POClean-up of exceptions declared in interface but not thrown by implementation
      1. USRamonBoza
    2. COShould you be implementing an interface, instead of updating the interface as a result of change in implementation ?
      singulars
      1. POClean-up of exceptions declared in interface but not thrown by implementation
      1. USSachin Thapa
    3. COIt's not meant to be used by external clients. It's only internal to my project. I'm declaring an interface to make it easier to test clients of the interface (which are other classes within the same product) without testing the implementation code at the same time
      singulars
      1. POClean-up of exceptions declared in interface but not thrown by implementation
      1. USXavier
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload