Databases
StackOverflow2013
Postsdbo
POIgnore exceptions caused by missing controller parameters
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POIgnore exceptions caused by missing controller parameters
    primarykey
    data
    text
    <p>I have an internet-facing website that's built using MVC4 and I occasionally get error reports from bots or curious users who send requests for incomplete URLs.</p> <p>For example:</p> <pre><code>public class ProductController : Controller { [HttpGet] public void View(int id) { // ... </code></pre> <ul> <li>A GET request to <code>/product/view/1</code> is valid.</li> <li>A GET request to <code>/product/view</code> is invalid as the argument is not specified.</li> </ul> <p>Such invalid requests raise exceptions resembling:</p> <pre><code>System.ArgumentException: The parameters dictionary contains a null entry for parameter 'id' of non-nullable type 'System.Int32' for method 'System.Web.Mvc.ActionResult View(Int32)' in 'Foo.ProductController'. An optional parameter must be a reference type, a nullable type, or be declared as an optional parameter. Parameter name: parameters at System.Web.Mvc.ActionDescriptor.ExtractParameterFromDictionary(ParameterInfo parameterInfo, IDictionary`2 parameters, MethodInfo methodInfo) at System.Web.Mvc.ReflectedActionDescriptor.&lt;&gt;c__DisplayClass1.&lt;Execute&gt;b__0(ParameterInfo parameterInfo) ... </code></pre> <p>As the exception message states, I could make the <code>id</code> argument nullable and check within the action method, but I have <em>many</em> controllers with <em>many</em> actions.</p> <p>I'd like to return a <code>BadRequest</code>/<code>NotFound</code> response to any request that fails to bind arguments to action parameters, and specify this in a single place in code to apply across all controllers.</p> <p>How can this be done?</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USDrew Noakes
    plurals
    1. PL
      singulars
      1. LTLinked
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COIn route config where u define the controller and action and parameter definition there u can specify the parameters as nullable.
      singulars
      1. POIgnore exceptions caused by missing controller parameters
      1. USAnirudh Agarwal
    2. CO@AnirudhAgarwal that will probably throw when trying to convert the null to an int
      singulars
      1. POIgnore exceptions caused by missing controller parameters
      1. USPanagiotis Kanavos
    3. CO@AnirudhAgarwal, the only way that'd work would be if I included a default value for `id` which I don't want to do. If `id` is defined on the action and it's not provided, then the client made a mistake and I want to send them a 404. Also, I have various different controllers, each of which would require entries in my route config. The whole point here is that I don't want to make custom changes across my actions and config just in case some user/bot sends invalid requests -- they should be handled centrally and not raise exceptions that cause me to receive error emails which I just delete.
      singulars
      1. POIgnore exceptions caused by missing controller parameters
      1. USDrew Noakes
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload