Databases
StackOverflow2013
Postsdbo
PODuplicate creation of JPA entity
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PODuplicate creation of JPA entity
    primarykey
    data
    text
    <p>I'm quite confused, I'm trying to find out why I'm getting the creation of two Customers in the database with the following code with no luck. I tried to cut all the noise from the code, I hope I didn't erased anything important for the resolution of the problem. Here are in the following order : Entities, DAOs, Services and the <em>SpecialService</em> with the <em>specialTreatment</em> which holds the bogus behavior.</p> <p>In the <em>specialTreatment</em> the aim is to get an existing Order with no Customer linked to it, create a new Customer, and associate it to the order.</p> <p>Entities :</p> <p>Order.java :</p> <pre><code>@Entity public class Order { @Id @GeneratedValue(strategy = GenerationType.IDENTITY) @Column(name = "pk_id_order") private Integer id; // Other fields ... @BatchFetch(value = BatchFetchType.IN) @JoinColumn(name = "fk_id_customer", referencedColumnName = "pk_id_customer") @ManyToOne(fetch = FetchType.LAZY, optional = false) private Customer customer; // Other fields ... // Getter &amp; setters for each field @Override public int hashCode() { int hash = 7; hash = 79 * hash + (this.id != null ? this.id.hashCode() : 0); return hash; } @Override public boolean equals(Object obj) { if (obj == null || !(obj instanceof Order)) { return false; } final Order other = (Order) obj; if (this.id != other.id &amp;&amp; (this.id == null || !this.id.equals(other.id))) { return false; } return true; } } </code></pre> <p>Customer.java :</p> <pre><code>@Entity public class Customer { @Id @GeneratedValue(strategy = GenerationType.IDENTITY) @Column(name = "pk_id_customer") private Integer id; // Other fields @OrderBy(value = "createdAt DESC") @OneToMany(mappedBy = "customer", fetch = FetchType.LAZY) private List&lt;Order&gt; orders; @Override public int hashCode() { return (id != null ? id.hashCode() : 0); } @Override public boolean equals(Object object) { if (object == null || !(object instanceof Customer)) { return false; } final Customer other = (Customer) object; if ((this.id == null &amp;&amp; other.id != null) || (this.id != null &amp;&amp; !this.id.equals(other.id))) { return false; } return true; } } </code></pre> <p>DAOs :</p> <pre><code>@Repository @Transactional public class CustomerDao { @PersistenceContext protected EntityManager em; public void create(Customer customer) { this.em.persist(customer); } } @Repository @Transactional public class OrderDao { @PersistenceContext protected EntityManager em; public Order edit(Order order) { return this.em.merge(order); } } </code></pre> <p>Services :</p> <pre><code>@Service @Transactional public class CustomerService { @Autowired private CustomerDao customerDao; public void create(Customer customer) { this.customerDao.create(customer); } } @Service @Transactional public class OrderService { @Autowired private OrderDao orderDao; public void edit(Order order) { this.orderDao.edit(order); } } @Service @Transactional public class SpecialService { @Autowired private CustomerService customerService; @Autowired private OrderService orderService; @Transactional(propagation = Propagation.REQUIRES_NEW) public void specialTreatment(Order order) { Customer customer = new Customer(); // Fill customer ... this.customerService.create(customer); // LINE X order.setCustomer(customer); // LINE Y this.orderService.edit(order); } } </code></pre> <p>Note : When commenting line X : - There is no customer created (as expected), the order is edited as expected When commenting line Y : - The customer is created as expected (only one row) but it is not linked to my Order</p> <p>The code is called from a Spring MVC controller</p> <p>Any advice ?</p>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USAlexandre Jacob
    1. USAlexandre Jacob
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. COHave you implemented proper equals/hashcode implementation in the entities?! Next there is no cascade in your `Order` entity and is it a bidirectional or unidirectional relationship?
      singulars
      1. PODuplicate creation of JPA entity
      1. USM. Deinum
    2. COJust edited my question with equals/hashcode of Customer and Order (generated by Netbeans). They are based on the auto incremented ID which is not set for Customer at this point. I also added a relation from Customer to Order which I'm not using here
      singulars
      1. PODuplicate creation of JPA entity
      1. USAlexandre Jacob
    3. COYou should always set both sides of the relationship (in my experience Hibernate can loose track if you don't).
      singulars
      1. PODuplicate creation of JPA entity
      1. USM. Deinum
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload