Databases
StackOverflow2013
Postsdbo
POjava.sql.SQLException: ORA-00917: missing comma
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POjava.sql.SQLException: ORA-00917: missing comma
    primarykey
    data
    text
    <p>I'm pulling my hair out trying to find the cause of the SqlExcpetion below. I'm using Oracle Database 11g Express and SqlDeveloper. I've looked through other posts, but so far no help.</p> <pre><code>java.sql.SQLException: ORA-00917: missing comma at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:447) at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396) at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:951) at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:513) at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:227) at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:531) at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:195) at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:1029) at oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1336) at oracle.jdbc.driver.OracleStatement.executeQuery(OracleStatement.java:1498) at oracle.jdbc.driver.OracleStatementWrapper.executeQuery(OracleStatementWrapper.java:406) at com.ets.hr.dao.EmployeeDAO.createEmployee(EmployeeDAO.java:30) at Test.main(Test.java:62) </code></pre> <p>Method below:</p> <pre><code>public void createEmployee(Employee e){ try{ Class.forName(oracleClass); Connection conn = DriverManager.getConnection(oracleUrl, "hr", "hr"); Statement s = conn.createStatement(); String query = "INSERT INTO employees VALUES(" + e.getEmployeeId() + ", '" + e.getFirstName() + "', '" + e.getLastName() + "', '" + e.getEmail() + "', '" + e.getPhoneNumber() + "', " + e.getHireDate() + ", '" + e.getJobId() + "', " + e.getSalary() + ", " + e.getCommissionPct() + ", " + e.getManagerId() + ", " + e.getDepartmentId() + ")"; s.executeQuery(query);//LINE 30 - SqlException Here System.out.println("Query Executed: Create Employee"); } catch(SQLException se){ se.printStackTrace(); } catch(ClassNotFoundException ce){ ce.printStackTrace(); } } </code></pre> <p>Employee Class:</p> <pre><code>package com.ets.hr.dto; import java.util.Date; public class Employee { //CONSTRUCTORS public Employee(){} public Employee(long eId, String firstName, String lastName, String email, String phoneNumber, Date hireDate, String jobId, double salary, double commissionPct, long managerId, long departmentId){ this.firstName = firstName; this.lastName = lastName; this.email = email; this.phoneNumber = phoneNumber; this.hireDate = hireDate; this.jobId = jobId; this.salary = salary; this.commissionPct = commissionPct; this.managerId = managerId; this.departmentId = departmentId; } //instance variables (from HR.EMPLOYEE table) private long employeeId; private String firstName; private String lastName; private String email; private String phoneNumber; private Date hireDate; private String jobId; private double salary; private double commissionPct; private long managerId; private long departmentId; //GETTERS public long getEmployeeId(){ return this.employeeId; } public String getFirstName(){ return this.firstName; } public String getLastName(){ return this.lastName; } public String getEmail(){ return this.email; } public String getPhoneNumber(){ return this.phoneNumber; } public Date getHireDate(){ return this.hireDate; } public String getJobId(){ return this.jobId; } public double getSalary(){ return this.salary; } public double getCommissionPct(){ return this.commissionPct; } public long getManagerId(){ return this.managerId; } public long getDepartmentId(){ return this.departmentId; } //SETTERS public void setEmployeeId(long employeeId){ this.employeeId = employeeId; } public void setFirstName(String firstName){ this.firstName = firstName; } public void setLastName(String lastName){ this.lastName = lastName; } public void setEmail(String email){ this.email = email; } public void setPhoneNumber(String phoneNumber){ this.phoneNumber = phoneNumber; } public void setHireDate(Date hireDate){ this.hireDate = hireDate; } public void setJobId(String jobId){ this.jobId = jobId; } public void setSalary(double salary){ this.salary = salary; } public void setCommissionPct(double commissionPct){ this.commissionPct = commissionPct; } public void setManagerId(long managerId){ this.managerId = managerId; } public void setDepartmentId(long departmentId){ this.departmentId = departmentId; } public void printEmployee(){ System.out.println("Employee ID: " + this.getEmployeeId()); System.out.println("Employee Name: " + this.getFirstName() + this.getLastName()); System.out.println("Employee Email: " + this.getEmail()); System.out.println("Employee Phone: " + this.getPhoneNumber()); System.out.println("Employee Hire Date: " + this.getHireDate()); System.out.println("Employee Job ID: " + this.getJobId()); System.out.println("Employee Salary: " + this.getSalary()); System.out.println("Employee Commission Pct: " + this.getCommissionPct()); System.out.println("Employee Manager ID: " + this.getManagerId()); System.out.println("Employee Department ID: " + this.getDepartmentId()); } </code></pre> <p>}</p>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. USJeff Levine
    1. USJeff Levine
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. COHave you tried looking at what the `query` string looks like before executing the query?
      singulars
      1. POjava.sql.SQLException: ORA-00917: missing comma
      1. USdee-see
    2. COAlong with the query string, posting the CREATE TABLE sql would be helpful.
      singulars
      1. POjava.sql.SQLException: ORA-00917: missing comma
      1. USkevinpeterson
    3. COFirst off, you should really not embed literals in your SQL statement. There is a whole litany of reasons why that is bad. That is what parameters are for. OK for one-off testing, but never do this in production code. You may have some syntax-related character in one of your fields.
      singulars
      1. POjava.sql.SQLException: ORA-00917: missing comma
      1. USOldProgrammer
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload