Databases
StackOverflow2013
Postsdbo
POPHP - File path isn't saved to database with file upload
 

Note that there are some explanatory texts on larger screens.

plurals
  1. POPHP - File path isn't saved to database with file upload
    primarykey
    data
    text
    <p>I have a script to handle image uploads and puts the location of the image in the database. There's two image upload fields, named "logo-image" and "header-image". The only time when things go wrong is when I only select a "logo-image". What happens then is that the image gets uploaded, but the file path isn't saved to the database. The error must be somewhere in the code below. Any idea what I am doing wrong?</p> <pre><code>if(file_exists($root."/upload/".$_FILES["header-image"]["name"])) { $filename = explode(".",$_FILES['header-image']['name']); $randomnumber = rand(0, 10000); $imageName = $filename[0].$randomnumber.".".$filename[1]; } else { $imageName = $_FILES['header-image']['name']; } $image = mysql_real_escape_string(htmlspecialchars("/upload/".$imageName)); if(file_exists($root."/upload/".$_FILES["logo-image"]["name"])) { $filename2 = explode(".",$_FILES['logo-image']['name']); $randomnumber2 = rand(0, 10000); $imageName2 = $filename2[0].$randomnumber2.".".$filename2[1]; } else { $imageName2 = $_FILES['logo-image']['name']; } $image2 = mysql_real_escape_string(htmlspecialchars("/upload/".$imageName2)); if (move_uploaded_file($_FILES["logo-image"]["tmp_name"], "./upload/".$imageName2) &amp;&amp; move_uploaded_file($_FILES["header-image"]["tmp_name"], "./upload/".$imageName)) { // save the data to the database mysql_query("INSERT verenigingen SET title='$titlename', description='$contentname', url='$urlname', omslag='$image', logo='$image2'") or die(mysql_error()); // once saved, redirect back to the view page header("Location: verenigingenindex.php"); } elseif (move_uploaded_file($_FILES["logo-image"]["tmp_name"], "./upload/".$imageName2) || move_uploaded_file($_FILES["header-image"]["tmp_name"], "./upload/".$imageName)) { // save the data to the database mysql_query("INSERT verenigingen SET title='$titlename', description='$contentname', url='$urlname', omslag='$image', logo='$image2'") or die(mysql_error()); // once saved, redirect back to the view page header("Location: verenigingenindex.php"); } else { // save the data to the database mysql_query("INSERT verenigingen SET title='$titlename', description='$contentname', url='$urlname'") or die(mysql_error()); // once saved, redirect back to the view page header("Location: verenigingenindex.php"); } </code></pre>
    singulars
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PTQuestion
    1. USaardnoot
    1. USaardnoot
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. CODon't do this... random numbers should NEVER be relied upon to keep your files from colliding. You're using a database. Insert a skeleton record into the DB, get its auto_increment ID, then use that **guaranteed unique** number for your on-disk filename.
      singulars
      1. POPHP - File path isn't saved to database with file upload
      1. USMarc B
    2. COYou probably need to post more of the code; is a value for `$image` defined in the case when you have the problem?
      singulars
      1. POPHP - File path isn't saved to database with file upload
      1. USJoe T
    3. COPlease, before you write **any** more SQL interfacing code, you must read up on [proper SQL escaping](http://bobby-tables.com/php) to avoid severe [SQL injection bugs](http://bobby-tables.com/). Also, `mysql_query` should not be used in new applications. It's a deprecated interface that's being removed from future versions of PHP. A modern replacement like [PDO is not hard to learn](http://net.tutsplus.com/tutorials/php/why-you-should-be-using-phps-pdo-for-database-access/). `htmlspecialchars` is pointless when used here.
      singulars
      1. POPHP - File path isn't saved to database with file upload
      1. UStadman
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload