Databases
StackOverflow2013
Postsdbo
PORefactoring a method containing conditional with extremely different code blocks that are the same ;)
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PORefactoring a method containing conditional with extremely different code blocks that are the same ;)
    primarykey
    data
    text
    <p>So I have this stinky method, the two conditional blocks do almost the exact same thing, but with radically different parameters (at least in my eyes). I want to clean it Uncle Bob style, but can't for the life of me figure out a tidy way of doing it. So I come to you, my fabulous nerd friends, to see how you might distill this down to something that doesn't make one want to gouge out their eyes. The code is AS3, but that doesn't really make a difference in my opinion.</p> <pre><code>/** * Splits this group into two groups based on the intersection of the group * with another group. The group is split in a direction to fill empty * cells left by the splitting group. * * @param onGroup * @param directionToMoveSplitCells * @return * */ public function split(onGroup:CellGroup, directionToMoveSplitCells:String):CellGroup { if (!hasIntersection(onGroup)) return this; var numCellsToSplit:int = 0; var splitCells:Array; var newGroup:CellGroup; var numberOfCellsToSplit:int; var splitStartIndex:int; var resultingGroupStartIndex:int; if (directionToMoveSplitCells == "RIGHT") { numberOfCellsToSplit = endIndex - onGroup.startIndex + 1; splitStartIndex = length - numberOfCellsToSplit; splitCells = trimCells(splitStartIndex, numberOfCellsToSplit); resultingGroupStartIndex = onGroup.endIndex + 1; if (splitCells.length &gt; 0) { newGroup = row.createGroup(splitCells, resultingGroupStartIndex) newGroup.nextGroup = nextGroup; if (newGroup.nextGroup) newGroup.nextGroup.previousGroup = newGroup; newGroup.previousGroup = this; nextGroup = newGroup; } } else { numberOfCellsToSplit = onGroup.endIndex - startIndex + 1; splitStartIndex = 0; splitCells = trimCells(splitStartIndex, numberOfCellsToSplit); resultingGroupStartIndex = onGroup.startIndex - splitCells.length; if (splitCells.length &gt; 0) { newGroup = row.createGroup(splitCells, resultingGroupStartIndex) newGroup.previousGroup = previousGroup; if (newGroup.previousGroup) newGroup.previousGroup.nextGroup = newGroup previousGroup = newGroup; newGroup.nextGroup = this; var newX:int = (onGroup.endIndex + 1) * cellSize.width; x = newX; } } removeArrayOfCellsFromGroup(splitCells); row.joinGroups(); row.updateGroupIndices(); repositionCellsInGroup(); return newGroup; } </code></pre>
    singulars
    1. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. PTQuestion
    1. This table or related slice is empty.
    1. USJoel Hooks
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PO
      singulars
      1. PTAnswer
    2. PO
      singulars
      1. PTAnswer
    3. PO
      singulars
      1. PTAnswer
    1. This table or related slice is empty.
    1. This table or related slice is empty.
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload