Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>Here is a refactored version. I've made the following changes:</p> <ul> <li>pulled out the status logic into user#progress_status and refactored it to make it more reusable and to cleanup the view</li> <li>used for loop in the view since it is more readable</li> <li>renamed user#add_hours to total_hours so it doesn't imply addition (command) but just a virtual attribute (which is a query)</li> <li>removed the order scope in the method since you don't need one this case</li> <li>made the total_hours cache its result on the user, so multiple subsequent calls don't hit the DB multiple times (as we do inside progress status)</li> </ul> <p>First the view. I've included only the content inside tbody:</p> <pre><code>&lt;% for user in @users %&gt; &lt;tr class="&lt;%= user.progress_status.to_s %&gt;"&gt; &lt;td&gt;&lt;%= user.name %&gt;&lt;/td&gt; &lt;td&gt;&lt;%= user.email %&gt;&lt;/td&gt; &lt;td&gt;&lt;%= user.total_hours %&gt;&lt;/td&gt; &lt;td&gt;&lt;%= user.roles.first and user.roles.first.name.titleize %&gt;&lt;/td&gt; &lt;td&gt; &lt;a data-toggle="modal" href="#role-options-&lt;%= user.id %&gt;" class="btn btn-mini" type="button"&gt;Change role&lt;/a&gt; &lt;%= render user %&gt; &lt;/td&gt; &lt;td&gt;&lt;%= link_to 'Timesheet', user_timesheets_path(user, @timesheets), class: "btn btn-mini" %&gt;&lt;/td&gt; &lt;/tr&gt; &lt;% end %&gt; </code></pre> <p>And the refactored user model methods:</p> <pre><code>def total_hours @total_hours ||= timesheets .where('day BETWEEN ? AND ?', Date.today.beginning_of_week, Date.today.end_of_week) .sum {|p| p.teacher + p.conversation + p.study} end def progress_status if has_role? :staff if total_hours &gt;= 10 :success elsif (7..9).include? total_hours :warning else :error end elsif has_role? :new_staff if total_hours &gt;= 15 :success elsif (12..14).include? total_hours :warning else :error end end end </code></pre> <p>You could go a bit further with the last method (when more context provided), but it should be OK for now.</p>
    singulars
    1. This table or related slice is empty.
    1. PORails Refactoring Block in Views - can I write this more efficiently?
      singulars
      1. PTQuestion
    1. PTAnswer
    1. USjurglic
    1. USjurglic
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. PORails Refactoring Block in Views - can I write this more efficiently?
      singulars
      1. PTQuestion
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTAcceptedByOriginator
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COOk so this is the one I ended up going with. All of the answers below were great as well though. There was one thing I did have to change though. For the view, I had to change `<td><%= user.add_hours %></td> ` to `<td><%= user.total_hours %></td> ` and it worked. This solution worked beautifully and reduced the load. Thank you so much! As a beginner rails programmer, I thank you!
      singulars
      1. PO
      1. USmisteroptimist
    2. COYou're right, it was a typo which I corrected now for the future references. Glad it helped =)
      singulars
      1. PO
      1. USjurglic
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload