StackOverflow2013

Note that there are some explanatory texts on larger screens.

plurals

POpre-commit hook doesn't check if saved changes are staged before running
primarykey
Id
18134090
data
AcceptedAnswerId
18135521
AnswerCount
1
ClosedDate
CommentCount
1
CommunityOwnedDate
CreationDate
2013-08-08T19:06:45.233
FavoriteCount
0
LastActivityDate
2013-08-08T20:29:34.953
LastEditDate
LastEditorUserId
0
OwnerUserId
881224
ParentId
0
PostTypeId
1
Score
0
ViewCount
807
LastEditorDisplayName
text
Body
I followed <a href="http://codeinthehole.com/writing/tips-for-using-a-git-pre-commit-hook/" rel="nofollow">this guide on creating git pre-commit hooks</a>, and so far I really like the benefit it's given me. However, I have a problem when I use it: <ol> <li>I write some code, perhaps something that doesn't pass a rubocop inspection.</li> <li>I stage it, then attempt to commit it. The pre-commit hook works as intended.</li> <li>I go and fix the issues that rubocop reported.</li> <li>I save the changes, but forget to <code>add</code> it to the index.</li> </ol> When I commit, my script just takes the list of files changed that are in <code>git diff --cached --name-only --diff-filter=AM</code>, runs rubocop on each of them, and quits if there's any issues. Here's my script: <pre><code>#!/bin/sh # Set the ruby environment from local/rvm, depending on your machine. # http://stackoverflow.com/questions/17515769 if [ -d "$HOME/.rvm/bin" ]; then PATH="$HOME/.rvm/bin:$PATH" [[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm" if [ -f ".ruby-version" ]; then rvm use "$(cat .ruby-version)" fi if [ -f ".ruby-gemset" ]; then rvm gemset use "$(cat .ruby-gemset)" fi fi # http://codeinthehole.com/writing/tips-for-using-a-git-pre-commit-hook/ FILES_PATTERN='\.rb(\..+)?$' FORBIDDEN='debug' # Quit if no ruby files are being checked in. RB_FILES=$(git df --cached --name-only --diff-filter=AM | grep -Ec $FILES_PATTERN) if [ "$RB_FILES" = "0" ]; then exit 0 fi git diff --cached --name-only --diff-filter=AM | \ grep -E $FILES_PATTERN | \ GREP_COLOR='37;41' xargs grep --color --with-filename -n $FORBIDDEN && \ echo 'Please remove debugging statements before commiting.' && exit 1 # Pull in altered files, check with rubocop. git diff --cached --name-only --diff-filter=AM | \ grep -E $FILES_PATTERN | xargs rubocop -f simple | \ grep 'no offences detected' && exit 0 # If it didn't exit 0 above, warn of issues, output results. echo 'Rubocop has detected issues with your commit.' && \ git diff --cached --name-only --diff-filter=AM | \ grep -E $FILES_PATTERN | xargs rubocop -f simple && exit 1 </code></pre> I don't want to use <code>sed</code> to parse through the results of <code>git diff</code>. Is there an easier way to ensure that I'm checking the index, opposed to the file as it appears on disk? My instinct tells me that there may be a way to check if there are any files that are both in <code>git diff --name-only --cached --diff-filter=M</code> and <code>git diff --name-only --diff-filter=M</code>, and just quit if that's the case. Other suggestions are welcome.
Tags
<git><bash><githooks><pre-commit>
Title
pre-commit hook doesn't check if saved changes are staged before running
singulars
PostAcceptedAnswerId
1. PO
 singulars
 PostTypePostTypeId
 PTAnswer
PostParentId
1. This table or related slice is empty.
PostTypePostTypeId
1. PTQuestion
UserLastEditorUserId
1. This table or related slice is empty.
UserOwnerUserId
1. USDroogans
plurals
PostLinksPostIdRelatedPostId
1. PL
 singulars
 LinkTypeLinkTypeId
 LTLinked
PostLinksRelatedPostIdPostId
1. This table or related slice is empty.
PostsAcceptedAnswerId
1. This table or related slice is empty.
PostsParentIdCreationDate
1. PO
 singulars
 PostTypePostTypeId
 PTAnswer
VotesPostIdCreationDate
1. This table or related slice is empty.
CommentsPostId
1. This table or related slice is empty.

Querying!

Guidance

A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.