Databases
StackOverflow2013
Postsdbo
PO
 

Note that there are some explanatory texts on larger screens.

plurals
  1. PO
    primarykey
    data
    text
    <p>First, Ruby always returns the value of the last statement by default, so we can get rid of the if/else:</p> <pre><code>def has_just_one_kind_of_thing?(item, controller) (controller == 'foos' &amp;&amp; item.widgets.blank?) || (controller == 'foos' &amp;&amp; item.doohickeys.blank?) || (controller == 'bars' &amp;&amp; item.widgets.blank?) || (controller == 'bars' &amp;&amp; item.doohickeys.blank?) || (controller == 'bazes' &amp;&amp; item.widgets.blank?) || (controller == 'bazes' &amp;&amp; item.contraptions.blank?) end </code></pre> <p>Now let's reformat for readability.</p> <pre><code>def has_just_one_kind_of_thing?(item, controller) (controller == 'foos' &amp;&amp; item.widgets.blank?) || (controller == 'foos' &amp;&amp; item.doohickeys.blank?) || (controller == 'bars' &amp;&amp; item.widgets.blank?) || (controller == 'bars' &amp;&amp; item.doohickeys.blank?) || (controller == 'bazes' &amp;&amp; item.widgets.blank?) || (controller == 'bazes' &amp;&amp; item.contraptions.blank?) end </code></pre> <p>There, now it's a lot easier to see patterns in the algorithm. It looks like there are two questions being asked here: is the controller one of [foos|bars|bazes] and are either widgets or doohickeys blank. Let's factor out the first question:</p> <pre><code>def has_just_one_kind_of_thing?(item, controller) %w[foos bars bazes].include?(controller) &amp;&amp; (item.widgets.blank? || item.doohickeys.blank?) end </code></pre> <p>This gets the method down to a managable size. But I infer from the method name that you are looking for the case where either widgets or doohickeys has items, but not both and not neither. If that is so, an XOR might be more appropriate:</p> <pre><code>def has_just_one_kind_of_thing?(item, controller) %w[foos bars bazes].include?(controller) &amp;&amp; (item.widgets.blank? ^ item.doohickeys.blank?) end </code></pre>
    singulars
    1. This table or related slice is empty.
    1. POHow can this 6 line method be refactored to be more readable?
      singulars
      1. PTQuestion
    1. PTAnswer
    1. This table or related slice is empty.
    1. USAvdi
    plurals
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. This table or related slice is empty.
    1. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    2. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    3. VO
      singulars
      1. PO
      1. This table or related slice is empty.
      1. VTUpMod
    1. COYou missed the contraptions, which only apply for the bazes.
      singulars
      1. PO
      1. USDonnie
    2. COAvdi, thanks do much for going through this in detail like this - it's been incredibly helpful.
      singulars
      1. PO
      1. USChris Adams
    3. COYou're welcome. I want to add that cartoonfox has the best solution on this page. Pushing part of the logic down into polymorphic behavior is the right thing to do, and the solution I would have settled on if I had continued forward and addressed Donnie's point.
      singulars
      1. PO
      1. USAvdi
 

Querying!

 
Guidance
A row detail

Detail views are divided into sections. All the information in the data section comes from columns in the selected row. The other sections display data from other, related rows.

Related data can be related in a to-one or a to-many fashion. Captions of data related in a to-many fashion link to a list view showing a filtered view of the table.

Try moving around until you find a non-empty to-many entry and click on the label to get to one. You can move back to the root by clicking on the database name in the header.

SQuiL has stopped working due to an internal error.

If you are curious you may find further information in the browser console, which is accessible through the devtools (F12).

Reload